Message ID | 87lfgo1nlv.fsf@cbaines.net |
---|---|
Headers | show |
Series | PostgreSQL service improvements | expand |
Christopher Baines <mail@cbaines.net> skribis: > Christopher Baines (5): > Replace (postgresql-service) with (service postgresql-service-type) > Add some subheadings in to the Databases section of the docs > Remove the postgresql-service procedure > Define postgresql-10 > Don't specify a default postgresql version to use for the service It all LGTM… except for commit logs. :-) Please add the conventional subject line and ChangeLog-style entries. I’m sorry to spoil your Monday morning. :-) Ludo’.
Ludovic Courtès <ludo@gnu.org> writes: > Christopher Baines <mail@cbaines.net> skribis: > >> Christopher Baines (5): >> Replace (postgresql-service) with (service postgresql-service-type) >> Add some subheadings in to the Databases section of the docs >> Remove the postgresql-service procedure >> Define postgresql-10 >> Don't specify a default postgresql version to use for the service > > It all LGTM… except for commit logs. :-) Please add the conventional > subject line and ChangeLog-style entries. I’m sorry to spoil your > Monday morning. :-) I've finally got around now to revising the commit messages and sent some updated patches.
Hi, Christopher Baines <mail@cbaines.net> skribis: > Ludovic Courtès <ludo@gnu.org> writes: > >> Christopher Baines <mail@cbaines.net> skribis: >> >>> Christopher Baines (5): >>> Replace (postgresql-service) with (service postgresql-service-type) >>> Add some subheadings in to the Databases section of the docs >>> Remove the postgresql-service procedure >>> Define postgresql-10 >>> Don't specify a default postgresql version to use for the service >> >> It all LGTM… except for commit logs. :-) Please add the conventional >> subject line and ChangeLog-style entries. I’m sorry to spoil your >> Monday morning. :-) > > I've finally got around now to revising the commit messages and sent > some updated patches. Perfect, go for it! Thanks, Ludo’.
Ludovic Courtès <ludo@gnu.org> writes: > Hi, > > Christopher Baines <mail@cbaines.net> skribis: > >> Ludovic Courtès <ludo@gnu.org> writes: >> >>> Christopher Baines <mail@cbaines.net> skribis: >>> >>>> Christopher Baines (5): >>>> Replace (postgresql-service) with (service postgresql-service-type) >>>> Add some subheadings in to the Databases section of the docs >>>> Remove the postgresql-service procedure >>>> Define postgresql-10 >>>> Don't specify a default postgresql version to use for the service >>> >>> It all LGTM… except for commit logs. :-) Please add the conventional >>> subject line and ChangeLog-style entries. I’m sorry to spoil your >>> Monday morning. :-) >> >> I've finally got around now to revising the commit messages and sent >> some updated patches. > > Perfect, go for it! Great, I've pushed these as bdcf4d88d58798eca7811c8b1fbd4638168d05c3 now. Thanks!