mbox series

[bug#69015,0/2] Deprecate the go-etcd-io-bbolt variable.

Message ID 87bk8ob6cd.fsf@troyfigiel.com
Headers show
Series Deprecate the go-etcd-io-bbolt variable. | expand

Message

Troy Figiel Feb. 10, 2024, 4:57 p.m. UTC 
This patch series removes a duplicate variable. We move go-go-etcd-io-bbolt to
gnu/packages/golang.scm and deprecate go-etcd-io-bbolt. Copyright did not need
to be updated.

I decided to keep go-go-etcd-io-bbolt, because this name follows the
conventions set by the Go importer.

Troy Figiel (2):
  gnu: go-go-etcd-io-bbolt: Move to (gnu packages golang).
  gnu: Deprecate the go-etcd-io-bbolt variable.

 gnu/packages/configuration-management.scm |  2 +-
 gnu/packages/databases.scm                | 28 -----------------
 gnu/packages/golang.scm                   | 38 ++++++++++++++---------
 3 files changed, 24 insertions(+), 44 deletions(-)


base-commit: e257de4365b24a84f39813aea2e8b4ab6259f283

Comments

Sharlatan Hellseher Feb. 10, 2024, 8:57 p.m. UTC | #1 
Hi Troy,

Thank you for the patch.

I'm in process of splitting monolithic golang.scm into logical
modules e.g. golang-web golang-crypto golang-xyz.

May you use one of them and try to avoid to add to golang.scm
as it eventually will remain just versions of go.

Thanks,
Oleg
Troy Figiel Feb. 10, 2024, 9:16 p.m. UTC | #2 
Hi Oleg,

I missed golang-xyz. I will move it to there.

Best wishes,

Troy

On 2024-02-10 21:57, Sharlatan Hellseher wrote:
> Hi Troy,
> 
> Thank you for the patch.
> 
> I'm in process of splitting monolithic golang.scm into logical
> modules e.g. golang-web golang-crypto golang-xyz.
> 
> May you use one of them and try to avoid to add to golang.scm
> as it eventually will remain just versions of go. 
> 
> Thanks,
> Oleg
Troy Figiel Feb. 10, 2024, 10:30 p.m. UTC | #3 
Hi Oleg,

Because I am deprecating go-etcd-io-bbolt in favour of
go-go-etcd-io-bbolt, its definition has to appear after
go-go-etcd-io-bbolt. I am aware alphabetical order is preferred, but in
this case that was not possible.

And of course I forgot to add my own copyright again...

Best wishes,

Troy
Sharlatan Hellseher Feb. 23, 2024, 8:06 a.m. UTC | #4 
Hi Troy,

go-team branch is initiated!


I completely removed go-etcd-io-bbolt as it was only used by Chezmoi,
and it had been broken for a while without any reports in the bug
tracker to fix it. This lack of activity gave me confidence that it was
not being used much.

2 patches are squashed and amended:
- [PATCH 3/3] gnu: Deprecate the go-etcd-io-bbolt variable.
- [PATCH 2/3] gnu: go-etcd-io-bbolt: Move to (gnu packages golang-xyz).

--8<---------------cut here---------------start------------->8---
gnu: Remove go-etcd-io-bbolt.

go-go-etcd-io-bbolt and go-etcd-io-bbolt are the same version and source
packages. This change removes go-etcd-io-bbolt and keeps
go-go-etcd-io-bbolt.

* gnu/packages/configuration-management.scm (chezmoi) [native-inputs]:
Add go-go-etcd-io-bbolt. Remove go-etcd-io-bbolt.
* gnu/packages/golang.scm (go-etcd-io-bbolt): Remove variable.
--8<---------------cut here---------------end--------------->8---

Pushed as d5d87a4e1d..b482b25d00 to go-team.

--
Oleg