mbox series

[bug#63354,0/4] Fix python-yubikey-manager build and update to 5.1.1.

Message ID 875y93u9mt.fsf@gmx.com
Headers show
Series Fix python-yubikey-manager build and update to 5.1.1. | expand

Message

Pierre Langlois May 7, 2023, 9:07 p.m. UTC
Hi Guix!

I recently noticed python-yubikey-manager fails to build on master,
here are a few patches to fix it by updating it and some of its
dependencies. Also cleaned the packages a little bit, and most
importantly enabled tests.

Thanks,
Pierre

Pierre Langlois (4):
  gnu: python-pyscard: Update to 2.0.7.
  gnu: python-fido2: Update to 1.1.1.
  gnu: Add python-makefun.
  gnu: python-yubikey-manager: Update to 5.1.1.

 gnu/packages/python-xyz.scm     | 22 ++++++++-
 gnu/packages/security-token.scm | 86 ++++++++++++++++-----------------
 2 files changed, 63 insertions(+), 45 deletions(-)


base-commit: 4c3532d7ab81a20e21d23bcf25e06999fcee2571

Comments

John Kehayias July 14, 2023, 4:26 p.m. UTC | #1
Hi Pierre,

On Sun, May 07, 2023 at 10:07 PM, Pierre Langlois wrote:

> Hi Guix!
>
> I recently noticed python-yubikey-manager fails to build on master,
> here are a few patches to fix it by updating it and some of its
> dependencies. Also cleaned the packages a little bit, and most
> importantly enabled tests.
>
> Thanks,
> Pierre
>

Thanks! I had actually done a lot of similar work but had got distracted
by the python build system changes (and poetry) and never looked to see
if the yubikey-manager part could be extracted out in:
https://issues.guix.gnu.org/63139

So, I combined what I had with yours to clean up a little more. I edited
some commit messages, fixed some typos, and checked everything builds.

Unfortunately I lost you as the author in the commit log, not sure what
happened. I was so careful locally in a branch but then missed it when I
went to actually push to master. Sorry about that! If there is a way to
remedy this or something else I can do anyone knows, please do share.

Pushed the series starting at 221806905b68f9b52b90bd5c80722d4a5ab3f353

Thanks again!

> Pierre Langlois (4):
>   gnu: python-pyscard: Update to 2.0.7.
>   gnu: python-fido2: Update to 1.1.1.
>   gnu: Add python-makefun.
>   gnu: python-yubikey-manager: Update to 5.1.1.
>
>  gnu/packages/python-xyz.scm     | 22 ++++++++-
>  gnu/packages/security-token.scm | 86 ++++++++++++++++-----------------
>  2 files changed, 63 insertions(+), 45 deletions(-)
>
>
> base-commit: 4c3532d7ab81a20e21d23bcf25e06999fcee2571