mbox series

[bug#62771,0/9] Add Easyeffects

Message ID 5fc823de-68d2-df3d-c7a0-2b6b474e262c@brendan.scot
Headers show
Series Add Easyeffects | expand

Message

Brendan Tildesley April 11, 2023, 8:06 a.m. UTC 
I realized there was already a patch for this package here but its a bit
out of date: https://issues.guix.gnu.org/57218

I did not use package-with-c-toolchain method because it seemed to
create some weird module dependency cycle with commencement
that broke compilation, so I just added gcc-11 to inputs.

I had to update a few dependencies to get this working, and we cannot
have the latest version until GTK>=4.10 is in guix. Additionally, serd
has a test suite now but there was an error with test_quiet.py "not
existing" even though it does, so I was left stumped and disabled tests
to avoid going insane.

Also this ends up causing a webkitgtk rebuild. Hope that isn't an issue.

Comments

Ricardo Wurmus Jan. 10, 2024, 9:40 a.m. UTC | #1 
Thank you so much for this patch series.  It looks good to me.  The
biggest problem is the large number of rebuilds, but we can use
ci.guix.gnu.org to build everything with this patch series applied.

I’ll create a new branch “wip-easyeffects-62771” and apply your
(rebased) patches, and then have ci.guix.gnu.org build it for x86_64.
If there are any new failures we should address them first.  Once there
are no new failures on x86_64 I’ll update the jobset to build for all
architectures.

Do you think you could keep an eye on the progress at ci.guix.gnu.org?

Minor issues that I’ll take care of before applying the patches:

* there’s a typo in a commit message:
  “[native-search-paths]: Add lv2 nad ladspa search paths.”
Brendan Tildesley Jan. 10, 2024, 12:32 p.m. UTC | #2 
On Wed, Jan 10, 2024, at 8:40 PM, Ricardo Wurmus wrote:
> Thank you so much for this patch series. 
>  [...]
You're welcome :]

I'm currently transferring at Singapore airport, heading to China. I think I will be busy and not prioritising guix at the moment. For now I'll assist on my my mobile phone by making a TODO list below:

It should be possible to remove the inclusion of gcc-11 as an input now that it is the default.
Update serd to 0.32.0
Update sord to 0.16.16
Update sratom to 0.6.16
Update rubber to 3.3.0
Update lilv to 0.24.22
Update lilv homepage to have .html on the end.
Fix typo in commit: native-search-paths]: Add lv2 nad ladspa search paths
Ricardo Wurmus Jan. 10, 2024, 12:34 p.m. UTC | #3 
Ricardo Wurmus <rekado@elephly.net> writes:

> I’ll create a new branch “wip-easyeffects-62771” and apply your
> (rebased) patches, and then have ci.guix.gnu.org build it for x86_64.
> If there are any new failures we should address them first.  Once there
> are no new failures on x86_64 I’ll update the jobset to build for all
> architectures.

I’ve rebased the patch set on top of master and took the opportunity to
enable the test suites in lilv, sratom, and serd.

The branch is being built here:

https://ci.guix.gnu.org/jobset/wip-easyeffects-62771
Ricardo Wurmus Jan. 10, 2024, 6:47 p.m. UTC | #4 
"Brendan Tildesley" <mail@brendan.scot> writes:

> It should be possible to remove the inclusion of gcc-11 as an input now that it is the default.
> Update serd to 0.32.0
> Update sord to 0.16.16
> Update sratom to 0.6.16
> Update rubber to 3.3.0
> Update lilv to 0.24.22
> Update lilv homepage to have .html on the end.
> Fix typo in commit: native-search-paths]: Add lv2 nad ladspa search paths

I’ve done all this and pushed to the wip-easyeffects-62771 branch.

> I'm currently transferring at Singapore airport, heading to China.

Safe travels!
Ricardo Wurmus Jan. 11, 2024, 10:51 p.m. UTC | #5 
Ricardo Wurmus <rekado@elephly.net> writes:

> "Brendan Tildesley" <mail@brendan.scot> writes:
>
>> It should be possible to remove the inclusion of gcc-11 as an input now that it is the default.
>> Update serd to 0.32.0
>> Update sord to 0.16.16
>> Update sratom to 0.6.16
>> Update rubber to 3.3.0
>> Update lilv to 0.24.22
>> Update lilv homepage to have .html on the end.
>> Fix typo in commit: native-search-paths]: Add lv2 nad ladspa search paths
>
> I’ve done all this and pushed to the wip-easyeffects-62771 branch.

I just merged it into the master branch.