| Message ID | 20220912000915.30537-1-matf@disr.it |
|---|---|
| Headers | show |
| Series | Add shirah and dependencies | expand |
M <matf@disr.it> writes: > shirah is a terminal-based ebook reader, which alone I'd see as a nice > addition to Guix packages considering how light, flexible and > customizable (themes, opacity, font options, keybindings) terminal > emulators are, but it also comes with an optional RSVP mode for speed > reading, which can be pretty convenient for a terminal reader since > terminal windows can be resized to very small geometry without > breaking. shirah also supports basic ebook-reading features, like > resuming a read, or browsing from the TOC. > > M (3): > gnu: Add python-ebooklib. > gnu: Add python-syllables. > gnu: Add shirah. > > gnu/packages/ebook.scm | 40 +++++++++++++++++++++++++++++++++++++ > gnu/packages/python-xyz.scm | 20 +++++++++++++++++++ > 2 files changed, 60 insertions(+) Hey, These generally look good to me, but I think there are a few things to fix before merging. The license information looks off for all packages, can you take a look? Also, the linter makes some comments about some package synopsis. Thanks, Chris
Thanks for the review! I fixed the synopsis and licenses for shirah and python-syllables, but python-ebooklib's agpl3 is correct, is it not? On 2022-09-14 10:09 Christopher Baines <mail@cbaines.net> wrote: > > M <matf@disr.it> writes: > >> shirah is a terminal-based ebook reader, which alone I'd see as a >> nice >> addition to Guix packages considering how light, flexible and >> customizable (themes, opacity, font options, keybindings) terminal >> emulators are, but it also comes with an optional RSVP mode for >> speed >> reading, which can be pretty convenient for a terminal reader since >> terminal windows can be resized to very small geometry without >> breaking. shirah also supports basic ebook-reading features, like >> resuming a read, or browsing from the TOC. >> >> M (3): >> gnu: Add python-ebooklib. >> gnu: Add python-syllables. >> gnu: Add shirah. >> >> gnu/packages/ebook.scm | 40 >> +++++++++++++++++++++++++++++++++++++ >> gnu/packages/python-xyz.scm | 20 +++++++++++++++++++ >> 2 files changed, 60 insertions(+) > > > Hey, > > These generally look good to me, but I think there are a few things > to > fix before merging. > > The license information looks off for all packages, can you take a > look? > > Also, the linter makes some comments about some package synopsis. > > Thanks, > > Chris
On 15-09-2022 21:57, Mathieu wrote:
> Thanks for the review! I fixed the synopsis and licenses for shirah and python-syllables, but python-ebooklib's agpl3 is correct, is it not?
Looking at
<https://github.com/aerkalov/ebooklib/blob/master/ebooklib/epub.py>, it
appears to be agpl3+, not agpl3.
Greetings,
Maxime.