mbox series

[bug#53880,0/2] Fix build of protonvpn-cli

Message ID 20220208180333.11502-1-dev@jpoiret.xyz
Headers show
Series Fix build of protonvpn-cli | expand

Message

Josselin Poiret Feb. 8, 2022, 6:03 p.m. UTC 
Hello,

These two patches fix the build failure of protonvpn-cli.  The first
one fixes the wrap target, since the wrapper code now properly handles
re-wrapping a wrapped binary.  The second removes the sanity-check
phase as the main entry point tries to create a directory under ~user,
which fails, and setting HOME=/tmp will not work since expanding ~user
uses the passwd database.

Best,

Josselin Poiret (2):
  gnu: protonvpn-cli: Do not try to wrap the wrapper.
  gnu: protonvpn-cli: Remove sanity-check phase.

 gnu/packages/vpn.scm | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Brice Waegeneire Feb. 12, 2022, 1:21 p.m. UTC | #1 
Hello Josselin,

Josselin Poiret <dev@jpoiret.xyz> writes:

> Josselin Poiret (2):
>   gnu: protonvpn-cli: Do not try to wrap the wrapper.
>   gnu: protonvpn-cli: Remove sanity-check phase.
>
>  gnu/packages/vpn.scm | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)

Thank you for the patch, it fixes <https://bugs.gnu.org/53855>. I've build the
package and ran the binary succesfully.  It's pushed as
9c8f68f4796f23c11173fa3f90c69bc85b224ac6 with an added copyright header.

Cheers,
- Brice