Message ID | 20211216130204.29996-1-othacehe@gnu.org |
---|---|
Headers | show |
Series | Further work on the image API. | expand |
Hi! Mathieu Othacehe <othacehe@gnu.org> skribis: > This series contains further work on the image API that I have postponed for > over a year. In short: > > * The guix system image command now supports the docker image type, which > means that the docker-image command is deprecated. > > * The docker images are not created in a VM (not needed), which results in a > creation speedup of around 6 times: 3 minutes vs 19 minutes for a simple > docker image on my x86 machine. > > * Most of the (gnu build vm) and (gnu system vm) code is removed. This is code > was largely duplicated in (gnu build image) and (gnu system image). We now > have a single entry point for creating images, that is faster, more robust > and portable. > > * I have added a "volatile?" flag to the <virtual-machine> record so that the > system tests can use a persistent or a volatile storage. I have adapted the > docker tests to use persistent storage. This means that those tests that > have been broken for a long time are now fixed. This is great. I didn’t try to run the code but I did look at the patches and it LGTM. > gnu/build/vm.scm | 500 ---------------------------------- Bye bye vm.scm, you were one of the oldest Guix System files. > 12 files changed, 279 insertions(+), 1084 deletions(-) I like that. :-) Thank you! Ludo’.
Hey! > This is great. I didn’t try to run the code but I did look at the > patches and it LGTM. Thanks for having a look :). I added a fix for the nfs test that has been failing forever before pushing. Now the hurd test should be the only failing system test! Thanks, Mathieu