[bug#33866] gnu: Add emacs-dedukti-mode emacs-flycheck-dedukti.

Message ID 87zhstx41e.fsf@gmail.com
State Accepted
Headers show
Series [bug#33866] gnu: Add emacs-dedukti-mode emacs-flycheck-dedukti. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Gabriel Hondet Dec. 25, 2018, 10:57 a.m. UTC
* gnu/packages/emacs.scm (emacs-dedukti-mode emacs-flycheck-dedukti): New variable.
---
 gnu/packages/emacs.scm | 43 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

Comments

Julien Lepiller Dec. 25, 2018, 5:46 p.m. UTC | #1
Le Tue, 25 Dec 2018 11:57:48 +0100,
Gabriel Hondet <gabrielhondet@gmail.com> a écrit :

> * gnu/packages/emacs.scm (emacs-dedukti-mode emacs-flycheck-dedukti):
> New variable. ---
>  gnu/packages/emacs.scm | 43
> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43
> insertions(+)
> 
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 7fdcfb1a3..8c8ae6fb9 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -12854,3 +12854,46 @@ functions to ensure they are called with the
> right arguments during testing.") @code{wordnet}.  Features include
> completion, if the query is not found too ambiguous and navigation in
> the result buffer.") (license license:gpl3+))))
> +
> +(define-public emacs-dedukti-mode
> +  (package
> +    (name "emacs-dedukti-mode")
> +    (version "git")
> +    (home-page "https://github.com/rafoo/dedukti-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit
> "d7c3505a1046187de3c3aeb144455078d514594e")))
> +              (sha256
> +               (base32
> +
> "1842wikq24c8rg0ac84vb1qby9ng1nssxswyyni4kq85lng5lcrp"))
> +              (file-name (git-file-name name version))))
> +    (build-system emacs-build-system)
> +    (synopsis "Emacs major mode for Dedukti files")
> +    (description "This package provides an Emacs major mode for
> editing Dedukti +files.")
> +    (license license:cecill-b)))
> +
> +(define-public emacs-flycheck-dedukti
> +  (package
> +    (name "emacs-flycheck-dedukti")
> +    (version "git")
> +    (home-page "https://github.com/rafoo/flycheck-dedukti")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit
> "3dbff5646355f39d57a3ec514f560a6b0082a1cd")))
> +              (sha256
> +               (base32
> +
> "1ffpxnwl3wx244n44mbw81g00nhnykd0lnid29f4aw1av7w6nw8l"))
> +              (file-name (git-file-name name version))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("dedukti-mode" ,emacs-dedukti-mode)
> +       ("flycheck-mode" ,emacs-flycheck)))
> +    (synopsis "Flycheck integration for the dedukti language")
> +    (description "This package provides a frontend for Flycheck to
> perform +syntax checking on dedukti files.")
> +    (license license:cecill-b)))

Thank you! I'm not an emacs-package expert, but they look fine, except:

please add a copyright line for yourself at the beginning of the file
the version numbers don't follow what can be found elsewhere. I've
never used it, but it seems that you can use git-version instead of
"git". Can you try that?

Thank you!
Julien Lepiller Dec. 25, 2018, 5:51 p.m. UTC | #2
Le Tue, 25 Dec 2018 11:57:48 +0100,
Gabriel Hondet <gabrielhondet@gmail.com> a écrit :

> * gnu/packages/emacs.scm (emacs-dedukti-mode emacs-flycheck-dedukti):
> New variable. ---
>  gnu/packages/emacs.scm | 43
> ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43
> insertions(+)
> 
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 7fdcfb1a3..8c8ae6fb9 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -12854,3 +12854,46 @@ functions to ensure they are called with the
> right arguments during testing.") @code{wordnet}.  Features include
> completion, if the query is not found too ambiguous and navigation in
> the result buffer.") (license license:gpl3+))))
> +
> +(define-public emacs-dedukti-mode
> +  (package
> +    (name "emacs-dedukti-mode")
> +    (version "git")
> +    (home-page "https://github.com/rafoo/dedukti-mode")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit
> "d7c3505a1046187de3c3aeb144455078d514594e")))
> +              (sha256
> +               (base32
> +
> "1842wikq24c8rg0ac84vb1qby9ng1nssxswyyni4kq85lng5lcrp"))
> +              (file-name (git-file-name name version))))
> +    (build-system emacs-build-system)
> +    (synopsis "Emacs major mode for Dedukti files")
> +    (description "This package provides an Emacs major mode for
> editing Dedukti +files.")
> +    (license license:cecill-b)))
> +
> +(define-public emacs-flycheck-dedukti
> +  (package
> +    (name "emacs-flycheck-dedukti")
> +    (version "git")
> +    (home-page "https://github.com/rafoo/flycheck-dedukti")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url home-page)
> +                    (commit
> "3dbff5646355f39d57a3ec514f560a6b0082a1cd")))
> +              (sha256
> +               (base32
> +
> "1ffpxnwl3wx244n44mbw81g00nhnykd0lnid29f4aw1av7w6nw8l"))
> +              (file-name (git-file-name name version))))
> +    (build-system emacs-build-system)
> +    (inputs
> +     `(("dedukti-mode" ,emacs-dedukti-mode)
> +       ("flycheck-mode" ,emacs-flycheck)))
> +    (synopsis "Flycheck integration for the dedukti language")
> +    (description "This package provides a frontend for Flycheck to
> perform +syntax checking on dedukti files.")
> +    (license license:cecill-b)))

Also, please send two separate patches, one per package :)
Julien Lepiller Dec. 27, 2018, 8:20 a.m. UTC | #3
Pushed as 4a2e1e72806fd62e54201a4aacde213d419d04bd and
ad536c98f9125f47dd948be7dd42d5c34e84bdfd, thank you!

Patch

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 7fdcfb1a3..8c8ae6fb9 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -12854,3 +12854,46 @@  functions to ensure they are called with the right arguments during testing.")
 @code{wordnet}.  Features include completion, if the query is not found
 too ambiguous and navigation in the result buffer.")
       (license license:gpl3+))))
+
+(define-public emacs-dedukti-mode
+  (package
+    (name "emacs-dedukti-mode")
+    (version "git")
+    (home-page "https://github.com/rafoo/dedukti-mode")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit "d7c3505a1046187de3c3aeb144455078d514594e")))
+              (sha256
+               (base32
+                "1842wikq24c8rg0ac84vb1qby9ng1nssxswyyni4kq85lng5lcrp"))
+              (file-name (git-file-name name version))))
+    (build-system emacs-build-system)
+    (synopsis "Emacs major mode for Dedukti files")
+    (description "This package provides an Emacs major mode for editing Dedukti
+files.")
+    (license license:cecill-b)))
+
+(define-public emacs-flycheck-dedukti
+  (package
+    (name "emacs-flycheck-dedukti")
+    (version "git")
+    (home-page "https://github.com/rafoo/flycheck-dedukti")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url home-page)
+                    (commit "3dbff5646355f39d57a3ec514f560a6b0082a1cd")))
+              (sha256
+               (base32
+                "1ffpxnwl3wx244n44mbw81g00nhnykd0lnid29f4aw1av7w6nw8l"))
+              (file-name (git-file-name name version))))
+    (build-system emacs-build-system)
+    (inputs
+     `(("dedukti-mode" ,emacs-dedukti-mode)
+       ("flycheck-mode" ,emacs-flycheck)))
+    (synopsis "Flycheck integration for the dedukti language")
+    (description "This package provides a frontend for Flycheck to perform
+syntax checking on dedukti files.")
+    (license license:cecill-b)))