[bug#35081] gnu: Add emacs-protobuf-mode.

Message ID 875zrw360v.fsf@zancanaro.id.au
State Accepted
Headers show
Series [bug#35081] gnu: Add emacs-protobuf-mode. | expand

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Carlo Zancanaro April 2, 2019, 1:12 p.m. UTC
Attached is a patch to add emacs-protobuf-mode, a major mode for 
editing Protocol Buffer source files.

I opted to add it in protobuf.scm instead of emacs-xyz.scm because 
it comes bundled with the protobuf source, and thus can share a 
source field.

Comments

Ludovic Courtès April 7, 2019, 8:25 p.m. UTC | #1
Carlo Zancanaro <carlo@zancanaro.id.au> skribis:

>>From de6067629a17c5884cc9e369a9ce0d4eafdd9f6a Mon Sep 17 00:00:00 2001
> From: Carlo Zancanaro <carlo@zancanaro.id.au>
> Date: Fri, 28 Dec 2018 18:46:21 +1100
> Subject: [PATCH] gnu: Add emacs-protobuf-mode.
> To: guix-patches@gnu.org
>
> * gnu/packages/protobuf.scm (emacs-protobuf-mode): New variable.

I updated the home page URL as suggested by ‘guix lint’ and committed,
thanks!

Ludo’.

Patch

From de6067629a17c5884cc9e369a9ce0d4eafdd9f6a Mon Sep 17 00:00:00 2001
From: Carlo Zancanaro <carlo@zancanaro.id.au>
Date: Fri, 28 Dec 2018 18:46:21 +1100
Subject: [PATCH] gnu: Add emacs-protobuf-mode.
To: guix-patches@gnu.org

* gnu/packages/protobuf.scm (emacs-protobuf-mode): New variable.
---
 gnu/packages/protobuf.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/protobuf.scm b/gnu/packages/protobuf.scm
index 73169216b4..3299299705 100644
--- a/gnu/packages/protobuf.scm
+++ b/gnu/packages/protobuf.scm
@@ -27,6 +27,7 @@ 
   #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
+  #:use-module (guix build-system emacs)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages gcc)
@@ -208,4 +209,21 @@  mechanism for serializing structured data.")
 
 (define-public python2-protobuf
   (package-with-python2 python-protobuf))
+
+(define-public emacs-protobuf-mode
+  (package
+    (name "emacs-protobuf-mode")
+    (version (package-version protobuf))
+    (source (package-source protobuf))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'set-emacs-load-path 'change-working-directory
+           (lambda _ (chdir "editors") #t)))))
+    (home-page "https://github.com/google/protobuf")
+    (synopsis "Protocol buffers major mode for Emacs")
+    (description
+     "This package provides an Emacs major mode for editing Protocol Buffer
+source files.")
+    (license license:bsd-3)))
-- 
2.21.0