| Message ID | 356e77d1fbad51a042ebb8eaae2804bb74a30c9b.1714036907.git.atai@atai.org |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#70563] gnu: Add pkcs11-helper. | expand |
patch passed QA https://qa.guix.gnu.org/issue/70563
patch passed QA https://qa.guix.gnu.org/issue/70563
user guix usertag 70563 + reviewed-looks-good thanks Guix QA review form submission: The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that. Otherwise LGTM. Items marked as checked: Lint warnings, Package builds, Commit messages, New package licenses, New package tests
Hi Andy, Did you receive Nicolas’ message below? Nicolas Graves <ngraves@ngraves.fr> skribis: > user guix > usertag 70563 + reviewed-looks-good > thanks > > Guix QA review form submission: > The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that. > > Otherwise LGTM. Note that despite being marked as “reviewed-looks-good”, Nicolas makes a suggestion that I think is worth addressing in a second version. Thanks, Ludo’.
OK I did not see that reply in email but I will send v2 patch addressing the comment On Mon, May 13, 2024 at 5:34 AM Ludovic Courtès <ludo@gnu.org> wrote: > > Hi Andy, > > Did you receive Nicolas’ message below? > > Nicolas Graves <ngraves@ngraves.fr> skribis: > > > user guix > > usertag 70563 + reviewed-looks-good > > thanks > > > > Guix QA review form submission: > > The description probably needs a little bit more precision. In particular, it would be good to include the statement "PKCS#11 is the de-facto standard to access cryptographic devices." or something like that. > > > > Otherwise LGTM. > > Note that despite being marked as “reviewed-looks-good”, Nicolas makes > a suggestion that I think is worth addressing in a second version. > > Thanks, > Ludo’.
diff --git a/gnu/packages/security-token.scm b/gnu/packages/security-token.scm index 00a7f97582..5e20424001 100644 --- a/gnu/packages/security-token.scm +++ b/gnu/packages/security-token.scm @@ -394,6 +394,30 @@ (define-public opensc #15 standard and the PKCS #11 API.") (license license:lgpl2.1+))) + +(define-public pkcs11-helper + (package + (name "pkcs11-helper") + (version "1.30.0") + (source + (origin + (method url-fetch) + (uri (string-append + "https://github.com/OpenSC/pkcs11-helper/releases/download/pkcs11-helper-" + version "/pkcs11-helper-" version ".tar.bz2")) + (sha256 + (base32 "1ac86jfj4qfwzbvsg6l9r4w4bbwxj2i9qi4dy1nz5aqcj6x1an2c")))) + (build-system gnu-build-system) + (inputs (list openssl-1.1 pcsc-lite)) + (native-inputs (list pkg-config)) + (home-page "https://github.com/OpenSC/pkcs11-helper") + (synopsis "Library that simplifies the interaction with PKCS#11 providers") + (description + "Pkcs11-helper is a library that simplifies the interaction with +PKCS#11 providers for end-user applications") + (license (list license:gpl2 license:bsd-3)))) + + (define-public yubico-piv-tool (package (name "yubico-piv-tool")