Message ID | Zd4vLpPI_d7H8kt5@obayashi |
---|---|
State | New |
Headers | show |
Series | [bug#69355] gnu: Add libgrapheme. | expand |
Hi cage, cage <cage-dev@twistfold.it> writes: [...] > --- > gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm > index 81e2151854..b89b3be961 100644 I've added a simple commit message, as autogenerated with 'add...TAB' in the commit message buffer in Emacs using yasnippet (you could have also used 'etc/committer.scm'). > --- a/gnu/packages/suckless.scm > +++ b/gnu/packages/suckless.scm > @@ -1393,3 +1393,36 @@ (define-public 9base > (description > "This package provides ported versions of various Plan 9 userland tools > for Unix."))) > + > +(define-public libgrapheme > + (package > + (name "libgrapheme") > + (version "2.0.2") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-" > + version > + ".tar.gz")) > + (sha256 > + (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6")))) > + (build-system gnu-build-system) > + (arguments > + (list #:tests? #true > + #:test-target "test" > + #:phases #~(modify-phases %standard-phases > + (add-after 'configure 'post-configure > + (lambda _ > + ;; removing call of ldconfing in makefile as it is > + ;; not actually needed in guix I punctuated the comment (as a full sentence, starting with a capital letter and ending with a period). > + (substitute* "config.mk" > + (("ldconfig") ""))))) > + #:make-flags > + #~(list (string-append "CC=" #$(cc-for-target)) > + (string-append "PREFIX=" #$output)))) > + (home-page "https://libs.suckless.org/libgrapheme/") > + (synopsis "Library to handle string according to Unicode standard.") I've changed the synopsis to say what it *is*: "C99 library for Unicode strings". Note the lack of a period for the synopsis (it is not a complete sentence -- I think 'guix lint' would have spotted that). > + (description "Libgrapheme is an extremely simple freestanding C99 library > +providing utilities for properly handling strings according to the latest > +Unicode standard.") > + (license license:isc))) I've dropped 'extremely' which sounded like marketing, and pushed. Thanks for your contribution!
On Sun, Mar 31, 2024 at 09:26:25PM -0400, Maxim Cournoyer wrote: > Hi cage, Hi! > cage <cage-dev@twistfold.it> writes: > > [...] > > > --- > > gnu/packages/suckless.scm | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm > > index 81e2151854..b89b3be961 100644 > > > I've added a simple commit message, as autogenerated with 'add...TAB' in > the commit message buffer in Emacs using yasnippet (you could have also > used 'etc/committer.scm'). Thanks for your suggestion, i tried using yasnippet but with no luck. :( But i will try again at the next patch, i swear! :D [...] > Note the lack of a period for the synopsis (it is not a > complete sentence -- I think 'guix lint' would have spotted that). Yes, likely i did not run guix line, this time, sorry! ^^; [...] > I've dropped 'extremely' which sounded like marketing, and pushed. I agree it is inappropriate here. > Thanks for your contribution! Thanks to you for fixing the patch! C.
diff --git a/gnu/packages/suckless.scm b/gnu/packages/suckless.scm index 81e2151854..b89b3be961 100644 --- a/gnu/packages/suckless.scm +++ b/gnu/packages/suckless.scm @@ -1393,3 +1393,36 @@ (define-public 9base (description "This package provides ported versions of various Plan 9 userland tools for Unix."))) + +(define-public libgrapheme + (package + (name "libgrapheme") + (version "2.0.2") + (source + (origin + (method url-fetch) + (uri (string-append "https://dl.suckless.org/libgrapheme/libgrapheme-" + version + ".tar.gz")) + (sha256 + (base32 "099i2jm9c25nkbg5420wr12z0gd189gcw5j1ssjmpmbbwzfvv2x6")))) + (build-system gnu-build-system) + (arguments + (list #:tests? #true + #:test-target "test" + #:phases #~(modify-phases %standard-phases + (add-after 'configure 'post-configure + (lambda _ + ;; removing call of ldconfing in makefile as it is + ;; not actually needed in guix + (substitute* "config.mk" + (("ldconfig") ""))))) + #:make-flags + #~(list (string-append "CC=" #$(cc-for-target)) + (string-append "PREFIX=" #$output)))) + (home-page "https://libs.suckless.org/libgrapheme/") + (synopsis "Library to handle string according to Unicode standard.") + (description "Libgrapheme is an extremely simple freestanding C99 library +providing utilities for properly handling strings according to the latest +Unicode standard.") + (license license:isc)))