| Message ID | CAFyhPjX+XuhZuzjbSTbAkO4QYDoidMT61M85ja3FntbZNHT+4Q@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [bug#63583] gnu: bitcoin-core: Update to 24.1. | expand |
Patch applied as 0aab24855238cc7c7a31066ab39cd94e534b857f. Thanks.
Hi, On ven., 19 mai 2023 at 13:30, Michael Ford <fanquake@gmail.com> wrote: > -(define-public bitcoin-core-23.1 > +(define-public bitcoin-core-24.1 [...] > - (version "23.1") > + (version "24.1") [...] > - "03k56vgk0a0wr84gpj256hvijk6iyshl85hcrx800hiznyzl5hkl")))) > + "0kmgpzknbykgwb8vd7hj3j1xxn35785gf4vii5705k6rnarks2la")))) [...] > -(define-public bitcoin-core bitcoin-core-23.1) > +(define-public bitcoin-core bitcoin-core-24.1) Out of curiosity, why are these two symbols required? Maybe, it could be nice to drop ’bitcoin-core-xy.z’ and keep only ’bitcoin-core’, no? WDYT? Cheers, simon
Simon Tournier <zimon.toutoune@gmail.com> skribis: > Hi, > > On ven., 19 mai 2023 at 13:30, Michael Ford <fanquake@gmail.com> wrote: > >> -(define-public bitcoin-core-23.1 >> +(define-public bitcoin-core-24.1 > > [...] > >> - (version "23.1") >> + (version "24.1") > > [...] > >> - "03k56vgk0a0wr84gpj256hvijk6iyshl85hcrx800hiznyzl5hkl")))) >> + "0kmgpzknbykgwb8vd7hj3j1xxn35785gf4vii5705k6rnarks2la")))) > > [...] > >> -(define-public bitcoin-core bitcoin-core-23.1) >> +(define-public bitcoin-core bitcoin-core-24.1) > > Out of curiosity, why are these two symbols required? Maybe, it could > be nice to drop ’bitcoin-core-xy.z’ and keep only ’bitcoin-core’, no? > > WDYT? > > Cheers, > simon Hi. IIRC, at some point in the past we had two versions of bitcoin-core, and the 'bitcoin-core' variable was pointing at one of the packages. Then one of the versions became outdated and was removed. Since we now have only one version, removing the leftovers from the multiple package version support stuff seems like a good idea...
Guillaume Le Vaillant <glv@posteo.net> skribis: > Simon Tournier <zimon.toutoune@gmail.com> skribis: > >> Hi, >> >> On ven., 19 mai 2023 at 13:30, Michael Ford <fanquake@gmail.com> wrote: >> >>> -(define-public bitcoin-core-23.1 >>> +(define-public bitcoin-core-24.1 >> >> [...] >> >>> - (version "23.1") >>> + (version "24.1") >> >> [...] >> >>> - "03k56vgk0a0wr84gpj256hvijk6iyshl85hcrx800hiznyzl5hkl")))) >>> + "0kmgpzknbykgwb8vd7hj3j1xxn35785gf4vii5705k6rnarks2la")))) >> >> [...] >> >>> -(define-public bitcoin-core bitcoin-core-23.1) >>> +(define-public bitcoin-core bitcoin-core-24.1) >> >> Out of curiosity, why are these two symbols required? Maybe, it could >> be nice to drop ’bitcoin-core-xy.z’ and keep only ’bitcoin-core’, no? >> >> WDYT? >> >> Cheers, >> simon > > Hi. > IIRC, at some point in the past we had two versions of bitcoin-core, and > the 'bitcoin-core' variable was pointing at one of the packages. Then > one of the versions became outdated and was removed. > Since we now have only one version, removing the leftovers from the > multiple package version support stuff seems like a good idea... Hi. Cleanup done in 24b6f94cf9b4ab97ef2eb70d05b2104a06776e62.
diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 57d3f37c7c..7f15be1202 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -134,10 +134,10 @@ (define-module (gnu packages finance) #:use-module (gnu packages xml) #:use-module (gnu packages gnuzilla)) -(define-public bitcoin-core-23.1 +(define-public bitcoin-core-24.1 (package (name "bitcoin-core") - (version "23.1") + (version "24.1") (source (origin (method url-fetch) (uri @@ -145,7 +145,7 @@ (define-public bitcoin-core-23.1 version "/bitcoin-" version ".tar.gz")) (sha256 (base32 - "03k56vgk0a0wr84gpj256hvijk6iyshl85hcrx800hiznyzl5hkl")))) + "0kmgpzknbykgwb8vd7hj3j1xxn35785gf4vii5705k6rnarks2la")))) (build-system gnu-build-system) (native-inputs (list autoconf @@ -216,7 +216,7 @@ (define-public bitcoin-core-23.1 ;; The support lifetimes for bitcoin-core versions can be found in ;; <https://bitcoincore.org/en/lifecycle/#schedule>. -(define-public bitcoin-core bitcoin-core-23.1) +(define-public bitcoin-core bitcoin-core-24.1) (define-public ghc-hledger (package
From 5cd545487e1f5c161f2aeb58b4e16b44269a7712 Mon Sep 17 00:00:00 2001 From: fanquake <fanquake@gmail.com> Date: Fri, 19 May 2023 13:29:18 +0100 Subject: [PATCH] gnu: bitcoin-core: Update to 24.1. --- gnu/packages/finance.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)