diff mbox series

[bug#62199,v3] gnu: Add emacs-fdroid.

Message ID 86ttye1mop.fsf@conses.eu
State New
Headers show
Series [bug#62199,v3] gnu: Add emacs-fdroid. | expand

Commit Message

Miguel Ángel Moreno March 21, 2023, 9:24 a.m. UTC 
* gnu/packages/emacs-xyz.scm (emacs-fdroid): New variable.
---
 gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Nicolas Goaziou March 21, 2023, 9:30 a.m. UTC | #1 
conses <contact@conses.eu> writes:

> * gnu/packages/emacs-xyz.scm (emacs-fdroid): New variable.

> +      #:phases #~(modify-phases %standard-phases
> +                   (add-after 'unpack 'patch-file-name
> +                     (lambda _
> +                       (emacs-substitute-variables "fdroid.el"
> +                         ("fdroid-program"
> +                          (string-append #$(this-package-input "fdroidcl")
> +                                         "/bin/fdroidcl"))))))))

Thanks.

I suggest to use `search-input-file' instead of of `this-package-input'
as it can find errors in the executable name at build time (e.g., if it
ever changes). It is also shorter.

Could you provide another update?

Otherwise, LGTM.

Regards,
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b1f72ee009..1cc8074fca 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -157,6 +157,7 @@  (define-module (gnu packages emacs-xyz)
   #:use-module (guix build-system trivial)
   #:use-module (gnu packages)
   #:use-module (gnu packages admin)
+  #:use-module (gnu packages android)
   #:use-module (gnu packages aspell)
   #:use-module (gnu packages audio)
   #:use-module (gnu packages bash)
@@ -6137,6 +6138,37 @@  (define-public emacs-fd
 result.")
     (license license:gpl3+)))
 
+(define-public emacs-fdroid
+  (package
+    (name "emacs-fdroid")
+    (version "0.1.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.sr.ht/~conses/fdroid.el")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1pmf9j9qcn71hjqdxqgdqf970irp75588nwnn234mapwqvx5v744"))))
+    (build-system emacs-build-system)
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'patch-file-name
+                     (lambda _
+                       (emacs-substitute-variables "fdroid.el"
+                         ("fdroid-program"
+                          (string-append #$(this-package-input "fdroidcl")
+                                         "/bin/fdroidcl"))))))))
+    (inputs (list fdroidcl))
+    (home-page "https://git.sr.ht/~conses/fdroid.el")
+    (synopsis "Manage F-Droid packages from Emacs")
+    (description "This package is an Emacs interface to F-Droid.  Its purpose
+is to aid in the management of F-Droid packages for an Android device or an
+emulator inside the comfort of Emacs.")
+    (license license:gpl3+)))
+
 (define-public emacs-ripgrep
   (package
     (name "emacs-ripgrep")