diff mbox series

[bug#59324,staging] gnu: spirv-tools: Disable building static libraries.

Message ID 7cb0f773144bd063aa2230d1dee284458846689a.1668639167.git.kaelyn.alexi@protonmail.com
State New
Headers show
Series [bug#59324,staging] gnu: spirv-tools: Disable building static libraries. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git-branch success View Git branch
cbaines/applying patch success
cbaines/issue success View issue

Commit Message

Kaelyn Takata Nov. 16, 2022, 10:52 p.m. UTC 
* gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
fix linking issues for packages such as mpv.
---
 gnu/packages/vulkan.scm | 3 +++
 1 file changed, 3 insertions(+)


base-commit: 29754d3683acd188c2c461b934227ba1d909ac63
--
2.38.0

Comments

Marius Bakke Nov. 17, 2022, 6:24 p.m. UTC | #1 
Kaelyn Takata via Guix-patches via <guix-patches@gnu.org> skriver:

> * gnu/packages/vulkan.scm (spirv-tools): Disable building static libraries to
> fix linking issues for packages such as mpv.

Pushed to 'staging' as 522d21863e, thanks!
diff mbox series

Patch

diff --git a/gnu/packages/vulkan.scm b/gnu/packages/vulkan.scm
index c00c06d7f3..6840f66c68 100644
--- a/gnu/packages/vulkan.scm
+++ b/gnu/packages/vulkan.scm
@@ -91,6 +91,9 @@  (define-public spirv-tools
     (build-system cmake-build-system)
     (arguments
      `(#:configure-flags (list "-DBUILD_SHARED_LIBS=ON"
+                               ;; Some packages like mpv fail to link
+                               ;; when the static libraries are built.
+                               "-DSPIRV_TOOLS_BUILD_STATIC=OFF"
                                (string-append
                                 "-DSPIRV-Headers_SOURCE_DIR="
                                 (assoc-ref %build-inputs "spirv-headers")))))