diff mbox series

[bug#52799] gnu: guile-udev: Update to 0.2.1

Message ID 874k6v6a54.fsf@gmail.com
State Accepted
Headers show
Series [bug#52799] gnu: guile-udev: Update to 0.2.1 | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

Artyom V. Poptsov Dec. 26, 2021, 8:30 a.m. UTC 
Hello Guixers,

this patch updates Guile-Udev[1] to version 0.2.1.

- Artyom

References:
1: https://github.com/artyom-poptsov/guile-udev

Comments

Mathieu Othacehe Dec. 26, 2021, 3:23 p.m. UTC | #1 
Hey Artyom,

You may prefer to use AC_PATH_PROG to locate guile_snarf, you can have a
look the configure.ac file of Guile-Avahi for instance.

> +     `(#:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch
> +                    (lambda* (#:key inputs outputs #:allow-other-keys)
> +                      (substitute* "build-aux/am/snarf"
> +                        (("\\$\\(shell whereis guile-snarf \\| cut -d' ' -f2\\)")
> +                         (format #f "~a/bin/guile-snarf"
> +                                 (assoc-ref inputs "guile")))))))))

Otherwise, outputs seems to be unused in this snippet. We also now try
to avoid relying on inputs labels. So using "search-input-file" or
(string-append #$(this-package-input guile) "/bin/snarf") would be
preferred.

You can have a look to:
https://guix.gnu.org/en/blog/2021/the-big-change/ for more details.

Thanks,

Mathieu
Brice Waegeneire April 24, 2022, 4:39 p.m. UTC | #2 
Hello Artyom,

poptsov.artyom@gmail.com (Artyom V. Poptsov) writes:

[...]
> this patch updates Guile-Udev[1] to version 0.2.1.
[...]

I see a more recent patch to update guile-udev to 0.2.3 as already been merged
in « 3c86268004 gnu: guile-udev: Update to 0.2.3 », so I'm closing this one.

Thank your work on guile-udev and guile-ssh.

Cheers,
- Brice
diff mbox series

Patch

From d852515e19ee338173c35ebdc555d83825cb835a Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Sun, 26 Dec 2021 11:26:44 +0300
Subject: [PATCH] gnu: guile-udev: Update to 0.2.1

* gnu/packages/guile-xyz.scm (guile-udev): Update to 0.2.1.
---
 gnu/packages/guile-xyz.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 8346d99996..b873e5ae08 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -1865,7 +1865,7 @@  users and in some situations.")
 (define-public guile-udev
   (package
     (name "guile-udev")
-    (version "0.2.0")
+    (version "0.2.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1874,8 +1874,16 @@  users and in some situations.")
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "037md1sg7bgsa4478hz1dbsivsxzdnl5acadlrsh4ds2yxbsb5jp"))))
+                "1wddzisgvgxk7ldcgbhpzgprkg77w8cng3lmpppdh9x1hl71x52g"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:phases (modify-phases %standard-phases
+                  (add-after 'unpack 'patch
+                    (lambda* (#:key inputs outputs #:allow-other-keys)
+                      (substitute* "build-aux/am/snarf"
+                        (("\\$\\(shell whereis guile-snarf \\| cut -d' ' -f2\\)")
+                         (format #f "~a/bin/guile-snarf"
+                                 (assoc-ref inputs "guile")))))))))
     (native-inputs
      (list autoconf
            automake
-- 
2.25.1