diff mbox series

[bug#52576] gnu: ibus-anthy: Update to 1.15.12

Message ID 20211217134028.29117-1-higashi@taiju.info
State Accepted
Headers show
Series [bug#52576] gnu: ibus-anthy: Update to 1.15.12 | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job
cbaines/issue success View issue

Commit Message

Taiju HIGASHI Dec. 17, 2021, 1:40 p.m. UTC 
Hi,

I'm using GNOME (40.4) with Guix, and version 1.5.9 of ibus-anthy had
a problem with ibus-anthy not being able to save settings.

I'm assuming this is the cause, since the release notes say that
ibus-anthy version 1.5.10 includes a fix for migrating from dConf to
GSettings.

1.5.10 adds a test, but I skipped running the test.  I wish I had a
better solution, but the fix including the test was difficult for me.
It also included tests for users to enter values in dialogs and to
update files under their home directories, so I thought it would be
better to skip the tests.

I have now applied this fix and am using it comfortably.

Thank you.

---
 gnu/packages/ibus.scm | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Taiju HIGASHI Dec. 17, 2021, 4:54 p.m. UTC | #1 
The version in the subject line was wrong, it was 1.5.12.
Ludovic Courtès Dec. 22, 2021, 10:20 p.m. UTC | #2 
Hi,

Taiju HIGASHI <higashi@taiju.info> skribis:

> I'm using GNOME (40.4) with Guix, and version 1.5.9 of ibus-anthy had
> a problem with ibus-anthy not being able to save settings.
>
> I'm assuming this is the cause, since the release notes say that
> ibus-anthy version 1.5.10 includes a fix for migrating from dConf to
> GSettings.

Good.

> 1.5.10 adds a test, but I skipped running the test.  I wish I had a
> better solution, but the fix including the test was difficult for me.
> It also included tests for users to enter values in dialogs and to
> update files under their home directories, so I thought it would be
> better to skip the tests.

Would it be possible to arrange to skip only the test(s) that expect to
run interactively?  It would be more robust than skipping all the tests.

Other than that the change LGTM.

BTW current ‘master’ has GNOME 41; it would be good to see how things
work now.

Thanks,
Ludo’.
Taiju HIGASHI Dec. 23, 2021, 5:44 a.m. UTC | #3 
Ludovic Courtès <ludo@gnu.org> writes:

Hi Lidovic,

Thank you for the response.

> Would it be possible to arrange to skip only the test(s) that expect to
> run interactively?  It would be more robust than skipping all the
> tests.

I've been working on a fix for the last few days that would allow me to
avoid skipping tests, but it's very difficult for me.

I tried to refer to how the major distributions implement it, but all of
the following seem to skip the test.

Arch:
https://github.com/archlinux/svntogit-community/blob/dce2fe2721db394fdf91cea5268dc9d636df0249/trunk/PKGBUILD

Gentoo:
https://gitweb.gentoo.org/repo/gentoo.git/tree/app-i18n/ibus-anthy/ibus-anthy-1.5.13.ebuild?id=fc38e3f625d2aee08a90e2eb19a80ccadf945094

Debian:
http://deb.debian.org/debian/pool/main/i/ibus-anthy/ibus-anthy_1.5.13-1.debian.tar.xz

The reason for skipping the tests in the Debian build process was described as follows.

> we do not make test for now since it needs a running ibus-daemon instance.

It is my understanding that the tests run by `make check` require `make install`.

> Hi,
>
> Taiju HIGASHI <higashi@taiju.info> skribis:
>
>> I'm using GNOME (40.4) with Guix, and version 1.5.9 of ibus-anthy had
>> a problem with ibus-anthy not being able to save settings.
>>
>> I'm assuming this is the cause, since the release notes say that
>> ibus-anthy version 1.5.10 includes a fix for migrating from dConf to
>> GSettings.
>
> Good.
>
>> 1.5.10 adds a test, but I skipped running the test.  I wish I had a
>> better solution, but the fix including the test was difficult for me.
>> It also included tests for users to enter values in dialogs and to
>> update files under their home directories, so I thought it would be
>> better to skip the tests.
>
> Would it be possible to arrange to skip only the test(s) that expect to
> run interactively?  It would be more robust than skipping all the tests.
>
> Other than that the change LGTM.
>
> BTW current ‘master’ has GNOME 41; it would be good to see how things
> work now.
>
> Thanks,
> Ludo’.
Taiju HIGASHI Dec. 24, 2021, 9:25 a.m. UTC | #4 
I contacted the maintainer and he said that version 5.1.13 of ibus-anthy
had been omitted from the release, so I will update to 5.1.13 as soon as
it is released.

https://github.com/ibus/ibus-anthy/issues/26
Taiju HIGASHI Dec. 24, 2021, 9:33 a.m. UTC | #5 
I made a mistake, it's 1.5.13.
I'm sorry for the mistake. I did it again.
Taiju HIGASHI Feb. 6, 2022, 3:56 p.m. UTC | #6 
Hi,

This case has been stopped for a while, but I'm curious about the
situation.
In the following bug reports, your wise and generous decisions have
given us a chance to expand the base of Japanese users of Guix.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=53536

This is the only other bug report that concerns me.

I may not be able to do much more about this issue, but I do recognize
that this is a relatively important issue for the Japanese.

Is there any way to move this forward?

Thanks
Liliana Marie Prikler Feb. 6, 2022, 8:51 p.m. UTC | #7 
Hi Taiju,

Am Montag, dem 07.02.2022 um 00:56 +0900 schrieb Taiju HIGASHI:
> Is there any way to move this forward?
ibus-anthy is a so-called leaf package (no other package depends on
it), so once we have a working solution, we can update it
"immediately".  However, adding #:tests? #f decreases confidence in a
patch a lot.  Since the problem is with a test case that was added, why
not simply disable just that test case(s)?  Enabling test cases for
poppler was what gave me the confidence to push to core-updates after
all 🙂
Taiju HIGASHI Feb. 7, 2022, 3:03 a.m. UTC | #8 
Hi Liliana,

Thank you for your response.

You are right. My attitude of expecting someone else to solve the
problem was no good.

So far, I haven't even been able to get the tests to run properly on
Guix.  Therefore, I can't even properly mention which test is the
problem.

I think it will take a long time to solve this problem due to my lack of
skills.
In particular, I think I will have a hard time reading the intent of the
test code. Also, other distributions skip the tests, so I have no source
to refer to.

I don't know if I will be able to start working on it right away, but I
would like to take the time to tackle it properly.
diff mbox series

Patch

diff --git a/gnu/packages/ibus.scm b/gnu/packages/ibus.scm
index edaeb59641..889b71f3c2 100644
--- a/gnu/packages/ibus.scm
+++ b/gnu/packages/ibus.scm
@@ -9,6 +9,7 @@ 
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll@gmail.com>
 ;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
 ;;; Copyright © 2021 Songlin Jiang <hollowman@hollowman.ml>
+;;; Copyright © 2021 Taiju HIGASHI <higashi@taiju.info>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -307,7 +308,7 @@  (define-public libpinyin
 (define-public ibus-anthy
   (package
     (name "ibus-anthy")
-    (version "1.5.9")
+    (version "1.5.12")
     (source (origin
               (method url-fetch)
               (uri (string-append
@@ -315,12 +316,13 @@  (define-public ibus-anthy
                     version "/ibus-anthy-" version ".tar.gz"))
               (sha256
                (base32
-                "1y8sf837rmp662bv6zakny0xcm7c9c5qda7f9kq9riv9ywpcbw6x"))))
+                "1fspvzgxr3r086515kap187n684gza3i25xbdqvr5qkaskfmirz9"))))
     (build-system gnu-build-system)
     (arguments
      '(#:configure-flags
        ;; Use absolute exec path in the anthy.xml.
        (list (string-append "--libexecdir=" %output "/libexec"))
+       #:tests? #f ; The tests in this package include test cases with user input, so skip them.
        #:phases
        (modify-phases %standard-phases
          (add-after 'install 'wrap-programs
@@ -338,6 +340,7 @@  (define-public ibus-anthy
                #t))))))
     (native-inputs
      `(("gettext" ,gettext-minimal)
+       ("glib:bin" ,glib "bin")
        ("intltool" ,intltool)
        ("pkg-config" ,pkg-config)
        ("python" ,python)))