| Message ID | BYAPR05MB4023E2534B1533DA96EA7677C5949@BYAPR05MB4023.namprd05.prod.outlook.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [bug#46994] gnu: polkit.scm: Add missing copyright headers. | expand |
| Context | Check | Description |
|---|---|---|
| cbaines/submitting builds | success | |
| cbaines/comparison | success | View comparision |
| cbaines/git branch | success | View Git branch |
| cbaines/applying patch | success | View Laminar job |
| cbaines/issue | success | View issue |
Hello, Morgan.J.Smith@outlook.com writes: > From: Morgan Smith <Morgan.J.Smith@outlook.com> > > * gnu/packages/polkit.scm: Add missing copyright headers. > --- > > I don't know if this is usually done. I just noticed that the file I was > working on had very few copyright lines so I filled it in with info from the > git history. This could be done if, for example, the packages got move but their copyright attribution forgotten. In which case careful review should be done to make sure the copyrights are moved or copied, accordingly. Also, code removal and trivial edits (such as updating < 10 lines, for example by bumping the version string and the hash of a package) are not usually considered significant enough to be copyrighted, so this may explain the discrepancy. Were the changes in the git history copyright-worthy? Thanks, Maxim
> Also, code removal and trivial edits (such as updating < 10 lines, for > example by bumping the version string and the hash of a package) are not > usually considered significant enough to be copyrighted, so this may > explain the discrepancy. > > Were the changes in the git history copyright-worthy? Most of these are trivial and do not deserve copyright. I was unaware of these exceptions. I believe the following copyright should be added: Ludo 2015 for cb151c68bf and 222e3319bd Neither of those two changes are greater than 10 lines but I'd call them non-trivial. Feel free to close this bug after you've decided if you'll add that one copyright. Had I known what I know now I wouldn't have opened this bug. Thanks, Morgan
diff --git a/gnu/packages/polkit.scm b/gnu/packages/polkit.scm index d868aceec2..7c7fc58bb6 100644 --- a/gnu/packages/polkit.scm +++ b/gnu/packages/polkit.scm @@ -1,11 +1,17 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2014 Andreas Enge <andreas@enge.fr> -;;; Copyright © 2015 Andy Wingo <wingo@igalia.com> -;;; Copyright © 2015 Mark H Weaver <mhw@netris.org> -;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il> +;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com> +;;; Copyright © 2015, 2018, 2019 Ludovic Courtès <ludo@gnu.org> +;;; Copyright © 2015, 2016 Andy Wingo <wingo@igalia.com> +;;; Copyright © 2015, 2016 Mark H Weaver <mhw@netris.org> +;;; Copyright © 2016, 2019 Efraim Flashner <efraim@flashner.co.il> +;;; Copyright © 2016 Alex Kost <alezost@gmail.com> +;;; Copyright © 2016 David Craven <david@craven.ch> ;;; Copyright © 2017 Huang Ying <huang.ying.caritas@gmail.com> ;;; Copyright © 2018 Tobias Geerinckx-Rice <me@tobias.gr> -;;; Copyright © 2018 Ricardo Wurmus <rekado@elephly.net> +;;; Copyright © 2018, 2019 Ricardo Wurmus <rekado@elephly.net> +;;; Copyright © 2018 Leo Famulari <leo@famulari.name> +;;; Copyright © 2019 Marius Bakke <mbakke@fastmail.com> ;;; ;;; This file is part of GNU Guix. ;;;
From: Morgan Smith <Morgan.J.Smith@outlook.com> * gnu/packages/polkit.scm: Add missing copyright headers. --- I don't know if this is usually done. I just noticed that the file I was working on had very few copyright lines so I filled it in with info from the git history. --- gnu/packages/polkit.scm | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-)