mbox

[bug#43771,0/5] PostgreSQL service improvements

Message ID 87lfgo1nlv.fsf@cbaines.net
Headers show

Message

Christopher Baines Oct. 2, 2020, 6:36 p.m. UTC 
Christopher Baines (5):
  Replace (postgresql-service) with (service postgresql-service-type)
  Add some subheadings in to the Databases section of the docs
  Remove the postgresql-service procedure
  Define postgresql-10
  Don't specify a default postgresql version to use for the service

 doc/guix.texi              | 52 +++++++++++++++++++++++++++++++-------
 gnu/packages/databases.scm |  2 ++
 gnu/services/databases.scm | 25 ++----------------
 gnu/tests/databases.scm    |  4 ++-
 gnu/tests/guix.scm         |  1 +
 gnu/tests/monitoring.scm   |  4 ++-
 gnu/tests/web.scm          |  4 ++-
 7 files changed, 57 insertions(+), 35 deletions(-)

Comments

Ludovic Courtès Oct. 5, 2020, 8:34 a.m. UTC | #1 
Christopher Baines <mail@cbaines.net> skribis:

> Christopher Baines (5):
>   Replace (postgresql-service) with (service postgresql-service-type)
>   Add some subheadings in to the Databases section of the docs
>   Remove the postgresql-service procedure
>   Define postgresql-10
>   Don't specify a default postgresql version to use for the service

It all LGTM… except for commit logs.  :-)  Please add the conventional
subject line and ChangeLog-style entries.  I’m sorry to spoil your
Monday morning.  :-)

Ludo’.
Ludovic Courtès Oct. 20, 2020, 9:32 p.m. UTC | #2 
Hi,

Christopher Baines <mail@cbaines.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> Christopher Baines (5):
>>>   Replace (postgresql-service) with (service postgresql-service-type)
>>>   Add some subheadings in to the Databases section of the docs
>>>   Remove the postgresql-service procedure
>>>   Define postgresql-10
>>>   Don't specify a default postgresql version to use for the service
>>
>> It all LGTM… except for commit logs.  :-)  Please add the conventional
>> subject line and ChangeLog-style entries.  I’m sorry to spoil your
>> Monday morning.  :-)
>
> I've finally got around now to revising the commit messages and sent
> some updated patches.

Perfect, go for it!

Thanks,
Ludo’.
Christopher Baines Oct. 20, 2020, 10:41 p.m. UTC | #3 
Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> Christopher Baines <mail@cbaines.net> skribis:
>>>
>>>> Christopher Baines (5):
>>>>   Replace (postgresql-service) with (service postgresql-service-type)
>>>>   Add some subheadings in to the Databases section of the docs
>>>>   Remove the postgresql-service procedure
>>>>   Define postgresql-10
>>>>   Don't specify a default postgresql version to use for the service
>>>
>>> It all LGTM… except for commit logs.  :-)  Please add the conventional
>>> subject line and ChangeLog-style entries.  I’m sorry to spoil your
>>> Monday morning.  :-)
>>
>> I've finally got around now to revising the commit messages and sent
>> some updated patches.
>
> Perfect, go for it!

Great, I've pushed these as bdcf4d88d58798eca7811c8b1fbd4638168d05c3
now. Thanks!