Message ID | 20200704182548.25280-1-arunisaac@systemreboot.net |
---|---|
Headers | show |
Hi Arun, Arun Isaac <arunisaac@systemreboot.net> skribis: > This patchset fixes a bug in the launchpad importer, and improves it to > recognize more URLs and extensions. `guix refresh --list-updaters` reports an > improvement in coverage from 0.1% to 0.2%. All three patches LGTM, thank you! > On a side note, all our updaters try to detect the URL format through a series > of guesses. But, all our packages already encode information about how to > construct the source URL from the version. If we could somehow tap into that > information, our updaters would be much simpler. Unfortunately, all the uri > fields of packages are strings. We would need them to be functions that take > the version as an argument. This is a major conversion. Is it feasible? Any > better ideas? I sympathize with the idea, but I think it’s a bit too ambitious. All in all, what we currently have seems like a reasonable tradeoff. Ludo’.
>> This patchset fixes a bug in the launchpad importer, and improves it to >> recognize more URLs and extensions. `guix refresh --list-updaters` reports an >> improvement in coverage from 0.1% to 0.2%. > > All three patches LGTM, thank you! Pushed to master, thanks for the review! > I sympathize with the idea, but I think it’s a bit too ambitious. All > in all, what we currently have seems like a reasonable tradeoff. Fair enough. :-)