| Message ID | cover.1696967309.git.peter@polidoro.io |
|---|---|
| Headers | show |
| Series | Three KiCad color themes | expand |
Hello, Thanks for this patch, it seems to work fine! I think it is acceptable to force extension installation through Guix. As a general remark some lines are too long, this is reported by the linter: https://qa.guix.gnu.org/issue/66453. On Github the version is 2021-12-05, so the packages with the 1.2 version are flagged as updatable: --8<---------------cut here---------------start------------->8--- gnu/packages/engineering.scm:1346:15: kicad-color-theme-solarized-dark@1.2: can be upgraded to 2021.12.05 --8<---------------cut here---------------end--------------->8--- You can also remove the '.git' suffix in `url` in git-reference: --8<---------------cut here---------------start------------->8--- gnu/packages/engineering.scm:1378:7: kicad-color-theme-solarized-light@1.2: permanent redirect from https://github.com/pointhi/kicad-color-schemes.git to https://github.com/pointhi/kicad-color-schemes --8<---------------cut here---------------end--------------->8--- Finally do you think it would be possible to package all the supported color themes in a single package? Thanks, Mathieu
Hello, I have been told by KiCad developers that the KICAD7_3RD_PARTY environment variable is not intended to be used for this purpose, since the directory pointed to by KICAD7_3RD_PARTY needs read/write privileges. I need to submit a feature request to the KiCad developers to allow colors to be installed into a system directory, so I need to place this patch series on hold until that request is handled. I may also need to request that they add another environment variable for KiCad to search the profile directory for plugins, although this may happen automatically. I am going to create a package for a plugin to see if that works before returning to this patch series. Thank you! Mathieu Othacehe <othacehe@gnu.org> writes: > [1. text/plain] > > Hello, > > Thanks for this patch, it seems to work fine! I think it is > acceptable > to force extension installation through Guix. > > As a general remark some lines are too long, this is reported by > the > linter: https://qa.guix.gnu.org/issue/66453. > > On Github the version is 2021-12-05, so the packages with the > 1.2 > version are flagged as updatable: > > [2. text/x-verbatim] > gnu/packages/engineering.scm:1346:15: > kicad-color-theme-solarized-dark@1.2: can be upgraded to > 2021.12.05 > > [3. text/plain] > > You can also remove the '.git' suffix in `url` in git-reference: > > [4. text/x-verbatim] > gnu/packages/engineering.scm:1378:7: > kicad-color-theme-solarized-light@1.2: permanent redirect from > https://github.com/pointhi/kicad-color-schemes.git to > https://github.com/pointhi/kicad-color-schemes > > [5. text/plain] > Finally do you think it would be possible to package all the > supported > color themes in a single package? > > Thanks, > > Mathieu
From: Peter Polidoro <peter@polidoro.io> These are three color theme packages for KiCad. More can easily be added later if this approach is deemed acceptable. These packages are installed using the KICAD7_3RD_PARTY environment variable and that search path has been added to the kicad package. Using the 3rd party environment variable makes it easy to install plug-ins and color themes in Guix without modifying the kicad source code. The disadvantage of using this environment variable is that it makes the 3rd party installation directory write only inside the store so the KiCad Plugin and Content Manager can no longer be used inside of KiCad for installing 3rd party add-ons if any Guix add-on package is installed into the Guix profile. An alternative approach would be to modify the kicad source code within the Guix kicad package so that another environment variable could be used for installing Guix kicad add-on packages, allowing the KiCad Plugin and Content Manager to be used at the same time, installing files into the user's home directory. Since most Guix users want a reproducible software environment it seems reasonable that they might want all add-on software to be installed using Guix packages rather than a combination of Guix packages and local files using the KiCad Plugin and Content manager, especially after all of the common color themes and plugins have been packaged in Guix. Peter Polidoro (4): gnu: kicad: Add 3rdparty search path. gnu: Add kicad-color-theme-behave-dark. gnu: Add kicad-color-theme-solarized-dark. gnu: Add kicad-color-theme-solarized-light. gnu/packages/engineering.scm | 95 +++++++++++++++++++++++++++++++++++- 1 file changed, 94 insertions(+), 1 deletion(-)