Message ID | 87pn7ndee3.fsf@gmx.com |
---|---|
State | Accepted |
Headers | show |
Series | [bug#42890] gnu: taglib: Include patch to prevent OGG corruption. | expand |
Context | Check | Description |
---|---|---|
cbaines/comparison | success | View comparision |
cbaines/git branch | success | View Git branch |
cbaines/applying patch | fail | View Laminar job |
Hi! Pierre Langlois <pierre.langlois@gmx.com> skribis: >>From 97a5d71bd50c72d2d7562a7d22baca04f4987657 Mon Sep 17 00:00:00 2001 > From: Pierre Langlois <pierre.langlois@gmx.com> > Date: Tue, 18 Aug 2020 18:38:01 +0100 > Subject: [PATCH] gnu: taglib: Update to 1.12-beta-1. > > This switches to a yet unreleased version of taglib, to make sure long > standings issues and CVEs are covered until a proper release is made upstream. > > Among these, we have: > > - CVE-2017-12678 > - CVE-2018-11439 > - https://github.com/taglib/taglib/issues/864 > > * gnu/packges/mp3.scm (taglib): Update to 1.12-beta-1. > [source]: Switch to using git-fetch. It’s a good idea to add “[security fixes]” or to list CVEs in the subject line of the commit log. Otherwise LGTM! You can now use your new super commit powers to push it. :-) Thanks, Ludo’.
Ludovic Courtès writes: > Hi! > > Pierre Langlois <pierre.langlois@gmx.com> skribis: > >>>From 97a5d71bd50c72d2d7562a7d22baca04f4987657 Mon Sep 17 00:00:00 2001 >> From: Pierre Langlois <pierre.langlois@gmx.com> >> Date: Tue, 18 Aug 2020 18:38:01 +0100 >> Subject: [PATCH] gnu: taglib: Update to 1.12-beta-1. >> >> This switches to a yet unreleased version of taglib, to make sure long >> standings issues and CVEs are covered until a proper release is made upstream. >> >> Among these, we have: >> >> - CVE-2017-12678 >> - CVE-2018-11439 >> - https://github.com/taglib/taglib/issues/864 >> >> * gnu/packges/mp3.scm (taglib): Update to 1.12-beta-1. >> [source]: Switch to using git-fetch. > > It’s a good idea to add “[security fixes]” or to list CVEs in the > subject line of the commit log. > > Otherwise LGTM! > > You can now use your new super commit powers to push it. :-) Whoohoo! done :-)
From 97a5d71bd50c72d2d7562a7d22baca04f4987657 Mon Sep 17 00:00:00 2001 From: Pierre Langlois <pierre.langlois@gmx.com> Date: Tue, 18 Aug 2020 18:38:01 +0100 Subject: [PATCH] gnu: taglib: Update to 1.12-beta-1. This switches to a yet unreleased version of taglib, to make sure long standings issues and CVEs are covered until a proper release is made upstream. Among these, we have: - CVE-2017-12678 - CVE-2018-11439 - https://github.com/taglib/taglib/issues/864 * gnu/packges/mp3.scm (taglib): Update to 1.12-beta-1. [source]: Switch to using git-fetch. --- gnu/packages/mp3.scm | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 92e3d5d5f8..7ee009df74 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -4,7 +4,7 @@ ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org> ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il> ;;; Copyright © 2017 Thomas Danckaert <post@thomasdanckaert.be> -;;; Copyright © 2017, 2019 Pierre Langlois <pierre.langlois@gmx.com> +;;; Copyright © 2017, 2019, 2020 Pierre Langlois <pierre.langlois@gmx.com> ;;; Copyright © 2018, 2019, 2020 Tobias Geerinckx-Rice <me@tobias.gr> ;;; Copyright © 2019 Ricardo Wurmus <rekado@elephly.net> ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de> @@ -50,6 +50,7 @@ #:use-module (gnu packages video) ;ffmpeg #:use-module (guix packages) #:use-module (guix download) + #:use-module (guix git-download) #:use-module (guix utils) #:use-module (guix build-system gnu) #:use-module (guix build-system python) @@ -160,14 +161,16 @@ a highly stable and efficient implementation.") (define-public taglib (package (name "taglib") - (version "1.11.1") + (version "1.12-beta-1") (source (origin - (method url-fetch) - (uri (string-append "http://taglib.github.io/releases/taglib-" - version ".tar.gz")) + (method git-fetch) + (uri (git-reference + (url "https://github.com/taglib/taglib") + (commit (string-append "v" version)))) + (file-name (git-file-name name version)) (sha256 (base32 - "0ssjcdjv4qf9liph5ry1kngam1y7zp8fzr9xv4wzzrma22kabldn")))) + "1mp6w2ikniw8w6d5wr0h20j0ijg8jw7s9dli5a8k9znpznvxpym4")))) (build-system cmake-build-system) (arguments '(#:tests? #f ; Tests are not ran with BUILD_SHARED_LIBS on. -- 2.28.0