From patchwork Sun Sep 19 18:46:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sarah Morgensen X-Patchwork-Id: 33206 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 787F627BBE3; Sun, 19 Sep 2021 19:47:51 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3C59627BBE1 for ; Sun, 19 Sep 2021 19:47:51 +0100 (BST) Received: from localhost ([::1]:60904 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mS1qw-0000fl-89 for patchwork@mira.cbaines.net; Sun, 19 Sep 2021 14:47:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mS1qB-0000Xl-AV for guix-patches@gnu.org; Sun, 19 Sep 2021 14:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56638) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mS1qA-0003Qz-HI for guix-patches@gnu.org; Sun, 19 Sep 2021 14:47:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mS1qA-0006PB-Av for guix-patches@gnu.org; Sun, 19 Sep 2021 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50664] [PATCH core-updates-frozen v2] gnu: curl: Respect #:tests?. Resent-From: Sarah Morgensen Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 19 Sep 2021 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50664 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50664@debbugs.gnu.org Cc: othacehe@gnu.org Received: via spool by 50664-submit@debbugs.gnu.org id=B50664.163207721724611 (code B ref 50664); Sun, 19 Sep 2021 18:47:02 +0000 Received: (at 50664) by debbugs.gnu.org; 19 Sep 2021 18:46:57 +0000 Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1q4-0006Os-QI for submit@debbugs.gnu.org; Sun, 19 Sep 2021 14:46:57 -0400 Received: from out2.migadu.com ([188.165.223.204]:25661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mS1q3-0006Oh-6Q for 50664@debbugs.gnu.org; Sun, 19 Sep 2021 14:46:56 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mgsn.dev; s=key1; t=1632077214; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/XNaXmMW70QGzvNgrd1TcE1P768IjpNgd4X2Ui9GJVs=; b=e9Ap/vYNWURo6DJNicJZTZedGwEXWKHPINqtYci1vfj4pS7Bq5H1OM2c1ZROl9ifqtxZ0p lRQVBSvzrHi1qGppuczFLgrqzhh7ZpBbAl4/8a8FlzcAfaV/J8jn05a3sZyPaTcV/hI255 nyvI0Qz7gVGEFYwIMQdhw2iw076s2ds= From: Sarah Morgensen Date: Sun, 19 Sep 2021 11:46:52 -0700 Message-Id: In-Reply-To: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> References: <8d416ea3a4f64a4a4df52084e5a9e5cce11c3c0b.1631944982.git.iskarian@mgsn.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: iskarian@mgsn.dev X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/curl.scm (curl)[arguments]<#:phases>{check}: Respect #:tests?. --- Changes from v1: * Do not provide a default value for tests?, since gnu-build-system provides one. -- Sarah gnu/packages/curl.scm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) base-commit: 8613652f3f80105f35db13d6d9308257bbff8474 diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 063a919700..4c90c7b301 100644 --- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -124,16 +124,16 @@ (rename-file (string-append out "/share/man/man3") (string-append doc "/share/man/man3")) #t))) - (replace - 'check - (lambda _ - (substitute* "tests/runtests.pl" - (("/bin/sh") (which "sh"))) + (replace 'check + (lambda* (#:key tests? #:allow-other-keys) + (substitute* "tests/runtests.pl" + (("/bin/sh") (which "sh"))) - ;; The top-level "make check" does "make -C tests quiet-test", which - ;; is too quiet. Use the "test" target instead, which is more - ;; verbose. - (invoke "make" "-C" "tests" "test")))))) + (when tests? + ;; The top-level "make check" does "make -C tests quiet-test", which + ;; is too quiet. Use the "test" target instead, which is more + ;; verbose. + (invoke "make" "-C" "tests" "test"))))))) (synopsis "Command line tool for transferring data with URL syntax") (description "curl is a command line tool for transferring data with URL syntax,