From patchwork Tue Sep 14 23:24:37 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thiago Jung Bauermann X-Patchwork-Id: 32845 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EDE4727BBE3; Wed, 15 Sep 2021 00:26:11 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 81F5B27BBE1 for ; Wed, 15 Sep 2021 00:26:11 +0100 (BST) Received: from localhost ([::1]:46098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQHoY-0000j1-Fj for patchwork@mira.cbaines.net; Tue, 14 Sep 2021 19:26:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQHoQ-0000it-Qt for guix-patches@gnu.org; Tue, 14 Sep 2021 19:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38846) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQHoQ-00073K-IZ for guix-patches@gnu.org; Tue, 14 Sep 2021 19:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mQHoQ-00063E-Bm for guix-patches@gnu.org; Tue, 14 Sep 2021 19:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50593] [PATCH core-updates-frozen] gnu: gtk+: Fix testsuite failure on non-x86_64 platforms Resent-From: Thiago Jung Bauermann Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 14 Sep 2021 23:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50593 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 50593@debbugs.gnu.org Cc: Thiago Jung Bauermann X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.163166190723178 (code B ref -1); Tue, 14 Sep 2021 23:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Sep 2021 23:25:07 +0000 Received: from localhost ([127.0.0.1]:50392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQHnW-00061m-Nt for submit@debbugs.gnu.org; Tue, 14 Sep 2021 19:25:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:49476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mQHnU-00061a-Se for submit@debbugs.gnu.org; Tue, 14 Sep 2021 19:25:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQHnT-0000ap-U7 for guix-patches@gnu.org; Tue, 14 Sep 2021 19:25:04 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:1596 helo=ext-mx-out002.mykolab.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQHnR-0006IA-Ah for guix-patches@gnu.org; Tue, 14 Sep 2021 19:25:02 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out002.mykolab.com (Postfix) with ESMTP id 7BFBFDD9 for ; Wed, 15 Sep 2021 01:24:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:subject:subject:from:from:received :received:received; s=dkim20160331; t=1631661895; x=1633476296; bh=0/Yo3qbnlpFI4Q4d+ldbZB4mGOHZ26+hgrY6X/1nGGE=; b=lXgdgKQiERL9 erjuhVaCmGoCG+KQr+6Nm78qFNi5/nCtU+bZYlzYrbA5kk38QE9ePdj9/z8KXRof phHcR+CVwc9xe+6No0Y62fkha/83h2X8P0NSo9K4C0b2B9NXqnTLyq0/dSsSyDpk 2Fif9GcugzmqJU2PWuYHtjcMFoiGQhDo0jZzWJSzKPQ0bagW1VHzYAu0wNEdyl01 C3fr3lRVGT24tqM0LjHWhfeMOk+RToJXfTRkxv28fjhCgmBgwgq18PjCtjTnciUh zdR5OUFhjno5t3hrMO2MvRJ9KR31RfAm/GvHd83DzA85ThJ54Wdi9JeC3Fl77zKb 7xCqAAuLeCDaj3Vz44QZoN2ZYIXlP/AAgfcnRFxi6j+74MpQCQ6N/edA16RWy4o0 FNNuRS3Kx9cRTKjrYIL9AAa30h3PCwu6no3iAMFrjcuwo3YvVkcN0gmu5dGe6b+C HL6Jk0fKrApU3Riaa0Tp7eMFLV3aYb6RbzObMTtyeJrukcNzP76wyhHnhNFfr3VG 3/oILzPpl3R5EqiDcPfMm/zy6XAIuEFo0EuIcP7oPTzIaPTvB2w2/JKcJ5SY9sE2 zO5Li3iTWaTazfR4j55VcjpxPoYhwiPcdiq0tolbABQzvbDFYf7p6laTB6vHOZGj bN4z7givb131z4hhp3CxRf0ZPU3M940= X-Virus-Scanned: amavisd-new at mykolab.com Received: from ext-mx-out002.mykolab.com ([127.0.0.1]) by localhost (ext-mx-out002.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8scdmK-cpvIM for ; Wed, 15 Sep 2021 01:24:55 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out002.mykolab.com (Postfix) with ESMTPS id EB46A655 for ; Wed, 15 Sep 2021 01:24:55 +0200 (CEST) Received: from ext-subm003.mykolab.com (unknown [10.9.6.3]) by int-mx003.mykolab.com (Postfix) with ESMTPS id B1952AD3; Wed, 15 Sep 2021 01:24:55 +0200 (CEST) Date: Tue, 14 Sep 2021 20:24:37 -0300 Message-Id: <20210914232437.53386-1-bauermann@kolabnow.com> MIME-Version: 1.0 Received-SPF: pass client-ip=95.128.36.41; envelope-from=bauermann@kolabnow.com; helo=ext-mx-out002.mykolab.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Thiago Jung Bauermann X-ACL-Warn: , Thiago Jung Bauermann via Guix-patches X-Patchwork-Original-From: Thiago Jung Bauermann via Guix-patches via From: Thiago Jung Bauermann X-getmail-retrieved-from-mailbox: Patches On non-x86_64 platforms, gtk+ is linked with a gdk-pixbuf version that doesn’t support SVG. This causes the ‘icontheme’ test to fail because it tries to fetch SVG icons in some of the tests. Therefore, we need to disable the test when SVG support isn’t available. * gnu/packages/gtk.scm (gtk+)[propagated-inputs]: Use the ‘target-x86-64?’ convenience function. [arguments]<#:phases>{disable-failing-tests}: Disable ‘icontheme’ test on non-x86_64 platforms. --- Hello, This patch doesn’t change the gtk+ output derivations on x86_64-linux, so it won’t cause any rebuilds there. And together with the one in issue 50521, it allows gtk+ to build on powerpc64le-linux. In fact, I can even build GTK+ apps such as Emacs and Transmission! Unfortunately, GNOME apps need SVG support because of the icon theme. And rust doesn’t build on powerpc64le-linux (mrustc errors out with “Unknown target name ''”). Thanks, Thiago gnu/packages/gtk.scm | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm index 24c24d56530f..876071235ef4 100644 --- a/gnu/packages/gtk.scm +++ b/gnu/packages/gtk.scm @@ -958,8 +958,7 @@ application suites.") ("freetype" ,freetype) ;; SVG support is optional and requires librsvg, which pulls in rust. ;; Rust is not supported well on every architecture yet. - ("gdk-pixbuf" ,(if (string-prefix? "x86_64" (or (%current-target-system) - (%current-system))) + ("gdk-pixbuf" ,(if (target-x86-64?) gdk-pixbuf+svg gdk-pixbuf)) ("glib" ,glib) @@ -1028,7 +1027,12 @@ application suites.") (("notify no-gtk-init object objects-finalize papersize rbtree") "no-gtk-init papersize rbtree") (("stylecontext templates textbuffer textiter treemodel treepath") - "stylecontext textbuffer textiter treemodel treepath")) + "stylecontext textbuffer textiter treemodel treepath") + ;; The ‘icontheme’ test needs SVG support. + ,@(if (not (target-x86-64?)) + '((("floating focus gestures grid gtkmenu icontheme keyhash listbox") + "floating focus gestures grid gtkmenu keyhash listbox")) + '())) (substitute* "testsuite/a11y/Makefile.in" (("accessibility-dump tree-performance text children derive") "tree-performance text children derive"))