From patchwork Sun Apr 21 20:09:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Amar M. Singh" X-Patchwork-Id: 13726 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 1F07E16ED5; Sun, 21 Apr 2019 22:02:57 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID, URIBL_BLOCKED,WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 6905E16D00 for ; Sun, 21 Apr 2019 22:02:55 +0100 (BST) Received: from localhost ([127.0.0.1]:57083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIJby-0007la-ND for patchwork@mira.cbaines.net; Sun, 21 Apr 2019 17:02:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIImq-0000W4-2T for guix-patches@gnu.org; Sun, 21 Apr 2019 16:10:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIImo-0000Fu-Qm for guix-patches@gnu.org; Sun, 21 Apr 2019 16:10:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35579) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIImo-0000FT-6b for guix-patches@gnu.org; Sun, 21 Apr 2019 16:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIImn-0005u8-Th for guix-patches@gnu.org; Sun, 21 Apr 2019 16:10:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#34364] bug#34595: [PATCH] gnu: Add emacs-shroud Resent-From: nly@disroot.org Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Apr 2019 20:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34364 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 34364@debbugs.gnu.org Received: via spool by 34364-submit@debbugs.gnu.org id=B34364.155587735922615 (code B ref 34364); Sun, 21 Apr 2019 20:10:01 +0000 Received: (at 34364) by debbugs.gnu.org; 21 Apr 2019 20:09:19 +0000 Received: from localhost ([127.0.0.1]:49122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIIm6-0005sg-Kx for submit@debbugs.gnu.org; Sun, 21 Apr 2019 16:09:19 -0400 Received: from knopi.disroot.org ([178.21.23.139]:60712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIIm3-0005sR-KA for 34364@debbugs.gnu.org; Sun, 21 Apr 2019 16:09:17 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 640B52F73B for <34364@debbugs.gnu.org>; Sun, 21 Apr 2019 22:09:14 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Sy0v-fjnDlAC for <34364@debbugs.gnu.org>; Sun, 21 Apr 2019 22:09:12 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1555877352; bh=4tVC1T9WECcZMfGThxv3Gn1CmCnXSUnBKRjcImUI5Ik=; h=Date:From:Subject:To:In-Reply-To:References; b=TDBOLm+PyxCJ/MYO+5lnrFQ5xNB6E9xxjCWbq1giRebQ9Iq+s0kAe9dsFo7AUv5X8 UpSGtv3QDpimZbTsvWVh51RllaYLNDUdziy6U7JMrGIblKFhsczvKB39DsgZxSh7IG KZ6jGqWYsOPT2iRgWE87+MTIo3+uaR5k/59Nyz8FiKtCiL2TLLYwgGQ8zk2SRjlrF8 x1YXevIfRFRzEYCKPMz2WcRBd6GxrYlzonVG3ELxTERRRgk9535A+LeLkGMxsU+jLY LpHwD66LZvWj8Qy3kQHAl8PLuPobRHp8xEUHbOjN6MbHjhqMqG5sCtAiZcSsqY3h92 8xtqc/iq7rq+Q== Date: Sun, 21 Apr 2019 20:09:12 +0000 From: nly@disroot.org Message-ID: In-Reply-To: <874l8y5ehq.fsf@elephly.net> References: <874l8y5ehq.fsf@elephly.net> <87o976p4z3.fsf@disroot.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-Mailman-Approved-At: Sun, 21 Apr 2019 17:02:49 -0400 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches February 21, 2019 3:07 AM, "Ricardo Wurmus" wrote: > Hi, > >> Shroud is a password manager written in Guile which uses GnuPG in the >> backend. This package is an Emacs interface to Shroud using the Buffers >> User Interface library. > > You have previously already submitted a variant of this: > > https://issues.guix.info/issue/34364 > > Please don’t open more tickets for this but instead send updates to the > same ticket. I’m closing this issue, because what you attached is not a > git formatted patch. Thanks for closing the other issue, i was oblivious of debbugs until today. > >> +(define-public nly/emacs-shroud > > We don’t use personal prefixes like “nly/” in Guix. > >> + (package >> + (name "emacs-shroud") >> + (version "ad5de6d") > > A version string must be monotonically increasing over time. Commit > hashes don’t do that, so we use (git-version last-release revision > commit) instead. > > We prefer releases over arbitrary commits. Since you are the developer, > could you please tell us what the difference is between this version and > the previous release? Could you make a new release instead? > Thanks, got it. Now looks like (git-version "v1" "1" commit) >> + (build-system emacs-build-system) >> + (propagated-inputs >> + `(("emacs-f" ,emacs-f) >> + ("emacs-s" ,emacs-s) >> + ("emacs-bui" ,emacs-bui) >> + ("shroud" ,shroud))) >> + (home-page "http://nly.info.tm:9001/emacs/shroud.el") >> + (synopsis "Shroud (gpg) support for Emacs") > > Why “(gpg)”? It’s probably better to say “Shroud password manager > interface for Emacs”. New synopsis: Emacs interface for Shroud password manager > >> + (description >> + "This package provides functions for working with shroud password >> manager.") > > I’d not say “functions”. How about > > This package provides an Emacs minor mode for working with the Shroud > password manager. This package doesn't include any minor-mode so I assume it would become misleading. > > Could you please send an updated patch? > > -- > Ricardo I hope web mail doesn't html-ize the patch. This is great, It feels awesome to get in a personal package I've been using for months. Thanks, Amar From 0309576d26ce92ec2324c0505599da95408b1235 Mon Sep 17 00:00:00 2001 From: Amar Singh Date: Mon, 22 Apr 2019 01:28:32 +0530 Subject: [PATCH] gnu: Add emacs-shroud. * gnu/packages/emacs-xyz.scm (emacs-shroud): New variable. --- gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 54663496fe..d7c1245f43 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -15306,3 +15306,35 @@ numbers within that region will be incremented/decremented (unlike in Vim). It is a fork of https://github.com/cofi/evil-numbers, which is unmaintained.") (license license:gpl3+)))) + +(define-public emacs-shroud + (let + ((commit "dc68f5538692bf07376cd5395b87102025549f32")) + (package + (name "emacs-shroud") + (version + (git-version "v1" "1" commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/o-nly/emacs-shroud") + (commit commit))) + (file-name + (git-file-name name version)) + (sha256 + (base32 + "17a3z5p252nbj3y7rwbvx1jk2bizzdcina6vw8blnks4dvv30k87")))) + (build-system emacs-build-system) + (inputs + `(("emacs-f" ,emacs-f) + ("emacs-bui" ,emacs-bui) + ("shroud" ,shroud))) + (home-page "http://git.nly.info.tm:9001/shroud.git") + (synopsis "Emacs interface for Shroud password manager") + (description + "This package provides functions for working with shroud +password manager using Elisp, a reader for Shroud DB, and an Buffers +User Interface for using shroud password database.") + (license license:gpl3+))))