From patchwork Thu Jul 8 17:43:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: M X-Patchwork-Id: 31238 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 437C727BC81; Thu, 8 Jul 2021 19:48:48 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,SPF_HELO_PASS,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 677FA27BC78 for ; Thu, 8 Jul 2021 19:48:47 +0100 (BST) Received: from localhost ([::1]:56378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Z4o-0000TF-Ex for patchwork@mira.cbaines.net; Thu, 08 Jul 2021 14:48:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YVG-0005Ve-ND for guix-patches@gnu.org; Thu, 08 Jul 2021 14:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45888) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1YVG-0003F1-Dt for guix-patches@gnu.org; Thu, 08 Jul 2021 14:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m1YVG-0002z1-3L; Thu, 08 Jul 2021 14:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49468] [PATCH] Respect --without-tests in some dependencies of Mirage Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: 0x2d@disroot.org, guix-patches@gnu.org Resent-Date: Thu, 08 Jul 2021 18:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49468 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49468@debbugs.gnu.org Cc: slg <0x2d@disroot.org> X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: slg <0x2d@disroot.org> Received: via spool by submit@debbugs.gnu.org id=B.162576790411441 (code B ref -1); Thu, 08 Jul 2021 18:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jul 2021 18:11:44 +0000 Received: from localhost ([127.0.0.1]:57434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1YUk-0002yF-6J for submit@debbugs.gnu.org; Thu, 08 Jul 2021 14:11:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:39262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m1YUa-0002xz-MF for submit@debbugs.gnu.org; Thu, 08 Jul 2021 14:11:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34900) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1YUa-0004U1-4n for guix-patches@gnu.org; Thu, 08 Jul 2021 14:11:20 -0400 Received: from michel.telenet-ops.be ([2a02:1800:110:4::f00:18]:32982) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m1YUW-0002pF-OL for guix-patches@gnu.org; Thu, 08 Jul 2021 14:11:19 -0400 Received: from [172.20.10.4] ([188.189.203.76]) by michel.telenet-ops.be with bizsmtp id SiBB2500D1fQufw06iBCBw; Thu, 08 Jul 2021 20:11:12 +0200 Message-ID: <6e356b2d5d24c15876e3ad6cc853ce18386cdd5a.camel@telenet.be> From: Maxime Devos Date: Thu, 08 Jul 2021 19:43:10 +0200 MIME-Version: 1.0 User-Agent: Evolution 3.34.2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1625767873; bh=DnvpjGyb8kfi+s+WKdxfn/EBaeXXlTEDXbLXbgS/WUY=; h=Subject:From:To:Date; b=NzfPQD0GigNA4RoZFA/8erA7/n9MHGcj7K66rfKQTEV294dHob86gWwUqeJmMcEsk VLFaZlJVPD4/jFFJMv7gwe9dL8rZJZaVa6NfalRXaWs/vQUYZ3pSKE1CNwnmwFsFQs 4N/z9jtd9fZhwh3zvxivJ07cjnRGq4kPFV/e8+VGQ4+fGMlblNwd/GU9F/qZB7K8BM 5yDj40vePUpJf+mLUQdQO6YOGxhrB+EC8mokHLsB0CMJkDojlYhcEbK1085UY9FZlh ePR9R+Qxy2frFVVTp7r0iNKwjNOWmYYf+vX50cWKMw+tEV3Pg27TmYQy5vC7UZgK8x mI9zn0L4Bxcow== Received-SPF: pass client-ip=2a02:1800:110:4::f00:18; envelope-from=maximedevos@telenet.be; helo=michel.telenet-ops.be X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches X-Debbugs-CC: slg <0x2d@disroot.org> Hi guix, In the context of , I'm making some dependencies of mirage respect --without-tests. The modified packages build successfully with and without --without-tests. The number of rebuilds is minimal: $ ./pre-inst-env guix refresh -l libolm python-h2 python-h11 python-hpack python-hyperframe python-watchgod python-pymediainfo Building the following 5 packages would ensure 12 dependent packages are rebuilt: nheko@0.7.2 python-hypercorn@0.10.2 orange@3.28.0 python-sanic@20.12.2 rapid-photo-downloader@0.9.18 Greetings, Maxime From 1c3c16618b3d4cefccc368717c741841c64730bc Mon Sep 17 00:00:00 2001 From: Maxime Devos Date: Thu, 8 Jul 2021 18:38:25 +0200 Subject: [PATCH 7/7] gnu: libolm: Respect "--without-tests". * gnu/packages/libolm.scm (libolm)[arguments]<#:phases>{check}: Respect #:tests?. --- gnu/packages/crypto.scm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/crypto.scm b/gnu/packages/crypto.scm index 99455dc632..bd2c462b96 100644 --- a/gnu/packages/crypto.scm +++ b/gnu/packages/crypto.scm @@ -20,6 +20,7 @@ ;;; Copyright © 2020 Hendur Saga ;;; Copyright © 2020 pukkamustard ;;; Copyright © 2021 Ellis Kenyő +;;; Copyright © 2021 Maxime Devos ;;; ;;; This file is part of GNU Guix. ;;; @@ -1314,9 +1315,10 @@ Trusted comments are signed, thus verified, before being displayed.") `(#:phases (modify-phases %standard-phases (replace 'check - (lambda _ - (with-directory-excursion "tests" - (invoke "ctest" "."))))))) + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (with-directory-excursion "tests" + (invoke "ctest" ".")))))))) (synopsis "Implementation of the olm and megolm cryptographic ratchets") (description "The libolm library implements the Double Ratchet cryptographic ratchet. It is written in C and C++11, and exposed as a C -- 2.32.0