From patchwork Sat Jul 3 20:15:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Brice Waegeneire X-Patchwork-Id: 31101 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id A4F8227BC81; Sat, 3 Jul 2021 21:17:33 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 6762E27BC78 for ; Sat, 3 Jul 2021 21:17:33 +0100 (BST) Received: from localhost ([::1]:39680 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzm4y-0003d5-GK for patchwork@mira.cbaines.net; Sat, 03 Jul 2021 16:17:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzm4U-0003F3-PV for guix-patches@gnu.org; Sat, 03 Jul 2021 16:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56608) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzm4U-0004FC-Hz for guix-patches@gnu.org; Sat, 03 Jul 2021 16:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzm4U-0003H5-6n for guix-patches@gnu.org; Sat, 03 Jul 2021 16:17:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49362] [PATCH v3] gnu: icecat: Add WebAuthn support. Resent-From: Brice Waegeneire Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Jul 2021 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 49362 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 49362@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.162534336312513 (code B ref -1); Sat, 03 Jul 2021 20:17:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Jul 2021 20:16:03 +0000 Received: from localhost ([127.0.0.1]:39921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzm3X-0003Ff-0m for submit@debbugs.gnu.org; Sat, 03 Jul 2021 16:16:03 -0400 Received: from lists.gnu.org ([209.51.188.17]:54534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzm3U-0003F8-Ro for submit@debbugs.gnu.org; Sat, 03 Jul 2021 16:16:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49174) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzm3U-0002z5-LE for guix-patches@gnu.org; Sat, 03 Jul 2021 16:16:00 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43413) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzm3S-0003O9-Ak for guix-patches@gnu.org; Sat, 03 Jul 2021 16:16:00 -0400 Received: (Authenticated sender: brice@waegenei.re) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 30ECE20003 for ; Sat, 3 Jul 2021 20:15:54 +0000 (UTC) From: Brice Waegeneire Date: Sat, 3 Jul 2021 22:15:52 +0200 Message-Id: <20210703201552.28769-1-brice@waegenei.re> X-Mailer: git-send-email 2.31.1 In-Reply-To: <87tulbgvs1.fsf@netris.org> References: <87tulbgvs1.fsf@netris.org> MIME-Version: 1.0 Received-SPF: pass client-ip=217.70.183.200; envelope-from=brice@waegenei.re; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/gnuzilla.scm (icecat)[inputs]: Add eudev. [phases]: Add eudev to the wrapper. --- gnu/packages/gnuzilla.scm | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) I remember having testing one version of this patch successfully, in retrospect it probably wasn't the one sent. I have tested this version specificly with success in regards to WebAuth, trough the Yubico test website. diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 6ec920141a..d118ae48e4 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -15,6 +15,7 @@ ;;; Copyright © 2019, 2020 Adrian Malacoda ;;; Copyright © 2020 Jonathan Brielmaier ;;; Copyright © 2020 Marius Bakke +;;; Copyright © 2021 Brice Waegeneire ;;; ;;; This file is part of GNU Guix. ;;; @@ -910,6 +911,7 @@ from forcing GEXP-PROMISE." ;; UNBUNDLE-ME! ("nss" ,nss) ("shared-mime-info" ,shared-mime-info) ;; UNBUNDLE-ME! ("sqlite" ,sqlite) + ("eudev" ,eudev) ("unzip" ,unzip) ("zip" ,zip) ;; UNBUNDLE-ME! ("zlib" ,zlib) @@ -1271,24 +1273,21 @@ from forcing GEXP-PROMISE." (lib (string-append out "/lib")) (gtk (assoc-ref inputs "gtk+")) (gtk-share (string-append gtk "/share")) - (mesa (assoc-ref inputs "mesa")) - (mesa-lib (string-append mesa "/lib")) - (pulseaudio (assoc-ref inputs "pulseaudio")) - (pulseaudio-lib (string-append pulseaudio "/lib")) - (libxscrnsaver (assoc-ref inputs "libxscrnsaver")) - (libxscrnsaver-lib (string-append libxscrnsaver "/lib")) - (mit-krb5 (assoc-ref inputs "mit-krb5")) - (mit-krb5-lib (string-append mit-krb5 "/lib"))) + (ld-libs (map (lambda (lib) + (string-append (assoc-ref inputs lib) + "/lib")) + '("libxscrnsaver" + "mesa" + "mit-krb5" + "eudev" + "pulseaudio")))) (wrap-program (car (find-files lib "^icecat$")) `("XDG_DATA_DIRS" prefix (,gtk-share)) ;; The following line is commented out because the icecat ;; package on guix has been observed to be unstable when ;; using wayland, and the bundled extensions stop working. ;; `("MOZ_ENABLE_WAYLAND" = ("1")) - `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib - ,mesa-lib - ,libxscrnsaver-lib - ,mit-krb5-lib))) + `("LD_LIBRARY_PATH" prefix ,ld-libs)) #t)))))) (home-page "https://www.gnu.org/software/gnuzilla/") (synopsis "Entirely free browser derived from Mozilla Firefox")