From patchwork Sat Jul 3 17:01:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luis Felipe X-Patchwork-Id: 31099 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3F09027BC81; Sat, 3 Jul 2021 19:47:53 +0100 (BST) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id D966F27BC78 for ; Sat, 3 Jul 2021 19:47:51 +0100 (BST) Received: from localhost ([::1]:56252 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lzkg9-0007DL-Gj for patchwork@mira.cbaines.net; Sat, 03 Jul 2021 14:47:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lzkdV-0007Cq-CG for guix-patches@gnu.org; Sat, 03 Jul 2021 14:45:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56547) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lzkdU-0004RY-3L for guix-patches@gnu.org; Sat, 03 Jul 2021 14:45:05 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lzkdT-00012i-B8 for guix-patches@gnu.org; Sat, 03 Jul 2021 14:45:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49310] website: Redesign video pages Resent-From: Luis Felipe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 03 Jul 2021 18:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49310 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: "pelzflorian (Florian Pelz)" Cc: 49310@debbugs.gnu.org Received: via spool by 49310-submit@debbugs.gnu.org id=B49310.16253378773956 (code B ref 49310); Sat, 03 Jul 2021 18:45:02 +0000 Received: (at 49310) by debbugs.gnu.org; 3 Jul 2021 18:44:37 +0000 Received: from localhost ([127.0.0.1]:39861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzkd2-00011k-Qy for submit@debbugs.gnu.org; Sat, 03 Jul 2021 14:44:37 -0400 Received: from mail-40130.protonmail.ch ([185.70.40.130]:11105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lzj1S-0006h4-Lt for 49310@debbugs.gnu.org; Sat, 03 Jul 2021 13:01:44 -0400 Date: Sat, 03 Jul 2021 17:01:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1625331691; bh=xMLvcGEGBVPUsi+qQSUfSxChIJpjLQtxfY3jCLQTsYY=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=Vp/s02kPUA2Brqw/WfoCJcLSgtv0pBOX0rFrtkUShBocsdeOweBtcaLvuAMcnleW0 Kf6vtSHIfdSzJ8LMdZC4WpigRYDRYs4jBA6lV3PP+nHB394xqUv2fRKz6wrgpPlDLl MMY6WzLQv1LyaAL0UExW6gDcEeERktLBlDX5a/34= Message-ID: In-Reply-To: <20210703100859.awos36q63ysew5it@pelzflorian.localdomain> References: <20210703100859.awos36q63ysew5it@pelzflorian.localdomain> MIME-Version: 1.0 X-Mailman-Approved-At: Sat, 03 Jul 2021 14:44:34 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: Luis Felipe X-ACL-Warn: , Luis Felipe via Guix-patches X-Patchwork-Original-From: Luis Felipe via Guix-patches via From: Luis Felipe X-getmail-retrieved-from-mailbox: Patches Hi Florian, On Saturday, July 3rd, 2021 at 10:08 AM, pelzflorian (Florian Pelz) wrote: > Thank you! Much nicer than before, both in looks and code-wise and > > also documentation-wise. This was much effort. Phew, glad to hear that! > Shall I push your commit and afterwards redirect the old video URLs in > > maintenance.git? Maybe better to redirect to /en/videos/? > I don’t know the plan for further videos and if forcing reverse > > chronological order will be useful someday. Well, yeah, I'm not sure whether it will be useful either. I think the idea is to add a selection of videos from the community, as proposed by Julien in https://issues.guix.gnu.org/43871. So the list could grow enough to justify a reverse chronological order, like in the blog. > > New miniature and poster images for videos: > > > > - website/static/media/videos/2018/seagl-everyday-use-of-guix.mini.webp > > - website/static/media/videos/2018/seagl-everyday-use-of-guix.webp > > > > […] > > Yes, switching from .png to .webp seems appropriate, even if it is > > unsupported on old still-supported macOS versions or ReactOS or such > > things, because they cannot playback the .webm videos anyway, I think. I'd say let's use webp and webm, and if we get complaints, we see how to solve any issues (at least for images; with videos is harder because of storage resources). > > diff --git a/website/apps/media/builder.scm b/website/apps/media/builder.scm > > “#:use-module (srfi srfi-1)“ can be removed. Removed in the new patch attached. > > Modified files: > > > > - website/apps/media/data.scm (videos): New list of videos plus > > > > playlists. > > > > (playlist): Remove in favor of the new videos list. > > s/(playlist)/(playlists)/ Corrected in the new patch. Thanks for the review, Florian. From 924d7950a045d623720202d58cd5482db2b48030 Mon Sep 17 00:00:00 2001 From: Luis Felipe Date: Tue, 22 Jun 2021 18:56:28 -0500 Subject: [PATCH] website: Redesign video pages. This change introduces a multipage catalog of videos and playlists, similar to blog posts and packages pages. Modified files: * website/README (Adding videos): New section. * website/apps/base/builder.scm (home-builder): Pass 4 videos and/or playlists to the home page template. * website/apps/base/templates/home.scm (home-t): Display videos and playlists in the Instructional videos section. Move the ALL PACKAGES button below the screenshots. * website/apps/media/builder.scm (videos-builder): Use the new list of videos. Put videos in new paths (/LANG/videos/YYYY/video-slug/). (video-list-builder): Build the pages of the catalog of videos and playlists. * website/apps/media/data.scm (videos): New list of videos plus playlists. (playlists): Remove in favor of the new videos list. * website/apps/media/templates/components.scm: (playlist-preview, video-track): New components. (video-preview): Redesign video presentation. Add new keyword parameter, "playing?", to indicate whether the video is the currently playing video in a playlist. (video->shtml, video-content): Removed. Not necessary in the new design. * website/apps/media/templates/video.scm (video-t): Redesign it. * website/apps/media/templates/video-list.scm (video-list-t): Likewise. * website/apps/media/types.scm (): New record type. (