From patchwork Tue Jun 8 18:38:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carl Dong X-Patchwork-Id: 30035 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id E449127BC78; Tue, 8 Jun 2021 19:43:35 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 89AC827BC81 for ; Tue, 8 Jun 2021 19:43:34 +0100 (BST) Received: from localhost ([::1]:48026 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqghJ-0002ct-IL for patchwork@mira.cbaines.net; Tue, 08 Jun 2021 14:43:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqgdw-0000Th-Ma for guix-patches@gnu.org; Tue, 08 Jun 2021 14:40:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48243) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqgdu-0005vH-4A for guix-patches@gnu.org; Tue, 08 Jun 2021 14:40:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqgdt-000354-PH for guix-patches@gnu.org; Tue, 08 Jun 2021 14:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48850] [PATCH v3] gnu: coreutils: Disable inotify-dir-recreate test Resent-From: Carl Dong Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Jun 2021 18:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48850 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ludo@gnu.org Cc: 48850@debbugs.gnu.org, Carl Dong Received: via spool by 48850-submit@debbugs.gnu.org id=B48850.162317755711783 (code B ref 48850); Tue, 08 Jun 2021 18:40:01 +0000 Received: (at 48850) by debbugs.gnu.org; 8 Jun 2021 18:39:17 +0000 Received: from localhost ([127.0.0.1]:59789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqgdA-00033y-Pj for submit@debbugs.gnu.org; Tue, 08 Jun 2021 14:39:17 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqgd7-00033f-Rb for 48850@debbugs.gnu.org; Tue, 08 Jun 2021 14:39:16 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0C4141C27; Tue, 8 Jun 2021 14:39:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 08 Jun 2021 14:39:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=carldong.me; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=AEZAprltHB3hb kv/SscqMAGe6Eo+JvG4I09/dpITcrg=; b=oAjSraKvM2LtuAL5DJ5gQo0WGigbq MBwts+JqkzB3SRbQps8xuQXwGnf3nvJSBQGo3g3aQDqmsxDBWIGRjoTa6sFdz4TJ 25MMgnzfoCMAtUEmoFbMAoJ1vyRmshAt7e9P9qo4IhJ78vJm0xU0Al5xOLE1dSlg jeeGId9x+bwPRWnid4s0lj89rhhX2eCCou9MFU+0AU9Mb8N+A6lcTwirgMla/eMl YigS2TTpKrb3nTlqzYFZfX91pLEZSL+T1yqjMB4TcdkA5TmHk22y2GbRxFzN033K HRWUIduI93WAdB7v1uvEhEJShxyDEFt2MYrfL3X52bC7eGov/r4va5Bqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=AEZAprltHB3hbkv/SscqMAGe6Eo+JvG4I09/dpITcrg=; b=c5t5dLuF sQgvOr2nZrqjuwedCGIu+w1CgqKxvcoHzHq6GJPPP0DE2iV6LWnawtmIWrAtbc1n SNYK2VkJo95bchq2BTyq6kDz8/y5t6XuTTShkATVnOxbd5zRxrUJt+yGd2zsV3q2 vvjW+QsT2ZZ+3LhMw5uzGsGkQVvY5c9+N7HamqFOIxI6j5vs9895/QxemuO6COdS V9Hzcw0BoTY6acLvapHlFU8Kx8qaf8CdKbmvbsnoBQhf7O0KPMrToWrC2/khYbDf usBGtQ3oJVHMc65XZSuM9CUCKSq9UYDkURxq5IrIbIyLr1gLmw7TfEj0MLG2Y2C6 HqcNDZYswWW4lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedtledgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpeevrghrlhcuffhonhhguceotghonhhtrggtthestggrrhhl ughonhhgrdhmvgeqnecuggftrfgrthhtvghrnhepuefftefhteevgffflefffeevffefgf dvgefffffhvdetfeekudffgfeuvdejtdejnecuffhomhgrihhnpehgnhhurdhorhhgnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheptghonhhtrg gtthestggrrhhlughonhhgrdhmvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Jun 2021 14:39:07 -0400 (EDT) From: Carl Dong Date: Tue, 8 Jun 2021 14:38:15 -0400 Message-Id: <20210608183814.3099881-1-contact@carldong.me> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210607215058.3989424-1-contact@carldong.me> References: <20210607215058.3989424-1-contact@carldong.me> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Fixed my quoting thanks to mbakke :-) --- This test fails on filesystems where tail detects that it cannot use inotify safely. See https://issues.guix.gnu.org/47935 for more details. * gnu/packages/base.scm (coreutils)[phases]: Disable inotify-dir-recreate tests, quote Hurd substitute* call to reduce rebuilds. --- gnu/packages/base.scm | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm index d30299a7b6..edc4c4a427 100644 --- a/gnu/packages/base.scm +++ b/gnu/packages/base.scm @@ -378,13 +378,17 @@ used to apply commands with arbitrarily long arguments.") (("/bin/sh") (which "sh"))) (substitute* (find-files "tests" "\\.sh$") (("#!/bin/sh") (string-append "#!" (which "sh")))))) - ,@(if (hurd-target?) - `((add-after 'unpack 'remove-tests - (lambda _ - (substitute* "Makefile.in" + (add-after 'unpack 'remove-tests + (lambda _ + ,@(if (hurd-target?) + '((substitute* "Makefile.in" ;; this test hangs - (("^ *tests/misc/timeout-group.sh.*") ""))))) - '())))) + (("^ *tests/misc/timeout-group.sh.*") ""))) + '()) + (substitute* "Makefile.in" + ;; fails on filesystems where inotify cannot be used, + ;; more info in #47935 + (("^ *tests/tail-2/inotify-dir-recreate.sh.*") ""))))))) (synopsis "Core GNU utilities (file, text, shell)") (description "GNU Coreutils package includes all of the basic command-line tools that