From patchwork Thu May 6 17:27:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 29152 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 88D8727BC82; Thu, 6 May 2021 18:28:25 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1B5CA27BC81 for ; Thu, 6 May 2021 18:28:25 +0100 (BST) Received: from localhost ([::1]:57890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lehnU-0000fP-BI for patchwork@mira.cbaines.net; Thu, 06 May 2021 13:28:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37158) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lehn8-0000ac-B2 for guix-patches@gnu.org; Thu, 06 May 2021 13:28:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lehn8-0000uw-29 for guix-patches@gnu.org; Thu, 06 May 2021 13:28:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lehn7-0005kl-Ub for guix-patches@gnu.org; Thu, 06 May 2021 13:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48262] [PATCH version-1.3.0 1/3] gnu: spice-vdagent: Update to 0.21.0 and enable GTK+ support. References: <20210506172355.11694-1-maxim.cournoyer@gmail.com> In-Reply-To: <20210506172355.11694-1-maxim.cournoyer@gmail.com> Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 17:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48262 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48262@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 48262-submit@debbugs.gnu.org id=B48262.162032207222102 (code B ref 48262); Thu, 06 May 2021 17:28:01 +0000 Received: (at 48262) by debbugs.gnu.org; 6 May 2021 17:27:52 +0000 Received: from localhost ([127.0.0.1]:38716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehmx-0005kQ-W8 for submit@debbugs.gnu.org; Thu, 06 May 2021 13:27:52 -0400 Received: from mail-qv1-f48.google.com ([209.85.219.48]:33787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehmv-0005kK-KK for 48262@debbugs.gnu.org; Thu, 06 May 2021 13:27:50 -0400 Received: by mail-qv1-f48.google.com with SMTP id i8so3493509qvv.0 for <48262@debbugs.gnu.org>; Thu, 06 May 2021 10:27:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y8W703RQ69m5JkhSV13OJDVMnz0Eix8rwZJvSmdy3rQ=; b=FUeKm0UbCSDH0Cf3n5T81UaXfNlTIW885l6FOa9RDef+arqLTZh+Xz0MtZCNoF6iIK QX9hgPoo9+nvGpabKeRBV3Py3KqBJ+bov9Nvu7P05FTjTkUJtvzjDaXDn3aU/TuvB5Pu mHN2/dKkHkafzIzZ37vvi8nn5d+YdVDPOs5hp6kCs0Ik6U/1ho6KSjCHwnj+j+YDDRVj M4Q+njXTU0jYwpxMF8bFK+pt9aI5J9MtlpaJb7GczBd0q/hV3dv3rAquPE1ZotSMaWU8 1W5tntZKLBAKu8sbvRrlaFivhu/ttnnyeohO0l7SaH5Eu66tMaMzMlMCfjVY3/eRy0t/ uWOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y8W703RQ69m5JkhSV13OJDVMnz0Eix8rwZJvSmdy3rQ=; b=cq/NlzbvLI0WzIMh7si5YZR8tG9NgX66OV2jZOjfWCzVI9kWyIGhAxl1FGI7EuylI1 +eDix+HcoH4ZHbXlxRkNzMHwKI588YfoLP1b3TGXL6jANWiXEcFYBQWMy0iy5k/MqAQc fi9LAC7slTFK8Ui4aBkgucInKmbVGqwTUhhz3vv31vE4KUrxmdT4Wqj2ibmSxnPT6Opk KGMoMgwDx2jscmgcn2+6agA+OHEpg++quUFopd9bCG4Zn+uK4zKEdkIHA6qWhpNncYWC 1UKxgPof64QTibaLx6MbJ5fjwxqEsOMR4DlJ3jNEbV5I5/GnVUdaCTDJ7vTMPFCNy6t6 5orw== X-Gm-Message-State: AOAM532kkKbcCIFe8X8+6ckc6rFJRocs614d7Cc5Its8ZEdx7mb3kSkB NfltnHxd/HHbed07i00NN3+6wsN/fSA5Dg== X-Google-Smtp-Source: ABdhPJyXsDU1qwHwNewFrY/EsbdqLzxZ2mnB/6fshqVsQCzmCa1HbNnc2FIxtImHKvdbjIse3S1xzw== X-Received: by 2002:a05:6214:a0b:: with SMTP id dw11mr5822607qvb.51.1620322063979; Thu, 06 May 2021 10:27:43 -0700 (PDT) Received: from localhost.localdomain (dsl-10-131-245.b2b2c.ca. [72.10.131.245]) by smtp.gmail.com with ESMTPSA id y13sm2495704qkj.84.2021.05.06.10.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 10:27:43 -0700 (PDT) From: Maxim Cournoyer Date: Thu, 6 May 2021 13:27:30 -0400 Message-Id: <20210506172732.12294-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/spice.scm (spice-vdagent): Update to 0.21.0. Remove trailing #t. [make-flags]: New argument. [phases]{fix-test-termination}: New phase. [inputs]: Add gtk+. [native-inputs]{procps}: New input. --- gnu/packages/spice.scm | 26 +++++++++++++++++++------- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/gnu/packages/spice.scm b/gnu/packages/spice.scm index 92aeef7f79..0e47609b9e 100644 --- a/gnu/packages/spice.scm +++ b/gnu/packages/spice.scm @@ -261,7 +261,7 @@ Internet and from a wide variety of machine architectures.") (define-public spice-vdagent (package (name "spice-vdagent") - (version "0.20.0") + (version "0.21.0") (source (origin (method url-fetch) (uri (string-append @@ -269,11 +269,14 @@ Internet and from a wide variety of machine architectures.") "spice-vdagent-" version ".tar.bz2")) (sha256 (base32 - "0n9k2kna2gd1zi6jv45zsp2jlv439nz5l5jjijirxqaycwi74srf")))) + "0n8jlc1pv6mkry161y656b1nk9hhhminjq6nymzmmyjl7k95ymzx")))) (build-system gnu-build-system) (arguments `(#:configure-flags '("--localstatedir=/var") + ;; The test-session-info test fails for unknown reasons (see: + ;; https://gitlab.freedesktop.org/spice/linux/vd_agent/-/issues/24). + #:make-flags '("XFAIL_TESTS=tests/test-session-info") #:phases (modify-phases %standard-phases (add-after 'unpack 'patch-makefile.in @@ -281,19 +284,27 @@ Internet and from a wide variety of machine architectures.") (substitute* "Makefile.in" (((string-append "\\$\\(mkdir_p\\) \\$\\(DESTDIR\\)" "\\$\\(localstatedir\\)/run/spice-vdagentd")) - "-$(mkdir_p) $(DESTDIR)$(localstatedir)/run/spice-vdagentd")) - #t)) + "-$(mkdir_p) $(DESTDIR)$(localstatedir)/run/spice-vdagentd")))) (add-after 'unpack 'patch-spice-vdagent.desktop (lambda* (#:key outputs #:allow-other-keys) (substitute* "data/spice-vdagent.desktop" (("Exec=/usr/bin/spice-vdagent") (string-append "Exec=" (assoc-ref outputs "out") - "/bin/spice-vdagent"))) - #t))))) + "/bin/spice-vdagent"))))) + (add-after 'unpack 'fix-test-termination + (lambda _ + ;; The termination tests depend on finding the socket file name + ;; in the spice-vdagent command line it launched, but by default + ;; ps truncates its output, which causes the test to fail (see: + ;; https://gitlab.freedesktop.org/spice/linux/vd_agent/-/merge_requests/36). + (substitute* "tests/test-termination.c" + (("ps -ef") + "ps -efww"))))))) (inputs `(("alsa-lib" ,alsa-lib) ("dbus" ,dbus) ("glib" ,glib) + ("gtk+" ,gtk+) ("libdrm" ,libdrm) ("libpciaccess" ,libpciaccess) ("libx11" ,libx11) @@ -303,7 +314,8 @@ Internet and from a wide variety of machine architectures.") ("libxrandr" ,libxrandr) ("spice-protocol" ,spice-protocol))) (native-inputs - `(("pkg-config" ,pkg-config))) + `(("pkg-config" ,pkg-config) + ("procps" ,procps))) ;tests use 'ps' (synopsis "Spice agent for Linux") (description "Spice-vdagent enables sharing the clipboard and guest display resolution scaling on graphical console window resize.") From patchwork Thu May 6 17:27:31 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 29153 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CEE1427BC82; Thu, 6 May 2021 18:29:16 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3E8D727BC86 for ; Thu, 6 May 2021 18:29:15 +0100 (BST) Received: from localhost ([::1]:59488 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lehoI-0001Kf-FW for patchwork@mira.cbaines.net; Thu, 06 May 2021 13:29:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leho6-0001KR-VI for guix-patches@gnu.org; Thu, 06 May 2021 13:29:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55414) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leho6-0001YS-HN for guix-patches@gnu.org; Thu, 06 May 2021 13:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leho6-0005lg-Ed for guix-patches@gnu.org; Thu, 06 May 2021 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48262] [PATCH version-1.3.0 2/3] services: spice-vdagent: Clear the socket file prior to starting. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48262 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48262@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 48262-submit@debbugs.gnu.org id=B48262.162032208222140 (code B ref 48262); Thu, 06 May 2021 17:29:02 +0000 Received: (at 48262) by debbugs.gnu.org; 6 May 2021 17:28:02 +0000 Received: from localhost ([127.0.0.1]:38720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehn8-0005kv-B8 for submit@debbugs.gnu.org; Thu, 06 May 2021 13:28:02 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:37587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehn6-0005kX-Cw for 48262@debbugs.gnu.org; Thu, 06 May 2021 13:28:00 -0400 Received: by mail-qt1-f173.google.com with SMTP id g13so4616252qts.4 for <48262@debbugs.gnu.org>; Thu, 06 May 2021 10:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FLkC0Ke2hXvvB2RpvZvoheOARp0aZWFxKRyivduEY8M=; b=Z5mt6Cskdr0gNQeeYoHt/kceu/cfxR/NoKl+mEQIpRL2i9D2Lk58seimR17d5XV0Zs +0YmitCtL5dXg1hRNBW1zIq3ePIk+BRvzwllyWL0fRf5LLNmxuhJ8EuAjIlMmStCsPBd d/PadXWbNsxTvxo55oYyjFPrDdd4SQF+Se6Jl7lbu/zFoifhDH8gqF7uKbie2FWM8QUw WmQ5NPzSSHO8vzTJaGCIeygLXeiIYiU+rp89nXYIDgVtiCL1l/OybW8dSxLw/n2lDO4m pJXFcPLQ3dUf/rzIc3MYTXio5rA+UlCQjlPRL6Ql/lYZzRl+tszJMvziGY1nKRUOnTt7 UM4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FLkC0Ke2hXvvB2RpvZvoheOARp0aZWFxKRyivduEY8M=; b=imoeV+dUwnaxZT5Eqxnv3fPOmf9upBrK5RIa01Lo3qj4LxmM71Cnsk3NMP0PpD45yj SGShFR6i31qX7oWatn4nwLInv2dpY41/taIjOtGm+FfwG4+a6iE69P6MlCoNFlefKoYF kwiUCzaBPOK1vtlpfcdd/iuNSOWZ9GQFVucEaQ/bMyGPQ6prnQMxJDInLLuuT6zqz5hF jRVqn6IQV2rGdMWhwzkFjnoa9hMHp/tL9o5H6f1wXD40pTVXxMnWmpBTYbe1h4Ky/cPm SivH2nEtq+wcaXQ6UzRFkLq+/Ya1ynlcOAuFZhwHuGomERFsygboeDq4OKl+FdTq/Z9Q JV3Q== X-Gm-Message-State: AOAM533sSitrRtNwRB0hycR0CVpTeruEUwAQ9tfSM+VnuuN8/hNNVint FU4k5yEB4Yf8kYRJUPdGzV/PrhtRLDwH6Q== X-Google-Smtp-Source: ABdhPJx7S5Vs0wjNKXl/JCX6UfV1vAlC/7Bm6Djq9M9huZyfTPNYYcX5ju0N73QYxNBSZ1OWd3c6ZA== X-Received: by 2002:ac8:7fc5:: with SMTP id b5mr5284725qtk.122.1620322074328; Thu, 06 May 2021 10:27:54 -0700 (PDT) Received: from localhost.localdomain (dsl-10-131-245.b2b2c.ca. [72.10.131.245]) by smtp.gmail.com with ESMTPSA id y13sm2495704qkj.84.2021.05.06.10.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 10:27:54 -0700 (PDT) From: Maxim Cournoyer Date: Thu, 6 May 2021 13:27:31 -0400 Message-Id: <20210506172732.12294-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210506172732.12294-1-maxim.cournoyer@gmail.com> References: <20210506172732.12294-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches This fixes the following issue where spice-vdagent would fail to start if the spice-vdagent-sock socket file already existed: spice-vdagentd: Fatal could not create the server socket /run/spice-vdagentd/spice-vdagent-sock: Error binding to address: Address already in use The requirement is also modified to depend on dbus-system, a cue taken from upstream's own systemd service file (see 'data/spice-vdagentd.service' in the sources). * gnu/services/spice.scm (spice-vdagent-activation): Delete procedure. (spice-vdagent-shepherd-service): Fix indentation. [requirement]: Replace udev by dbus-system. [start]: Ensure the spice-vdagentd run-time directory exists and that the spice-vdagent-sock socket file does *not* exist before forking the daemon. --- gnu/services/spice.scm | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/gnu/services/spice.scm b/gnu/services/spice.scm index a2aee4ab2a..3b88e29043 100644 --- a/gnu/services/spice.scm +++ b/gnu/services/spice.scm @@ -34,28 +34,29 @@ (spice-vdagent spice-vdagent-configuration-spice-vdagent (default spice-vdagent))) -(define (spice-vdagent-activation config) - "Return the activation gexp for CONFIG." - #~(begin - (use-modules (guix build utils)) - (mkdir-p "/run/spice-vdagentd"))) - (define (spice-vdagent-shepherd-service config) "Return a for spice-vdagentd with CONFIG." (define spice-vdagent (spice-vdagent-configuration-spice-vdagent config)) (define spice-vdagentd-command (list - (file-append spice-vdagent "/sbin/spice-vdagentd") - "-x")) + (file-append spice-vdagent "/sbin/spice-vdagentd") + "-x")) (list - (shepherd-service - (documentation "Spice vdagentd service") - (requirement '(udev)) - (provision '(spice-vdagentd)) - (start #~(make-forkexec-constructor '#$spice-vdagentd-command)) - (stop #~(make-kill-destructor))))) + (shepherd-service + (documentation "Spice vdagentd service") + (requirement '(dbus-system)) + (provision '(spice-vdagentd)) + (start #~(lambda args + ;; spice-vdagentd supports being activated upon the client + ;; connecting to its socket; when not using such feature, the + ;; socket should not exist before vdagentd creates it itself. + (mkdir-p "/run/spice-vdagentd") + (false-if-exception + (delete-file "/run/spice-vdagentd/spice-vdagent-sock")) + (fork+exec-command '#$spice-vdagentd-command))) + (stop #~(make-kill-destructor))))) (define spice-vdagent-profile (compose list spice-vdagent-configuration-spice-vdagent)) @@ -67,8 +68,6 @@ (extensions (list (service-extension shepherd-root-service-type spice-vdagent-shepherd-service) - (service-extension activation-service-type - spice-vdagent-activation) (service-extension profile-service-type spice-vdagent-profile))))) From patchwork Thu May 6 17:27:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxim Cournoyer X-Patchwork-Id: 29154 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0502427BC81; Thu, 6 May 2021 18:29:18 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 3AED627BC84 for ; Thu, 6 May 2021 18:29:15 +0100 (BST) Received: from localhost ([::1]:59500 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lehoI-0001L8-Fo for patchwork@mira.cbaines.net; Thu, 06 May 2021 13:29:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37594) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leho7-0001KZ-72 for guix-patches@gnu.org; Thu, 06 May 2021 13:29:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55415) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leho6-0001Yr-UT for guix-patches@gnu.org; Thu, 06 May 2021 13:29:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leho6-0005lo-R9 for guix-patches@gnu.org; Thu, 06 May 2021 13:29:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48262] [PATCH version-1.3.0 3/3] gnu: system: Add SPICE capability to the VM image. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 17:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48262 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48262@debbugs.gnu.org Cc: Maxim Cournoyer Received: via spool by 48262-submit@debbugs.gnu.org id=B48262.162032208522152 (code B ref 48262); Thu, 06 May 2021 17:29:02 +0000 Received: (at 48262) by debbugs.gnu.org; 6 May 2021 17:28:05 +0000 Received: from localhost ([127.0.0.1]:38723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehnA-0005lE-Px for submit@debbugs.gnu.org; Thu, 06 May 2021 13:28:04 -0400 Received: from mail-qk1-f176.google.com ([209.85.222.176]:33287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lehn9-0005kY-Tv for 48262@debbugs.gnu.org; Thu, 06 May 2021 13:28:04 -0400 Received: by mail-qk1-f176.google.com with SMTP id o5so5745768qkb.0 for <48262@debbugs.gnu.org>; Thu, 06 May 2021 10:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9h12S2Nw8P5MGZRXqbAMoVWSyQd9rhFNpk0TMyC0QzY=; b=AoiGMK04Rurz7JQI2yiI8yl+XqyUq+Jm9M4TWOmMvE2QxCSMU2+AwVOgKv0DEvKbmn A2GodkWNVsnDg0lXBEm0uYLGZF0NSFnD+zYBQGWGsfXC0C2z1jGJvDfb0DFkQJn2H9vi 35z9OWlhh+HH6RqtLq02FNdJYaL7zWnQuTLMBs8cxjCuVr+T+dumJfOGcyQUpbxuKxz3 nh0DwH08/NPPaghaeYh7T5dh0fzrH73pKdHQvRwOn7QvhdYwJuzn/rxyFvRbVdQPV/Eo aUKXU1Hz4cRFtCV0MXbf2Lhai+p2hzLXc7o0YGMn7sjY9gZlfDnE1cwQ9bCLWmtw+OnE 9d7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9h12S2Nw8P5MGZRXqbAMoVWSyQd9rhFNpk0TMyC0QzY=; b=gRKm2FrX1YKgQ7/kr0SgU9N1huRzm7CmLRAaI8nzQhym6tk7IfOEc7QDOBSUEy7nBi Zv3LwA54FLvWPcwsm0PLca1Toog50ZQR1QoWWgQWRHlu/i+3TSxwa/tVFmFyjCih6+8q /JGfDGZJVal++RfEW0FzzIFKUkqpbp2IZTKboyzinl44UTRItU2DoZezucNh+i/j89aA Y44lWK2nec5+NLmmD+juGSgO3WNV8fw90GyK2opPnI7+ehU2rSB/MZBWHzFLYS/o55ec CvXfF8zCABt22N3aUc6/V++CikS7eFsvuhCHqAT+X5Ra1buez3GPVB62s1QmncUEfkgA Fjuw== X-Gm-Message-State: AOAM532yu1+v+d96uq8JZdvzZ60ecm0NTwUMP1IWz4nsb2COseEyV+X+ ynodmHG4lwNFgegAhBYukEB3lvXQtDk6tQ== X-Google-Smtp-Source: ABdhPJywRAGyqr6CJ02mvRHvxKNdjws5z+ek63BfAVqhaYyKZi1JSRIJOtbuu3n2WKbMX0e7++J+dQ== X-Received: by 2002:a37:ae02:: with SMTP id x2mr5058723qke.335.1620322078367; Thu, 06 May 2021 10:27:58 -0700 (PDT) Received: from localhost.localdomain (dsl-10-131-245.b2b2c.ca. [72.10.131.245]) by smtp.gmail.com with ESMTPSA id y13sm2495704qkj.84.2021.05.06.10.27.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 10:27:58 -0700 (PDT) From: Maxim Cournoyer Date: Thu, 6 May 2021 13:27:32 -0400 Message-Id: <20210506172732.12294-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210506172732.12294-1-maxim.cournoyer@gmail.com> References: <20210506172732.12294-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/system/examples/vm-image.tmpl (services) [spice-vdagent-service-type]: Add service. [slim-service-type] : Add the xf86-video-qxl module. --- gnu/system/examples/vm-image.tmpl | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/gnu/system/examples/vm-image.tmpl b/gnu/system/examples/vm-image.tmpl index bcb2ba614c..1a2dfca452 100644 --- a/gnu/system/examples/vm-image.tmpl +++ b/gnu/system/examples/vm-image.tmpl @@ -5,7 +5,7 @@ ;; (use-modules (gnu) (guix) (srfi srfi-1)) -(use-service-modules desktop networking ssh xorg) +(use-service-modules desktop networking spice ssh xorg) (use-package-modules bootloaders certs fonts nvi package-management wget xorg) @@ -75,11 +75,20 @@ root ALL=(ALL) ALL (default-user "guest") (xorg-configuration (xorg-configuration + ;; The QXL virtual GPU driver is added to provide + ;; a better SPICE experience. + (modules (cons xf86-video-qxl + %default-xorg-modules)) (keyboard-layout keyboard-layout))))) ;; Uncomment the line below to add an SSH server. ;;(service openssh-service-type) + ;; Add support for the SPICE protocol, which enables dynamic + ;; resizing of the guest screen resolution, clipboard + ;; integration with the host, etc. + (service spice-vdagent-service-type) + ;; Use the DHCP client service rather than NetworkManager. (service dhcp-client-service-type))