From patchwork Mon Apr 19 11:02:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Tildesley X-Patchwork-Id: 28655 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id BFE2A27BC77; Mon, 19 Apr 2021 12:10:45 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1891727BC6C for ; Mon, 19 Apr 2021 12:10:42 +0100 (BST) Received: from localhost ([::1]:53144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYRnc-0003mx-6q for patchwork@mira.cbaines.net; Mon, 19 Apr 2021 07:10:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYRgE-00068P-Gt for guix-patches@gnu.org; Mon, 19 Apr 2021 07:03:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36964) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYRgE-0007se-9J for guix-patches@gnu.org; Mon, 19 Apr 2021 07:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYRgE-0007lD-63 for guix-patches@gnu.org; Mon, 19 Apr 2021 07:03:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47870] [PATCH 1/2] gnu: polkit-gnome: Add autostart .desktop file. Resent-From: Brendan Tildesley Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Apr 2021 11:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47870 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47870@debbugs.gnu.org Cc: Leo Prikler Received: via spool by 47870-submit@debbugs.gnu.org id=B47870.161883013629762 (code B ref 47870); Mon, 19 Apr 2021 11:03:02 +0000 Received: (at 47870) by debbugs.gnu.org; 19 Apr 2021 11:02:16 +0000 Received: from localhost ([127.0.0.1]:48510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYRfU-0007jy-2o for submit@debbugs.gnu.org; Mon, 19 Apr 2021 07:02:16 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:8422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYRfR-0007jj-8M for 47870@debbugs.gnu.org; Mon, 19 Apr 2021 07:02:15 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4FP3mZ66MTzQk2p; Mon, 19 Apr 2021 13:02:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1618830125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9fCiBSKINe6KaUzE5/wK8bFVl+m28KkKx67OuWMppjY=; b=biclvwk0UHToD9RglmeH1pL/g4gfLA05GRwvwSQnRl3MWARJ1pPyyGyR+t9Odkoai0OlhZ A3yHDuZdCgI7zTD4mgrvpLLWkJb6pSAGfkYoWxNh63f9Is+r9WK1iF6drB7tGGedVdzbxs pabNEpXO4kLS185qN26n4ODR7KfKJMriJnEo1/92fpi8XzXzkSGk7gbXSHCWIYAYdCkWYs 1ml7ewRKoDaTaOKGp4AHeXJ7MgGhSs5xtdBz5fxtOMI8GM/V1DWSggfV3XUp3pAd171gdv 7pOjNe7o97zkNemn7qs7iLxN7uzWVUR+WbQTrrhJNQorJcL1+x5cRmlczR6sTQ== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter01.heinlein-hosting.de (spamfilter01.heinlein-hosting.de [80.241.56.115]) (amavisd-new, port 10030) with ESMTP id lB_igv7UUaRz; Mon, 19 Apr 2021 13:02:03 +0200 (CEST) Date: Mon, 19 Apr 2021 13:02:02 +0200 (CEST) From: Brendan Tildesley Message-ID: <563816062.89942.1618830123011@office.mailbox.org> In-Reply-To: <758fbca893846a643f5478972867e01d620b89dc.camel@student.tugraz.at> References: <20210418131727.6104-1-mail@brendan.scot> <687049384.78340.1618758931217@office.mailbox.org> <1897089617.84042.1618815414259@office.mailbox.org> <758fbca893846a643f5478972867e01d620b89dc.camel@student.tugraz.at> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -5.31 / 15.00 / 15.00 X-Rspamd-Queue-Id: B40A2189A X-Rspamd-UID: 45a05b X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches > On 04/19/2021 9:36 AM Leo Prikler wrote: > > > Hi Brendan, > > Am Montag, den 19.04.2021, 08:56 +0200 schrieb Brendan Tildesley: > > > On 04/18/2021 5:52 PM Leo Prikler > > > wrote: > > > > > > > > > Hi, > > > > > > Am Sonntag, den 18.04.2021, 17:15 +0200 schrieb Brendan Tildesley: > > > > > On 04/18/2021 4:47 PM Leo Prikler < > > > > > leo.prikler@student.tugraz.at> > > > > > wrote: > > [...] > > > > On second thought perhaps another option is just to use the MATE > > > > polkit > > > > agent instead? I tested it for changing network manager and it > > > > worked > > > > just the same, only the GUI looks slightly different. I was > > > > searching > > > > What do you think? > > > If it works for XFCE, why not? Given that polkit-gnome has no > > > dependents other than itself, should we perhaps also look into > > > removing > > > it? > > > > > One issue is that mate-polkit's .desktop file has the line > > OnlyShowIn=MATE; > > This prevents it from being launched in any other desktop. When > > multiple > > desktops are installed all these files sit in /run/current- > > desktop/profile/etc/ > > and rely these lines to make them not appear in other desktops. > > > > I made a couple patches [attached] that adds XFCE to the the > > .desktop's OnlyShowIn. > > It's a little ugly though. > This may potentially be bikeshedding, but what about defining a > (potentially hidden) package, that inherits from mate-polkit (call it > mate-polkit-for-xfce) and installs a .desktop file, that replaces MATE > with XFCE? Ah, well, you'd also have to move the desktop file to a > different location for there not to be a name clash. > I think it's good to think about. This way makes it more self contained. > Other than that, the contents of your patches LGTM, but the ChangeLog > is on a pretty verbose end. For instance, the message for 0001 should > likely be rewritten as: > > ---- > gnu: polkit-mate: Enable autostarting in XFCE. > > Add XFCE to the OnlyShowIn field of the autostart .desktop file so it > will be started by XFCE as well. This is for the same of making > polkit-mate the de facto polkit agent for XFCE in Guix, since XFCE does > not ship its own. > > A potential downside might be, that this desktop file ends up in the > current system profile and can therefore be seen in XFCE > configurations, that did not ask for it. > > * gnu/packages/mate.scm (polkit-mate)[#:phases]: Add 'patch-desktop- > for-xfce'. > ---- > > You could also write significantly shorter commit messages, since > "Enable autostarting in XFCE" already tells you everything the patch > does. > > Regards, Leo Yeah I suck at commit messages. I've attached new patches doing it this way and confirmed it worked in a VM. From d18093a93f34f7d134a6f97e58aa4abaadbe33a6 Mon Sep 17 00:00:00 2001 From: Brendan Tildesley Date: Mon, 19 Apr 2021 20:16:05 +1000 Subject: [PATCH 2/2] gnu: xfce: Add xfce-mate-polkit-autostart to inputs. * gnu/packages/xfce.scm (xfce):[inputs]: Add xfce-mate-polkit-autostart. --- gnu/packages/xfce.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm index c7ba6218f1..974259306e 100644 --- a/gnu/packages/xfce.scm +++ b/gnu/packages/xfce.scm @@ -1016,6 +1016,7 @@ on your desktop.") ("gnome-icon-theme" ,gnome-icon-theme) ("gtk-xfce-engine" ,gtk-xfce-engine) ("hicolor-icon-theme" ,hicolor-icon-theme) + ("xfce-mate-polkit-autostart" ,xfce-mate-polkit-autostart) ("ristretto" ,ristretto) ("shared-mime-info" ,shared-mime-info) ("thunar" ,thunar) -- 2.31.1