From patchwork Tue Apr 6 17:43:59 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Famulari X-Patchwork-Id: 28342 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id CF6B327BC68; Tue, 6 Apr 2021 18:53:45 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 1DF3427BC67 for ; Tue, 6 Apr 2021 18:53:45 +0100 (BST) Received: from localhost ([::1]:52702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTptY-0008Uw-9Z for patchwork@mira.cbaines.net; Tue, 06 Apr 2021 13:53:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTpl8-0007iW-OT for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58378) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTpl8-0000kP-Eh for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTpl8-00087k-B4 for guix-patches@gnu.org; Tue, 06 Apr 2021 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47613] =?utf-8?b?W1BBVENIXcKgYWRk?= parmetis Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 06 Apr 2021 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47613 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Franck =?utf-8?b?UMOpcmlnbm9u?= Cc: 47613@debbugs.gnu.org Received: via spool by 47613-submit@debbugs.gnu.org id=B47613.161773105331156 (code B ref 47613); Tue, 06 Apr 2021 17:45:02 +0000 Received: (at 47613) by debbugs.gnu.org; 6 Apr 2021 17:44:13 +0000 Received: from localhost ([127.0.0.1]:41691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTpkL-00086S-Ca for submit@debbugs.gnu.org; Tue, 06 Apr 2021 13:44:13 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:43985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTpkG-000869-LS for 47613@debbugs.gnu.org; Tue, 06 Apr 2021 13:44:12 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 96D2C133D; Tue, 6 Apr 2021 13:44:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 06 Apr 2021 13:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=HPFK/nOYIGIYotJ9Lhtoh05d yXn0yEqdOBuXCYXqTjA=; b=qXVQQvEpscSKxbf70Rb2UcfdWuoqdS9wP5wSGidX NXqf6baUNasHknIDH4B8Fj9ozXs7/w31tQ/XvEVVu9cKpS5ZJcRsSAILo3lgdq1K LXv3YNsFC+5pedOnmjFIWD3jK6S/E8BATpMyUe+BcBwQUb70n13I+Miaj+nraz+i 8tI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=HPFK/n OYIGIYotJ9Lhtoh05dyXn0yEqdOBuXCYXqTjA=; b=iL6Plpdm8rUVEv8LgXZQPm R39fEljhtlMhydpRGNN1nOjakTjenMkNZB629za60JWgMXhVUmIjw4eEefDEHzUa fttJTOg48h1yJvvYC+tMgAt+UMNtKT19aljL9Ge3yfoWQkTzsoJ+ykZCMewaRn2e rl0sTsVuQnu/k+7mBaOwKt8LFyuYTgCsgw01hr+hbl+TUeyf+/cXLcFkX/UzSk3j m1JEzW2HejVHUv/PuNHOtBPhKIXQvqKfcjQ8TkUYggEhAryDhn0AnQ5+Sx/1DCAZ V41w6z7qp4jgcp/2J767KR8pZ+oBqTKXAybSoq2ibTkk2PXXykwpPCzj813nn/bw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpedufeeutdehtdffiefhffduveettddvieehueeghfeufedtvdffgeekkeelvdff heenucffohhmrghinhepuhhmnhdrvgguuhenucfkphepuddttddruddurdduieelrdduud eknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgv ohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 61DAC240057; Tue, 6 Apr 2021 13:44:01 -0400 (EDT) Date: Tue, 6 Apr 2021 13:43:59 -0400 From: Leo Famulari Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Subject: [PATCH] [PATCH] Add parmetis Thanks! + (build-system cmake-build-system) + (native-inputs `(("gcc" ,gcc) + ("openmpi" ,openmpi))) GCC is made available via the cmake-build-system, so I think we could leave it out of native-inputs. Or am I missing something? + (arguments + `(#:tests? #f ;no tests + #:configure-flags `("-DSHARED=ON" + ,"-DCMAKE_C_COMPILER=mpicc" + ,"-DCMAKE_CXX_COMPILER=mpic++" + ,"-DCMAKE_VERBOSE_MAKEFILE=1" + ,(string-append "-DGKLIB_PATH=../parmetis-4.0.3/metis/GKlib") + ,(string-append "-DMETIS_PATH=../parmetis-4.0.3/metis" )))) We can avoid hard-coding the version string here, like this: ------ ------ + (license license:asl2.0))) There is a problem with the licensing, however. In the source code, LICENSE.txt contains this: ------ Copyright & License Notice -------------------------- The ParMETIS package is copyrighted by the Regents of the University of Minnesota. It can be freely used for educational and research purposes by non-profit institutions and US government agencies only. Other organizations are allowed to use ParMETIS only for evaluation purposes, and any further uses will require prior approval. The software may not be sold or redistributed without prior approval. One may make copies of the software for their use provided that the copies, are not sold or distributed, are used under the same terms and conditions. As unestablished research software, this code is provided on an ``as is'' basis without warranty of any kind, either expressed or implied. The downloading, or executing any part of this software constitutes an implicit agreement to these terms. These terms and conditions are subject to change at any time without prior notice. ------ I saw in 'metis/Changelog' that a relicensing to Apache 2 was done for the "metis" program in version 5.0.3. But, this is "parmetis", version 4.0.3. If the copyright owners intend to release this as free software, they need to change the 'LICENSE.txt' file. diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm index bdfa051db1..f0ebdd6009 100644 --- a/gnu/packages/maths.scm +++ b/gnu/packages/maths.scm @@ -3348,8 +3348,10 @@ schemes.") ,"-DCMAKE_C_COMPILER=mpicc" ,"-DCMAKE_CXX_COMPILER=mpic++" ,"-DCMAKE_VERBOSE_MAKEFILE=1" - ,(string-append "-DGKLIB_PATH=../parmetis-4.0.3/metis/GKlib") - ,(string-append "-DMETIS_PATH=../parmetis-4.0.3/metis" )))) + ,(string-append "-DGKLIB_PATH=../parmetis-" + ,(package-version this-version) "/metis/GKlib")) + ,(string-append "-DMETIS_PATH=../parmetis-" + ,(package-version this-version) "/metis")))) (home-page "http://glaros.dtc.umn.edu/gkhome/metis/parmetis/overview") (synopsis "Parallel Graph Partitioning and Fill-reducing Matrix Ordering") (description