From patchwork Wed Mar 24 13:36:02 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rovanion Luckey X-Patchwork-Id: 28064 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0E36627BC5C; Wed, 24 Mar 2021 13:37:13 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, SPF_HELO_PASS,T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 671AF27BC59 for ; Wed, 24 Mar 2021 13:37:12 +0000 (GMT) Received: from localhost ([::1]:45318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP3h9-0006O9-Jp for patchwork@mira.cbaines.net; Wed, 24 Mar 2021 09:37:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37134) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP3h0-0006Nr-Gx for guix-patches@gnu.org; Wed, 24 Mar 2021 09:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51032) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lP3h0-0000T4-9y for guix-patches@gnu.org; Wed, 24 Mar 2021 09:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lP3h0-0005gl-7P for guix-patches@gnu.org; Wed, 24 Mar 2021 09:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46805] [PATCH] guix: ui: Improved error reporting when user file eval fails Resent-From: Rovanion Luckey Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Mar 2021 13:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46805 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46805@debbugs.gnu.org Cc: Xinglu Chen Received: via spool by 46805-submit@debbugs.gnu.org id=B46805.161659299821837 (code B ref 46805); Wed, 24 Mar 2021 13:37:02 +0000 Received: (at 46805) by debbugs.gnu.org; 24 Mar 2021 13:36:38 +0000 Received: from localhost ([127.0.0.1]:34345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP3gb-0005g9-SG for submit@debbugs.gnu.org; Wed, 24 Mar 2021 09:36:38 -0400 Received: from mail-io1-f44.google.com ([209.85.166.44]:43760) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lP3gZ-0005fs-VD for 46805@debbugs.gnu.org; Wed, 24 Mar 2021 09:36:36 -0400 Received: by mail-io1-f44.google.com with SMTP id z136so21486710iof.10 for <46805@debbugs.gnu.org>; Wed, 24 Mar 2021 06:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+HuBFF5TkEp0I0gcA9NltUV+JVmnDdNRjOjpZuCzErc=; b=mRw3Blcv827Ab8T4sQPyiJlXn6EviPMSvUdI+k7dkKQppVOT6mh9SUaw15a58ZXkfD eyB25RS3As7QD0etrlZ4sO1iXKvyXfjQYbO6O9gUq59cTomjsffhyUZvHgwT4IafvYyI hiyPfOotyTT4mBcljCwWRW+tOnWCzizpfbZbfRlOEuPGJkNG0XMX9SSxBSe8FOu/z3/3 3GBL0dVLOmxUilJKFK8D558qeDscTBufYOq+Iz8hzB8JkJa11iIRNZPugBqtbQzsueFc EaAooO0nSB17eyiLNF/BPVJh+RWLPA/LlrmkSBj4XFTasE0MqTHzBFpUt9H1ApAO9M2p R0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+HuBFF5TkEp0I0gcA9NltUV+JVmnDdNRjOjpZuCzErc=; b=ZC92cI9bQk8IqQE+o5oIs2+mUkrwrJDpbj4L+XmkzTLcX3rcjuOTxriwMzVPhrD9dT PNqe9Hkx/UUSqj4PakyIidPCPtNA1qkp7GGb9mi/QsdvX3E0VDK7pybq6ll0hFd3C7Rd L4X83KGsUKKHYksnMOIDIBXd3+XqegJsfXvUV0x+ZlfajP0y4EG/xG5K/pCANyikroPk ZkLAoKdIK6fPUOwjCBYWf4PXqnpB/lLQ6dSJ8FIhNVJye2O//2R32hhPZjufahGK+N2h NiQ+Eqy14Sp+tmEjGvGyMy+djyAvD0brd+xXR/gagkAVkaZd5YSiE3u2vj8ABzxO2poj kwvw== X-Gm-Message-State: AOAM532qyLz2FYGO6WFmH+Soc+n27/baF2cgFBgVeS+a1Pffmf7LKxdp uflaj0LUmEREgXEPGms2iobQkoUQ2OrBvksVCYGDxAHL X-Google-Smtp-Source: ABdhPJyCPnOWsh0VN+22H+kh7XIxrI3cKEMwww2Aa2PlgcTn3e73B9nhFw4O70Xtcdh7CEFY628pa7ghcgxgPfceP34= X-Received: by 2002:a02:3304:: with SMTP id c4mr2938170jae.68.1616592990172; Wed, 24 Mar 2021 06:36:30 -0700 (PDT) MIME-Version: 1.0 References: <87o8fadn50.fsf@yoctocell.xyz> In-Reply-To: <87o8fadn50.fsf@yoctocell.xyz> From: Rovanion Luckey Date: Wed, 24 Mar 2021 14:36:02 +0100 Message-ID: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Fixed the typo in the attached patch. From 57126cbff38de728d64797551239723ed18575a5 Mon Sep 17 00:00:00 2001 From: Rovanion Luckey Date: Fri, 26 Feb 2021 23:23:14 +0100 Subject: [PATCH] guix: ui: Improved error reporting when user file eval fails due to system errors Added a specific error message for when the user provided scheme file being evaluated in turn fails to load another file. Also clarified the error message given on generic system errors, to make it clear where the error originates from. --- guix/ui.scm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/guix/ui.scm b/guix/ui.scm index 7fbd4c63a2..0eabf136f6 100644 --- a/guix/ui.scm +++ b/guix/ui.scm @@ -373,9 +373,14 @@ it doesn't." "Report the failure to load FILE, a user-provided Scheme file. ARGS is the list of arguments received by the 'throw' handler." (match args + (('system-error "open-file" . rest) + (let ((err (system-error-errno args)) + (file-which-failed-to-open (car (cdr (car (cdr rest)))))) + (report-error (G_ "while evaluating '~a', it failed opening '~a' with the error: ~a~%") + file file-which-failed-to-open (strerror err)))) (('system-error . rest) (let ((err (system-error-errno args))) - (report-error (G_ "failed to load '~a': ~a~%") file (strerror err)))) + (report-error (G_ "failed to evaluate '~a', it raised the error: ~a~%") file (strerror err)))) (('read-error "scm_i_lreadparen" message _ ...) ;; Guile's missing-paren messages are obscure so we make them more ;; intelligible here. -- 2.30.0