From patchwork Tue Mar 16 16:03:12 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kei Kebreau X-Patchwork-Id: 27884 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4A89427BC54; Tue, 16 Mar 2021 16:10:20 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C98AB27BC52 for ; Tue, 16 Mar 2021 16:10:19 +0000 (GMT) Received: from localhost ([::1]:51854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lMCGw-0007rk-Qn for patchwork@mira.cbaines.net; Tue, 16 Mar 2021 12:10:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMCAu-0003bI-MU for guix-patches@gnu.org; Tue, 16 Mar 2021 12:04:11 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lMCAs-0002Aw-Q0 for guix-patches@gnu.org; Tue, 16 Mar 2021 12:04:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lMCAs-0002bX-Ks for guix-patches@gnu.org; Tue, 16 Mar 2021 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47194] [PATCH] gnu: mpg321: Fix CVE-2019-14247. Resent-From: Kei Kebreau Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Mar 2021 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 47194 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47194@debbugs.gnu.org Cc: Kei Kebreau X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16159106069965 (code B ref -1); Tue, 16 Mar 2021 16:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 Mar 2021 16:03:26 +0000 Received: from localhost ([127.0.0.1]:40825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMCAI-0002af-9e for submit@debbugs.gnu.org; Tue, 16 Mar 2021 12:03:26 -0400 Received: from lists.gnu.org ([209.51.188.17]:43992) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lMCAG-0002aX-7n for submit@debbugs.gnu.org; Tue, 16 Mar 2021 12:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37242) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMCAF-0003BC-Sq for guix-patches@gnu.org; Tue, 16 Mar 2021 12:03:23 -0400 Received: from mout02.posteo.de ([185.67.36.66]:48311) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lMCAC-0001pr-6r for guix-patches@gnu.org; Tue, 16 Mar 2021 12:03:23 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E8C9F24010A for ; Tue, 16 Mar 2021 17:03:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1615910595; bh=mna4D3RLqdqno9wdzACuu8ZJxc+67GfYKwqH+/aFg/Q=; h=From:To:Cc:Subject:Date:From; b=HW9mfwRJ4OBrV6D+dWyyiciAkDYAMdcQggI7M7UhqUmzp4VN9LLc+7IttWJT1vxRh mqgFTf1cLCvXqsq3XjYKyxSoZlzYkNXRilmhHDq54fxZsISa1CCdly/TgpQR4yJ8u1 ir3XYSFaAUtPLnQUrWz2YfD0DJdIF79rCg3XTSvBbkGmEdhyvcLtSCnvF6nvH5CpMd fqmCsZpllhnKbcWNbNIH6DqV6PJ7NQYds0NUqvwHJ4SinWuPpi3A8KAZaOIzZ1siI2 6Pjp02WqkdgggC3hS3HpBhaB8QCJojTyCoFYO8BHoFhORj0nsCfbmq0xNpcWoX30ZG MBcInDCFrgB3g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4F0J3k6YDfz9rxK; Tue, 16 Mar 2021 17:03:14 +0100 (CET) From: Kei Kebreau Date: Tue, 16 Mar 2021 12:03:12 -0400 Message-Id: <20210316160312.16888-1-kkebreau@posteo.net> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Received-SPF: pass client-ip=185.67.36.66; envelope-from=kkebreau@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/patches/mpg321-CVE-2019-14247.patch: New file. * gnu/local.mk (dist_patch_DATA): Register it. * gnu/packages/mp3.scm (mpg321)[source]: Apply it. --- gnu/local.mk | 1 + gnu/packages/mp3.scm | 4 +++- .../patches/mpg321-CVE-2019-14247.patch | 23 +++++++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mpg321-CVE-2019-14247.patch diff --git a/gnu/local.mk b/gnu/local.mk index cf8849cf59..abb1e2140d 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1404,6 +1404,7 @@ dist_patch_DATA = \ %D%/packages/patches/mit-krb5-hurd.patch \ %D%/packages/patches/mit-krb5-qualify-short-hostnames.patch \ %D%/packages/patches/mpc123-initialize-ao.patch \ + %D%/packages/patches/mpg321-CVE-2019-14247.patch \ %D%/packages/patches/module-init-tools-moduledir.patch \ %D%/packages/patches/monero-use-system-miniupnpc.patch \ %D%/packages/patches/mono-mdoc-timestamping.patch \ diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm index 34390d3696..dba3e17558 100644 --- a/gnu/packages/mp3.scm +++ b/gnu/packages/mp3.scm @@ -408,7 +408,9 @@ command-line tool as well as a C library, libmpg123.") version "/mpg321-" version ".tar.gz")) (sha256 (base32 - "0ki8mh76bbmdh77qsiw682dvi8y468yhbdabqwg05igmwc1wqvq5")))) + "0ki8mh76bbmdh77qsiw682dvi8y468yhbdabqwg05igmwc1wqvq5")) + (patches + (search-patches "mpg321-CVE-2019-14247.patch")))) (build-system gnu-build-system) (arguments '(#:configure-flags '("--disable-alsa"))) (inputs diff --git a/gnu/packages/patches/mpg321-CVE-2019-14247.patch b/gnu/packages/patches/mpg321-CVE-2019-14247.patch new file mode 100644 index 0000000000..03afaccc67 --- /dev/null +++ b/gnu/packages/patches/mpg321-CVE-2019-14247.patch @@ -0,0 +1,23 @@ +This patch was downloaded from https://sourceforge.net/p/mpg321/bugs/51/ and +fixes CVE-2019-14247. + +Description: Handle illegal bitrate value +Author: Chrysostomos Nanakos +Bug-Debian: https://bugs.debian.org/870406 +Bug-Debian: https://bugs.debian.org/887057 + +--- mpg321-0.3.2.orig/mad.c ++++ mpg321-0.3.2/mad.c +@@ -574,6 +574,12 @@ void scan(void const *ptr, ssize_t len, + + if (!is_vbr) + { ++ if (header.bitrate <= 0) ++ { ++ fprintf(stderr, "Illegal bit allocation value\n"); ++ return; ++ } ++ + double time = (len * 8.0) / (header.bitrate); /* time in seconds */ + double timefrac = (double)time - ((long)(time)); + long nsamples = 32 * MAD_NSBSAMPLES(&header); /* samples per frame */