From patchwork Thu Feb 11 19:38:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 26998 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 70F3727BC27; Thu, 11 Feb 2021 19:49:03 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id EE4D727BC26 for ; Thu, 11 Feb 2021 19:49:01 +0000 (GMT) Received: from localhost ([::1]:56916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAHxU-00087Q-VD for patchwork@mira.cbaines.net; Thu, 11 Feb 2021 14:49:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAHnq-0007x7-Ma for guix-patches@gnu.org; Thu, 11 Feb 2021 14:39:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:47755) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAHnq-0006yh-Dr for guix-patches@gnu.org; Thu, 11 Feb 2021 14:39:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAHnq-0004Cs-AI for guix-patches@gnu.org; Thu, 11 Feb 2021 14:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#46440] [PATCH core-updates] gnu: findutils-boot0: Enable tests on arm. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Feb 2021 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 46440 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 46440@debbugs.gnu.org X-Debbugs-Original-To: Guix-patches Received: via spool by submit@debbugs.gnu.org id=B.161307231516135 (code B ref -1); Thu, 11 Feb 2021 19:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Feb 2021 19:38:35 +0000 Received: from localhost ([127.0.0.1]:59301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAHnP-0004CB-7F for submit@debbugs.gnu.org; Thu, 11 Feb 2021 14:38:35 -0500 Received: from lists.gnu.org ([209.51.188.17]:40204) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAHnL-0004C0-86 for submit@debbugs.gnu.org; Thu, 11 Feb 2021 14:38:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55454) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAHnK-0007NQ-9o for guix-patches@gnu.org; Thu, 11 Feb 2021 14:38:30 -0500 Received: from mout.gmx.net ([212.227.17.22]:50405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAHnE-0006uQ-Ba for guix-patches@gnu.org; Thu, 11 Feb 2021 14:38:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1613072301; bh=R6X7VqWDac9nH5TuB6kUPot485ylz2FKeB91NT14oNY=; h=X-UI-Sender-Class:From:To:Subject:Date; b=O2MybveaoKsPQpcg/x6b2U0HNTKjGcdYktX9fznCdNtNYDdFvHKpzcQbe0jAqRtwK 1tHoB1SigqHjEZD/gckO0pDbCLoKf6n/NlsO0XTnOvW05NdP48kG8hJnqFwypy7Eba wHdL04qKx65UlM6LedKj6VMw4K+jTYqeD8w6rGYA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from labiere ([82.69.64.142]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MatRT-1llpGZ3jnH-00cOWq for ; Thu, 11 Feb 2021 20:38:21 +0100 User-agent: mu4e 1.4.15; emacs 27.1 From: Pierre Langlois Date: Thu, 11 Feb 2021 19:38:16 +0000 Message-ID: <87czx6wg2f.fsf@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:ufyeSH2/K/21O0TeD6zizio9Nj8n1KM+TvjtUswXd32wyi9k5Pk TvlkUQH6sKasJCsz6vQYVcT7kzjm/wiSw0+fjLuRP6tNPeUsb0/cnjS8UCPen4IWwTH0sz3 2FOWGqnztdYiBi3JBGtYtkeCNLLKITtSa1acX68RK1UNuYBHu0XFymm+MleS5VPEa30Rvnp pVBp/10SkgrCmEc7xllcA== X-UI-Out-Filterresults: notjunk:1;V03:K0:gT9qVcmOXqo=:3EM4ni4xBKeqXO/GQU3bBL ILZGrQcr4G0Ff4RtCU/SnvN+XFDjFhp0Ner829vbAMkL4xoMV6LGtbAAIr0jiaXodeEnxuzoP vK+hrZ7CX0ookLd1oTblt0jJvG8mXfep4sb+ITKTTP6yUZMgeIOiY9yoPZ0IRfJwmu+TFJOuA bOTIn43qdInqQ7P3W2A7vxOa7UdOL+cQi8llRGI14eUYkJPTHJP/xOrTZ9gtjC+fni7/+DZvM ZyJp1IMvS0ZlAH1K+HqDBboKrtIW87mgA+UDFo4X7mKiD9rkolpY9FWlnwPaQCrQHShBg+atB Vq8CmBlde0A/AEE16JNxd8Xt5rItrCX13zzh9MJc+Lb1SGLkLvlYqaAeMynmoDp4EgMNh9H7T beZa+XjIKPWhl490eytNIcI1PgBRIyKWwCas11bpb1bllZJJKNAUzy73h7NRRJwCu8ECmXYws /lBUPEEa8wxvvxvNl3KXFdw6aDScYk2zriBkn3OPsXA6vfgyAa5lX/fn5Mnuqo59+ZNuOniyr WVZPI9gfn8PAcdXQLmeItU4NB3N+KyPzTqu9Xdyq3vjbK45hR73AFBlfWoLJacXTxZhPzgvJ2 +IN1ocfEw6ciw93ySsEsshZ1onJ/L/MoiX8AP6jK9K0Rv/dFQcp9M1dniylmCb/4+sSCnC0o8 Le0l8jmlfYdTOJB234fvnpxsuLJt/lcT1dmPHOFhSSMQuLhyRGlmpsKWjLpTQazDDHFyLw7Ei tNpp+LquQdz8DFwhD5wHprJQ8A+XWTudVkT3zRe3oOhnfJQjWOEOFQ7tFOatpdex6xAaoxTEL wy7z5NEqCSA7lgY9cZ+SlhMqii9ge8cWjsYjQIdONTssnSmmyLF6epQqPIo96KiqiDndu/1ll GqqAwnPA/DB7McxQtv8Q== Received-SPF: pass client-ip=212.227.17.22; envelope-from=pierre.langlois@gmx.com; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello Guix! I noticed the recent rust changes on core-updates, so I was eager to try and get rust working on aarch64 again, but I noticed I couldn't bootstrap because the pthread tests from findutils-boot0 were failing. I was just about to send a patch for that and then saw we had disabled the tests all together. So, here's an updated patch that re-enables them again, but disable only pthread tests. Let me know what you think of this patch, I've tested it on aarch64 and currently building rust 1.29, but I wasn't able to test it on x86, I'm getting the following failure: --8<---------------cut here---------------start------------->8--- starting phase `compress-documentation' compressing documentation in '/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man' with "gzip" and flags ("--best" "--no-name") sterror: unknown error: /gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/find.1 sterror: unknown error: /gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/locate.1 sterror: unknown error: /gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/updatedb.1 sterror: unknown error: /gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/xargs.1 sterror: unknown error: /gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man5/locatedb.5 error: in phase 'compress-documentation': uncaught exception: srfi-34 # phase `compress-documentation' failed after 0.0 seconds command "gzip" "--best" "--no-name" "/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/find.1" "/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/locate.1" "/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/updatedb.1" "/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man1/xargs.1" "/gnu/store/fl4xmk5pln6lw81ixjk3w24hhdn1zi26-findutils-boot0-4.8.0/share/man/man5/locatedb.5" failed with status 1 builder for `/gnu/store/g64zjdljpk4wawimf44v7ysgf23ywg30-findutils-boot0-4.8.0.drv' failed with exit code 1 build of /gnu/store/g64zjdljpk4wawimf44v7ysgf23ywg30-findutils-boot0-4.8.0.drv failed View build log at '/var/log/guix/drvs/g6/4zjdljpk4wawimf44v7ysgf23ywg30-findutils-boot0-4.8.0.drv.bz2'. --8<---------------cut here---------------end--------------->8--- I'm a bit confused what's going on, anybody has a clue? By the way, I'm glad we no longer have to pass all the tests for every stage of the rust bootstrap, getting this working on different platform was quite tedious :-). Thanks, Pierre From 6dffcb4a99909830cf0cecd2c9882867b379eca4 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 6 Feb 2021 21:23:56 +0000 Subject: [PATCH] gnu: findutils-boot0: Enable tests on arm. * gnu/packages/commencement.scm (findutils-boot0)[arguments]: Enable tests. Rename skip-fnmatch-test phase skip-tests. Only disable test-fnmatch on x86_64 and i686. Disable pthread tests on other platforms. --- gnu/packages/commencement.scm | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm index 890d57941f..ecb2307b05 100644 --- a/gnu/packages/commencement.scm +++ b/gnu/packages/commencement.scm @@ -10,6 +10,7 @@ ;;; Copyright © 2020 Timothy Sample ;;; Copyright © 2020 Guy Fleury Iteriteka ;;; Copyright © 2021 Maxim Cournoyer +;;; Copyright © 2021 Pierre Langlois ;;; ;;; This file is part of GNU Guix. ;;; @@ -2490,8 +2491,6 @@ exec " gcc "/bin/" program ,@(%bootstrap-inputs+toolchain))) (arguments `(#:implicit-inputs? #f - ;; Ignore test failure in gnulib for armhf/aarch64. - #:tests? ,(not (target-arm?)) #:guile ,%bootstrap-guile ;; The build system assumes we have done a mistake when time_t is 32-bit @@ -2509,14 +2508,22 @@ exec " gcc "/bin/" program ,flags)) ((#:phases phases '%standard-phases) `(modify-phases ,phases - (add-before 'check 'skip-fnmatch-test + (add-before 'check 'skip-tests (lambda _ - ;; 'test-fnmatch' fails when using glibc-mesboot@2.16, due - ;; to incorrect handling of the [:alpha:] regexp character - ;; class. Ignore it. - (substitute* "gnulib-tests/Makefile" - (("^XFAIL_TESTS =") - "XFAIL_TESTS = test-fnmatch "))))))))))) + ,(match (%current-system) + ;; 'test-fnmatch' fails when using glibc-mesboot@2.16, due + ;; to incorrect handling of the [:alpha:] regexp character + ;; class. Ignore it. + ((or "x86_64-linux" "i686-linux") + '(substitute* "gnulib-tests/Makefile" + (("^XFAIL_TESTS =") + "XFAIL_TESTS = test-fnmatch "))) + (_ + '(substitute* "gnulib-tests/Makefile" + (("test-pthread\\$\\(EXEEXT\\)") "") + (("test-pthread-thread\\$\\(EXEEXT\\)") "") + (("test-pthread_sigmask1\\$\\(EXEEXT\\)") "") + (("test-pthread_sigmask2\\$\\(EXEEXT\\)") ""))))))))))))) (define file (package -- 2.30.0