From patchwork Fri Jan 1 10:10:15 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christopher Baines X-Patchwork-Id: 26145 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 0891527BC08; Fri, 1 Jan 2021 10:11:08 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id B6E9F27BC06 for ; Fri, 1 Jan 2021 10:11:07 +0000 (GMT) Received: from localhost ([::1]:32930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvHOk-00007s-S8 for patchwork@mira.cbaines.net; Fri, 01 Jan 2021 05:11:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39270) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvHOg-00007m-6l for guix-patches@gnu.org; Fri, 01 Jan 2021 05:11:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:43798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvHOf-0005Ia-Vq for guix-patches@gnu.org; Fri, 01 Jan 2021 05:11:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kvHOf-00053L-QB for guix-patches@gnu.org; Fri, 01 Jan 2021 05:11:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45588] [PATCH] services: postgresql: Log from pg_ctl. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 01 Jan 2021 10:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 45588 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 45588@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160949582619381 (code B ref -1); Fri, 01 Jan 2021 10:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Jan 2021 10:10:26 +0000 Received: from localhost ([127.0.0.1]:55344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvHO6-00052W-2g for submit@debbugs.gnu.org; Fri, 01 Jan 2021 05:10:26 -0500 Received: from lists.gnu.org ([209.51.188.17]:55298) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kvHO4-00052P-EV for submit@debbugs.gnu.org; Fri, 01 Jan 2021 05:10:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvHO4-0008ST-9p for guix-patches@gnu.org; Fri, 01 Jan 2021 05:10:24 -0500 Received: from mira.cbaines.net ([212.71.252.8]:43206) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvHO2-0004xL-IM for guix-patches@gnu.org; Fri, 01 Jan 2021 05:10:23 -0500 Received: from localhost (92.41.186.20.threembb.co.uk [92.41.186.20]) by mira.cbaines.net (Postfix) with ESMTPSA id 38BD427BC06 for ; Fri, 1 Jan 2021 10:10:18 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 97a7c2f7 for ; Fri, 1 Jan 2021 10:10:15 +0000 (UTC) From: Christopher Baines Date: Fri, 1 Jan 2021 10:10:15 +0000 Message-Id: <20210101101015.6524-1-mail@cbaines.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches pg_ctl will output errors when starting PostgreSQL, for example about errors in the configuration file. Without getting pg_ctl to log to a file, I'm not sure how to find those errors. * gnu/services/databases.scm (postgresql-activation): Create /var/log/postgresql. (postgresql-shepherd-service): Pass --log=/var/log/postgresql/pg_ctl to pg_ctl. --- gnu/services/databases.scm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm index d2dc5f0da8..479a3c56f7 100644 --- a/gnu/services/databases.scm +++ b/gnu/services/databases.scm @@ -205,6 +205,10 @@ host all all ::1/128 md5")) (mkdir-p #$data-directory) (chown #$data-directory (passwd:uid user) (passwd:gid user)) + ;; Create log directory + (mkdir-p "/var/log/postgresql") + (chown "/var/log/postgresql" (passwd:uid user) (passwd:gid user)) + ;; Drop privileges and init state directory in a new ;; process. Wait for it to finish before proceeding. (match (primitive-fork) @@ -247,6 +251,7 @@ host all all ::1/128 md5")) (setgid (passwd:gid user)) (setuid (passwd:uid user)) (execl pg_ctl pg_ctl "-D" #$data-directory "-o" options + "--log=/var/log/postgresql/pg_ctl" mode))))))) (pid-file (in-vicinity data-directory "postmaster.pid")) (action (lambda args