From patchwork Mon Sep 14 14:17:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 24118 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6DE9527BBE8; Mon, 14 Sep 2020 15:42:03 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id A82A827BBE7 for ; Mon, 14 Sep 2020 15:42:02 +0100 (BST) Received: from localhost ([::1]:54114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHpg9-0006Gx-MP for patchwork@mira.cbaines.net; Mon, 14 Sep 2020 10:42:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHpJu-0002mY-R2 for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44134) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHpJu-0000pv-Gb for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHpJu-0007Oz-CN for guix-patches@gnu.org; Mon, 14 Sep 2020 10:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43310] [PATCH] gnu: Add lsp-dsp-lib. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Sep 2020 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43310 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Efraim Flashner Cc: 43310@debbugs.gnu.org Received: via spool by 43310-submit@debbugs.gnu.org id=B43310.160009308428386 (code B ref 43310); Mon, 14 Sep 2020 14:19:02 +0000 Received: (at 43310) by debbugs.gnu.org; 14 Sep 2020 14:18:04 +0000 Received: from localhost ([127.0.0.1]:55680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpIy-0007Nm-B4 for submit@debbugs.gnu.org; Mon, 14 Sep 2020 10:18:04 -0400 Received: from mout02.posteo.de ([185.67.36.142]:58659) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHpIw-0007L2-5g for 43310@debbugs.gnu.org; Mon, 14 Sep 2020 10:18:03 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id CB8C62400FB for <43310@debbugs.gnu.org>; Mon, 14 Sep 2020 16:17:55 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BqpNf17tnz6tml; Mon, 14 Sep 2020 16:17:53 +0200 (CEST) Message-ID: <3128d450cf954008cadc7c24d9817c5e88a6b4ea.camel@zrythm.org> From: Alexandros Theodotou Date: Mon, 14 Sep 2020 15:17:48 +0100 In-Reply-To: <20200914140203.GB17272@E5400> References: <9160c83dd3e513eb0f73b6a8b22ee78323fd2555.camel@zrythm.org> <20200914140203.GB17272@E5400> User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Efraim, Thanks for the review. On Mon, 2020-09-14 at 17:02 +0300, Efraim Flashner wrote: > It looks like everything in the modules directory is vendored. Can we > build it separately and link it in? I asked the author something similar a while back https://github.com/sadko4u/lsp-dsp-lib/issues/1#issuecomment-676517050 I think the build system just expects those modules to be there as sources - not sure if they even build anything to link to. BTW, this is my initial patch, before the author started to provide an all-inclusive tarball in the github releases page: ```scheme (define-public lsp-dsp-lib (package (name "lsp-dsp-lib") (version "0.5.6") (source (origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-dsp-lib") (commit (string-append "lsp-dsp-lib-" version)))) (file-name (git-file-name name version)) (sha256 (base32 "1n5qp9bjsgg1ziy9mqnx034qlzbsp7yl473vk9aigzkyj883dfpj")))) (build-system gnu-build-system) (arguments `(#:tests? #f ; no tests #:make-flags (list "CC=gcc") #:phases (modify-phases %standard-phases (add-before 'build 'copy-modules (lambda* (#:key inputs #:allow-other-keys) (copy-recursively (assoc-ref inputs "lsp-common-lib") "modules/lsp-common-lib") (copy-recursively (assoc-ref inputs "lsp-test-fw") "modules/lsp-test-fw") #t)) (replace 'configure (lambda _ (invoke "make" "config" (string-append "PREFIX=" (assoc- ref %outputs "out"))) #t))))) (inputs `(("lsp-common-lib" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-common-lib") (commit "lsp-common-lib-1.0.7"))) (file-name (git-file-name name version)) (sha256 (base32 "1alxv2ryivbj122gryxrrvyicw6zgbdk15wp010lrq6r1nj7mjxh")))) ("lsp-test-fw" ,(origin (method git-fetch) (uri (git-reference (url "https://github.com/sadko4u/lsp-test-fw") (commit "lsp-test-fw-1.0.5"))) (file-name (git-file-name name version)) (sha256 (base32 "0n4ircp9bgzwfaa6023bvfsb90qvl2iawbihnwivr5id1js5jq3p")))) )) (home-page "https://github.com/sadko4u/lsp-dsp-lib") (synopsis "Digital signal processing library") (description "The LSP DSP library provides a set of functions that perform SIMD-optimized computing on several hardware architectures. All functions currently operate on IEEE-754 single-precision floating-point numbers.") (license license:lgpl3+))) ``` > Also, I saw that there were a few > test directories. Are there tests to be built? Not sure - I don't see a check/test make target (see `make help`) > > + (arguments > > + `(#:tests? #f ; no tests > > + #:make-flags > > + (list "CC=gcc") > > This can be cc-for-target > (list (string-append "CC=" ,(cc-for-target))) ACK > > + (modify-phases %standard-phases > > + (replace 'configure > > + (lambda _ > > + (invoke "make" "config" (string-append "PREFIX=" > > (assoc-ref %outputs "out"))) > > + #t))))) > > We'd rather not use %outputs if possible, but to add it to the > lambda. > Also invoke already returns #t > > (lambda* (#:key outputs #:allow-other-keys) > (invoke "make" "config" > (string-append "PREFIX=" (assoc-ref outputs > "out")))))))) ACK Please find the updated patch attached. Thanks, Alex From 2efb2e2dfbfe4cd82b90fef44f6d6919a5cac865 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Mon, 14 Sep 2020 15:16:30 +0100 Subject: [PATCH] gnu: Add lsp-dsp-lib. * gnu/packages/audio.scm (lsp-dsp-lib): New variable. --- gnu/packages/audio.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm index 5e6008f31e..38ee4f8bcc 100644 --- a/gnu/packages/audio.scm +++ b/gnu/packages/audio.scm @@ -4778,6 +4778,37 @@ edited, converted, compressed and saved.") ,@(package-inputs ztoolkit))) (synopsis "ZToolkit with SVG support"))) +(define-public lsp-dsp-lib + (package + (name "lsp-dsp-lib") + (version "0.5.8") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/sadko4u/lsp-dsp-lib/" + "releases/download/lsp-dsp-lib-" version + "/lsp-dsp-lib-" version "-src.tar.gz")) + (sha256 + (base32 + "07w3d2i0z0xmvi1ngcgs7lc5a0da8jvf7rv4dnjk01md43b7fkh1")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no tests + #:make-flags + (list (string-append "CC=" ,(cc-for-target))) + #:phases + (modify-phases %standard-phases + (replace 'configure + (lambda* (#:key outputs #:allow-other-keys) + (invoke "make" "config" + (string-append "PREFIX=" (assoc-ref outputs "out")))))))) + (home-page "https://github.com/sadko4u/lsp-dsp-lib") + (synopsis "Digital signal processing library") + (description "The LSP DSP library provides a set of functions that perform +SIMD-optimized computing on several hardware architectures. All functions +currently operate on IEEE-754 single-precision floating-point numbers.") + (license license:lgpl3+))) + (define-public codec2 (package (name "codec2") -- 2.27.0