From patchwork Sun Sep 13 04:38:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghav Gururajan X-Patchwork-Id: 24104 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 72CFA27BBE7; Sun, 13 Sep 2020 05:41:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id C54F327BBE8 for ; Sun, 13 Sep 2020 05:41:08 +0100 (BST) Received: from localhost ([::1]:48326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kHJp5-0000L0-Pf for patchwork@mira.cbaines.net; Sun, 13 Sep 2020 00:41:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kHJp0-0000Kg-AW for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kHJp0-0004PE-1K for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kHJoz-0007dd-Tx for guix-patches@gnu.org; Sun, 13 Sep 2020 00:41:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43348] Profanity Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 13 Sep 2020 04:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43348 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Danny Milosavljevic Cc: 43348@debbugs.gnu.org Received: via spool by 43348-submit@debbugs.gnu.org id=B43348.159997203429321 (code B ref 43348); Sun, 13 Sep 2020 04:41:01 +0000 Received: (at 43348) by debbugs.gnu.org; 13 Sep 2020 04:40:34 +0000 Received: from localhost ([127.0.0.1]:49324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHJoX-0007cr-Iy for submit@debbugs.gnu.org; Sun, 13 Sep 2020 00:40:34 -0400 Received: from knopi.disroot.org ([178.21.23.139]:46896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kHJoV-0007ci-G9 for 43348@debbugs.gnu.org; Sun, 13 Sep 2020 00:40:32 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B79EF51B1C; Sun, 13 Sep 2020 06:40:29 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mKcs2Jghi9tI; Sun, 13 Sep 2020 06:40:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1599972027; bh=FD7Lumz9BRnjZZqmuac9WNAuq9zkv5IQP4NGi8hZ3kI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=fWEm1t9iDpd9b4mgLB+Xl+aDsPrL6ib6qWKHwfAL0yoW16zMl1P2DtOHOGkZ100Bv ec8SNbkqDH8y3mARa82VnJ63pW7CCeN3z1w/SG4KF3pJ2vOhAP+WbcnWE26NyE/WTL eMUGA3dG7krcXJXjCk4Y8diaAJshm7nkyS6Iv59gmoIz7GtpWUvd4NUoD7Lh2WVuQ5 eJH5VObUTh8GkQKPIKOYJ13YyZBw7oEZUW4gRsdkB2yHZaknVxPD3D+kpMUwapn4FT U9sqPK9Q+2b3QFxmXbHjX9eh8lN/xx5xxtSFm4gV43U6SZ6YLZwltaw18+K0fe6FGb L9YkFwZXp8XTg== References: <20200912025125.7540e02a@scratchpost.org> From: Raghav Gururajan Autocrypt: addr=raghavgururajan@disroot.org; prefer-encrypt=mutual; keydata= mQENBF9bXH8BCAC7baQP1wbhQBWr5vUKUs2iVJaSGpKcjUMij7xWpfhLKIVBwqrktbrQZ/2D OTvnoGi0oBxamFZ0JIdwKygD50azPiKQtgEewXoZxx+Q5amZMPCm49hJmxuun4QUWwm2UzXe qf03/P1CA1XvJ399pGOjzmbEZKfrP5k/9JMRWYMde9+mPnOo0f1UY0plgbgC6AeQINx+N/Da RcAyqKBd3eMhbK82ZGtoVVjzhQwhs7XxWOevTFyRxFdjqgOKGf5GEXPE4V9xcCxD2NN6ukk6 4ZPXGdTXsdURmWRpZPfSetGS0E4EoGd/y1hrn2SSk4rpzp/Ygn+zEj0PZVa+aYfKjk6jABEB AAG0LlJhZ2hhdiBHdXJ1cmFqYW4gPHJhZ2hhdmd1cnVyYWphbkBkaXNyb290Lm9yZz6JAU4E EwEIADgWIQSMM/Sm4O2cGgqRyauneFo59CKMnAUCX1tcfwIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAAKCRCneFo59CKMnAQDCACwmNH4amCI1fn5tuaTeFnMKK6e4vNYeYI7KuvTCadF ZgttKdrw6l4tOLHh97J3fUKksgk+Fh9uzqyv+NFeLnkbmwT+f7mzQalMRX42eaEbKn2JRoZk navjnJe0QxjxSYqIltbm360K8OIlaE5G90oaSZU4bvCkslVM1BMWi+vjWrL5jHwTPvOLtMLk 19+XN/eOzzJkXFSti6qsOqx1CUj6Ffmz8OG1ttOAGt2ZPX+QJtMOxbdcNtlqhEbH2HS1VBuC g6jgkgpCqxXdc8QXboQ4hxoSqoFkW64aq/ydkr+6e3JafKfY9rPc9yU5/k7wv6wmgNaMp+ZN aICDu8/fFkY+uQENBF9bXH8BCADGvjSiktvmm8Yswgli/e83Zq9Kxv/2adB+9Dhyz2jX2k4w 1wCMNrmg1Ld951CpukC9uW7V6aVbmv8WEdwE4IBe1kqlxGI9PFhAKT4i9fvEaun1b6grcS1t QC1rFwXiHiEUnJE7LLNcXbn0bBi810nSvuYv42kKLG7TwUuxWAIiPj+I5v4zwyyJ2+4jzPdR PuLFBG4YEX6ECqjeGBZq58cmOWL5u6Dm8IynXiv+vCgUGd5mnIAmzxXtP2P033n7+cwEuTz8 4IdWZZBY679RnLAz/LDNxZKGUjAINvEDCrvu9iNreuOu//cMYWdSCNYLh/N8LS/g+aFR4LHH mRiWslLvABEBAAGJATYEGAEIACAWIQSMM/Sm4O2cGgqRyauneFo59CKMnAUCX1tcfwIbDAAK CRCneFo59CKMnIWiCACuKyJOqA0C6tI94eAeBfy1UMC7CvfSBOwRyrzVMOF9B/YxnrvBmhk3 e8tMwwWNctsTwyPR3fZM1SgBghjGFzVZ4xMRjlN+lrTSu2sxdQgXfjWjmBYO9LsnfvwBLi7L +WoftGgLzHk/fdLF0DdZnt9Mfrx6dG0p1GSGyvvukHs4veGDUdDfc8ZnevtM+mJx7TSQN6Zd 1bFe4W7Xqy1Gfwy29Na3inl370Qwa9Hm7thk6ai4J59gN1MPyWhbSy+tXkGiYHMxHR3JOZmV gaD1lEQw1uvPsropMEKHQz6Qqr9ryVFkeSEbDv0PZwdMGGzdn+GBFxCxa2rloGEUKYUbVQGO Message-ID: <13b0be17-7d6d-dc37-c5d7-44171301f477@disroot.org> Date: Sun, 13 Sep 2020 00:38:02 -0400 Mime-Version: 1.0 In-Reply-To: <20200912025125.7540e02a@scratchpost.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Danny! > please, for existing packages, try to be as clear as possible in the commit > messages in what is changed (only one related set of things should be changed > per commit). > > In this case the commit confounds things: > > * Changing the build-system reference. This does not enable runtime > features--which is what the commit message's topic stated that the commit does. > * Changing the autoconf method. This does not enable runtime features--which > is what the commit message's topic stated that the commit does. > * Adding Python as a NATIVE input. What is that about? Is profanity using > a Python program as a compiler only? > * I think that moving those native-inputs to inputs, while correct, does not > enable runtime features--which is what the commit message's topic stated that > the commit does. > * Please use two spaces (after the period) in order to separate sentences. > * Moving blocks around makes review much harder for users. > > The goal of those commit messages, and of the commit rules, is to make it > easy for each user to see at a glance what topic each commit changes. You are correct. I always do these in a hurry, sorry about that. Please find the attached patches. Regards, RG. From 1c777d5bd598f97bf6978f863d6752e0942ab236 Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Sun, 13 Sep 2020 00:30:10 -0400 Subject: [PATCH 4/4] gnu: profanity: Change build system. * gnu/package/messaging.scm (profanity) [build-system]: Change from gnu to glib-or-gtk. Glib-or-gtk is the appropriate build system, as the package depends on glib and gtk+. --- gnu/packages/messaging.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm index 232d80a5fc..ef553e2acb 100644 --- a/gnu/packages/messaging.scm +++ b/gnu/packages/messaging.scm @@ -1783,7 +1783,7 @@ are both supported).") (sha256 (base32 "00j9l9v62rz9hprgiy1vrz8v3v59ph18h8kskqxr31fgqvjv5xr3")))) - (build-system gnu-build-system) + (build-system glib-or-gtk-build-system) (arguments `(#:configure-flags (list -- 2.28.0