From patchwork Thu Sep 10 15:57:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandros Theodotou X-Patchwork-Id: 23985 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id C4CD227BBE8; Thu, 10 Sep 2020 16:59:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTPS id 5690B27BBE7 for ; Thu, 10 Sep 2020 16:59:09 +0100 (BST) Received: from localhost ([::1]:55582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGOya-0004eS-ID for patchwork@mira.cbaines.net; Thu, 10 Sep 2020 11:59:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGOyU-0004eB-QI for guix-patches@gnu.org; Thu, 10 Sep 2020 11:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57671) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGOyU-0004eg-HU for guix-patches@gnu.org; Thu, 10 Sep 2020 11:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kGOyU-0007HG-G1 for guix-patches@gnu.org; Thu, 10 Sep 2020 11:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42281] [PATCH] gnu: Add python-buku. Resent-From: Alexandros Theodotou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Sep 2020 15:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42281 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 42281@debbugs.gnu.org Received: via spool by 42281-submit@debbugs.gnu.org id=B42281.159975348527899 (code B ref 42281); Thu, 10 Sep 2020 15:59:02 +0000 Received: (at 42281) by debbugs.gnu.org; 10 Sep 2020 15:58:05 +0000 Received: from localhost ([127.0.0.1]:40984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGOxZ-0007Fv-7S for submit@debbugs.gnu.org; Thu, 10 Sep 2020 11:58:05 -0400 Received: from mout02.posteo.de ([185.67.36.142]:51809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kGOxX-0007FR-Ij for 42281@debbugs.gnu.org; Thu, 10 Sep 2020 11:58:04 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 567BB240100 for <42281@debbugs.gnu.org>; Thu, 10 Sep 2020 17:57:57 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4BnNnv4JHCz9rxX; Thu, 10 Sep 2020 17:57:55 +0200 (CEST) Message-ID: From: Alexandros Theodotou Date: Thu, 10 Sep 2020 16:57:53 +0100 In-Reply-To: <878sfdhlc0.fsf@gnu.org> References: <2253d09b2894e2630055161c99db21b334a861b6.camel@zrythm.org> <640185039a38a8f421546d3b8b987f6d4cb4ec59.camel@zrythm.org> <878sfdhlc0.fsf@gnu.org> User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Marius, On Tue, 2020-07-21 at 00:29 +0200, Marius Bakke wrote: > As this seems like a general-purpose tool and not a Python library, > it > would be good to place this elsewhere. I'm not sure where though, > maybe > (gnu packages web)? > > Also I think the 'python-' prefix can be removed. Done. > > + (arguments > > + `(#:tests? #f)) ; needs python-mypy-extensions which fails > > to build > > Actually python-mypy-extensions seems to not be in Guix at all. Can > you > adjust the comment with a TODO? Done. > > > + (propagated-inputs > > + `(("python-html5lib" ,python-html5lib) > > + ("python-urllib3" ,python-urllib3) > > + ("python-beautifulsoup4" ,python-beautifulsoup4) > > + ("python-pytest" ,python-pytest) > > + ("python-pytest-cov" ,python-pytest-cov) > > + ("python-pylint" ,python-pylint) > > + ("python-vcrpy" ,python-vcrpy))) > > These can probably be regular inputs, as python-build-system will > automatically 'wrap' the executables with these on PYTHONPATH. Done. > > > + (home-page "https://github.com/jarun/buku") > > + (synopsis > > + "Bookmark manager") > > + (description > > + "buku is a powerful bookmark manager written in Python3 and > > SQLite3.") > > It's a chore, but it would be great if you could expand on the > description. Something along the lines of "@command{buku} can > auto-import bookmarks from your browser and present them in an > interactive command-line interface that lets you compose and update > bookmarks directly. It can also present them in a web interface with > @command{bukuserver}." Added your proposed text. > Can you send an updated patch? Please find the new patch attached. Thanks, Alex From 217d5661c4d76f79176d947b2376dfa89e5dcc01 Mon Sep 17 00:00:00 2001 From: Alexandros Theodotou Date: Thu, 10 Sep 2020 16:54:52 +0100 Subject: [PATCH] gnu: Add buku. * gnu/packages/web.scm (buku): New variable. --- gnu/packages/web.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm index 2c3a007779..cf4f1ef0b1 100644 --- a/gnu/packages/web.scm +++ b/gnu/packages/web.scm @@ -7424,6 +7424,40 @@ update an existing mirrored site, and resume interrupted downloads. HTTrack is fully configurable, and has an integrated help system.") (license license:gpl3+))) +(define-public buku + (package + (name "buku") + (version "4.4") + (source + (origin + (method url-fetch) + (uri (pypi-uri "buku" version)) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1g1xhdskfn72xaraqzz2v8dl2iza7bzfpn17z2wdrzkq3ih7yvgg")))) + (build-system python-build-system) + (arguments + `(#:tests? #f)) ; TODO needs python-mypy-extensions + (inputs + `(("python-html5lib" ,python-html5lib) + ("python-urllib3" ,python-urllib3) + ("python-beautifulsoup4" ,python-beautifulsoup4) + ("python-pytest" ,python-pytest) + ("python-pytest-cov" ,python-pytest-cov) + ("python-pylint" ,python-pylint) + ("python-vcrpy" ,python-vcrpy))) + (home-page "https://github.com/jarun/buku") + (synopsis + "Bookmark manager") + (description + "buku is a powerful bookmark manager written in Python3 and SQLite3. +@command{buku} can auto-import bookmarks from your browser and present them +in an interactive command-line interface that lets you compose and update +bookmarks directly. It can also present them in a web interface with +@command{bukuserver}.") + (license license:gpl3+))) + (define-public anonip (package (name "anonip") -- 2.27.0