From patchwork Mon Jul 27 07:11:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lars-Dominik Braun X-Patchwork-Id: 23392 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 3F82B27BBE1; Mon, 27 Jul 2020 08:12:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 79F0127BBE3 for ; Mon, 27 Jul 2020 08:12:10 +0100 (BST) Received: from localhost ([::1]:50388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzxIv-00012b-VW for patchwork@mira.cbaines.net; Mon, 27 Jul 2020 03:12:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzxIo-00012U-Q7 for guix-patches@gnu.org; Mon, 27 Jul 2020 03:12:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzxIo-0001M8-8W for guix-patches@gnu.org; Mon, 27 Jul 2020 03:12:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzxIo-00031P-34 for guix-patches@gnu.org; Mon, 27 Jul 2020 03:12:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42306] [PATCH] gnu: Add nfs4-acl-tools Resent-From: Lars-Dominik Braun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 27 Jul 2020 07:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42306 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 42306@debbugs.gnu.org Received: via spool by 42306-submit@debbugs.gnu.org id=B42306.159583391711604 (code B ref 42306); Mon, 27 Jul 2020 07:12:02 +0000 Received: (at 42306) by debbugs.gnu.org; 27 Jul 2020 07:11:57 +0000 Received: from localhost ([127.0.0.1]:53885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzxId-000311-V6 for submit@debbugs.gnu.org; Mon, 27 Jul 2020 03:11:57 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:33961) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzxIZ-00030l-Al for 42306@debbugs.gnu.org; Mon, 27 Jul 2020 03:11:51 -0400 Received: by mail-ej1-f42.google.com with SMTP id y10so15987730eje.1 for <42306@debbugs.gnu.org>; Mon, 27 Jul 2020 00:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leibniz-psychology-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1W71Ik3aR/Pd66zGsuzvBScdIIZ85lix33C5Dxz2IJg=; b=PkPRi/j4DHexY0dbkjb4PQd1hVHw9Y6isIfX/COC/K6h3wV6fMMw7Yq5DG3st5Y3YU ocys1KRqyv9757ns9PdBLU4aDcI8U+xj9sFEL+98fDN7vFzdnAeiNeVY1hJe13ycMOnF fDjUwhjUhQ7ghEt1UcGuKMKB2og/+GxYgkDb+RI9fa62UkWu3Ii1VoBYZcHDiwyr5q2b lNYTI0KEiGBHb5lmD6QV24s/iKFxceswflRB6N0fOhP6fJ9T6TGkDM08WAv0ii24makd odN4IW+v66U7arJklRKDGy5/Yo2clstPhATT12rM0upcnXaunJbpq5eNMWONuqZp2hgM xjcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1W71Ik3aR/Pd66zGsuzvBScdIIZ85lix33C5Dxz2IJg=; b=FKDWNz7/H8fO3F1Omv2Th5LtJoT5NWTJG9QdDFC6+NHtDz5gXC51SIC5YfuPmU8gKx Wi50iADQA6QeZvwU4lr6oF9m33CIjsY/RsJzGNCMEc1/7kHa2J3bVw0vW15YLEE4kPDg L8rbmJdsNuaiCcWVpdyNub9MpG51ymronN/XVkoQI5o5HYBpOFnwKB6+g0+SVByARTMc s/HvMzz5Uz6u49l7O0aDttlK/FskKO5Y3aFw33NlqPt+OZZOLGGzt3lCzRPXq7KEtXI6 EbwdFRQ9+t+ZmWZLd2Ckq+dkI1q55KYPv3PvGjo/lE2nfMTqUSr+YwaCjhN81iM9WISR MXQA== X-Gm-Message-State: AOAM532+69qwHf3DV1XX5Vi9iuLS3ejFRFDwLtj20k6wriEuYAtnA7rF f1sCnbhggfUd46bg4WDE7A3+ASkuoAf/BjliSoQol+4gyKpoV+kHkbv2PTqBpJ+6duLKgTpHqZb IPNHSqjWTRtR9FTGOXUGfgnxA551BNvJwDGgRBGK9CD+ThF1LTboYZWJv3KxGNv6VQC3ggoQUOQ j3Guj/j8pR X-Google-Smtp-Source: ABdhPJxtBNcFQXUFCtjxCazUaq+5RdZbqa79njMeYeNiouBDtjVJx//7p4Mk7W0OjbKQx26Wz7Rk/g== X-Received: by 2002:a17:906:774d:: with SMTP id o13mr19437029ejn.373.1595833901317; Mon, 27 Jul 2020 00:11:41 -0700 (PDT) Received: from localhost (dynamic-2a01-0c23-806b-2300-d1a7-edea-86bc-1290.c23.pool.telefonica.de. [2a01:c23:806b:2300:d1a7:edea:86bc:1290]) by smtp.gmail.com with ESMTPSA id mj22sm6471162ejb.118.2020.07.27.00.11.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2020 00:11:40 -0700 (PDT) Date: Mon, 27 Jul 2020 09:11:39 +0200 From: Lars-Dominik Braun Message-ID: <20200727071139.GB3225@zpidnp36> References: <20200710092101.GA22947@zpidnp36> <87blk3vcyn.fsf@gnu.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87blk3vcyn.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hey Marius, > Sorry for the late reply... no problem. > The patch mostly LGTM, but no longer applies. Can you rebase it on > current master? Meanwhile, a few comments: Sure, see attached patch, which (hopefully) also improves the description. I noticed linting fails with a pattern matching error, because git:// protocol URI’s are not supported. The second patch fixes it, but I’m not sure that’s a “proper” solution. Cheers, Lars From 5c9dddd0d4b54ca73f4fe4ebac37789bde0e54ce Mon Sep 17 00:00:00 2001 From: Lars-Dominik Braun Date: Mon, 27 Jul 2020 09:09:24 +0200 Subject: [PATCH 2/2] =?UTF-8?q?guix:=20lint:=20Ignore=20unsupported=20sour?= =?UTF-8?q?ce=20URL=E2=80=99s.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * guix/lint.scm (check-source): Add match case for #f. --- guix/lint.scm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/guix/lint.scm b/guix/lint.scm index 8a55f3e744..395630aa1c 100644 --- a/guix/lint.scm +++ b/guix/lint.scm @@ -794,6 +794,9 @@ descriptions maintained upstream." (#t ;; We found a working URL, so stop right away. '()) + (#f + ;; Unsupported URL or other error, skip. + (loop rest '())) ((? lint-warning? warning) (loop rest (cons warning warnings)))))))) -- 2.20.1