From patchwork Sat Jul 25 14:57:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "LaFreniere, Joseph" X-Patchwork-Id: 23372 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2878A27BBE1; Sat, 25 Jul 2020 15:59:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 5467027BBE3 for ; Sat, 25 Jul 2020 15:59:08 +0100 (BST) Received: from localhost ([::1]:33744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzLdj-0001o1-T6 for patchwork@mira.cbaines.net; Sat, 25 Jul 2020 10:59:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39720) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzLde-0001nr-NS for guix-patches@gnu.org; Sat, 25 Jul 2020 10:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39238) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzLde-0007BJ-Ey for guix-patches@gnu.org; Sat, 25 Jul 2020 10:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzLde-000344-Ei for guix-patches@gnu.org; Sat, 25 Jul 2020 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42525] [PATCH 1/2] gnu: Add emacs-pretty-hydra. Resent-From: "LaFreniere, Joseph" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 Jul 2020 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42525 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Oleg Pykhalov Cc: Joseph LaFreniere , 42525@debbugs.gnu.org Received: via spool by 42525-submit@debbugs.gnu.org id=B42525.159568908511711 (code B ref 42525); Sat, 25 Jul 2020 14:59:02 +0000 Received: (at 42525) by debbugs.gnu.org; 25 Jul 2020 14:58:05 +0000 Received: from localhost ([127.0.0.1]:50784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLcj-00032p-8c for submit@debbugs.gnu.org; Sat, 25 Jul 2020 10:58:05 -0400 Received: from mx.kolabnow.com ([95.128.36.41]:16136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzLcg-00032B-RD for 42525@debbugs.gnu.org; Sat, 25 Jul 2020 10:58:03 -0400 Received: from localhost (unknown [127.0.0.1]) by ext-mx-out001.mykolab.com (Postfix) with ESMTP id 5ED1AC4A; Sat, 25 Jul 2020 16:57:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kolabnow.com; h= content-type:content-type:mime-version:message-id:date:date :in-reply-to:subject:subject:from:from:references:received :received:received; s=dkim20160331; t=1595689075; x=1597503476; bh=aDBvDR1qhIQJFX0Lcv+TN6sVwBHD3od6Sl9RIT5DR4o=; b=vFZMkPNGV22B tMU7KAJ7bY9kOOX7X8rfH6Sd0ScLXJxbXKsFkyFLpBCmedgq81S3tiChISLZ/4Nu JNnY0mywb7F99LST9prhtB+unT14N8VOECC1lPXohl3uoXpPYGUSEpT7eZ27CLrt CA4ajOcJFE56p+6173zBiICtWzS7uTYHMLJzesy0iL6DZqwc0nhVCLPRNOQtLTuW Yi8FnAxKVK02963sycrWcyeoJ/ZmwkEmjnzql546YI0zEYk0+zWYabWPFyrJmdUq QrZf9Mxx0uoX7/dg6H4l+Je5S86LJWtavu/uew6grDCitE4kkeNyZviexufJIBbt 22TEiZdbHLS7oncxe1rpFhNNyUc7asOJ3wkdwsvAkjuv4gV1PQxoDqUvk3oN3L1V Hu07fe3JADPEdFKEPiukYq+DxT01VuG8JDv6Ayt8N8uHFjJdWpQFPJRgRWeIrQiM JgiUR+3pQXD6hpMvzLtNbQjJ4Kt/w2M3mszsxs9ocvvCuyPWTX/TTAN5Zym31Ly0 7gL7e/deYr5tZNpNayF4/si5UTaFzzVWVYSf7X6/oM8XrwSsqKrixsaYaUrsS/av HkAnnAQUahCySi3zQ3ToQTpoHSZlK0LvseDAKd684uUp9SzS2l86ctYimKllPudw akkhnY4uadAiyWA+0/1saHBDHpJ7uXI= X-Virus-Scanned: amavisd-new at mykolab.com Received: from mx.kolabnow.com ([127.0.0.1]) by localhost (ext-mx-out001.mykolab.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hDseqe3xMeCV; Sat, 25 Jul 2020 16:57:55 +0200 (CEST) Received: from int-mx003.mykolab.com (unknown [10.9.13.3]) by ext-mx-out001.mykolab.com (Postfix) with ESMTPS id CAC23443; Sat, 25 Jul 2020 16:57:54 +0200 (CEST) Received: from ext-subm001.mykolab.com (unknown [10.9.6.1]) by int-mx003.mykolab.com (Postfix) with ESMTPS id 74866B86; Sat, 25 Jul 2020 16:57:54 +0200 (CEST) References: <87o8o4gxk9.fsf@odyssey.lafreniere.xyz> <871rkzn32e.fsf@gmail.com> From: "LaFreniere, Joseph" In-reply-to: <871rkzn32e.fsf@gmail.com> Date: Sat, 25 Jul 2020 09:57:45 -0500 Message-ID: <87tuxvskuu.fsf@odyssey.lafreniere.xyz> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Oleg Pykhalov writes: > Joseph LaFreniere writes: > >> Patch file is attached. Note that `guix lint` reports "the >> source file name >> should contain the package name"; I'm not sure how to resolve >> that. > > You could fix this by providing a ‘(file-name (git-file-name > name > version))’ as in other Emacs packages. Thanks. Not sure how I missed that. > 'emacs-build-system' handles '*.el' files, unless you exclude > them with > the recipe bellow. :-) Thank you for the tip. I have changed the include to an exclude. > Also could you take a look on running a test suite? The repo's test suite tests both pretty-hydra and major-mode-hydra. Since major-mode-hydra is inheriting from and depends on this recipe, I'm assuming it would be rebuilt any time the pretty-hydra recipe changes. Just to minimize the amount of work prying apart the repository I have left all of the tests to be run in the recipe for major-mode-hydra. The updated patch for that will be following shortly. --- Joseph LaFreniere From a08a763c0a7aa09349bdc9e65ac2d27a3c640a54 Mon Sep 17 00:00:00 2001 From: Joseph LaFreniere Date: Sat, 18 Jul 2020 12:49:15 -0500 Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra. * gnu/packages/emacs-xyz.scm (emacs-pretty-hydra): New variable. --- gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index db395361b9..c11959dbe2 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -649,6 +649,33 @@ process, passing on the arguments as command line arguments.") "Magit-annex adds a few git-annex operations to the Magit interface.") (license license:gpl3+)))) +(define-public emacs-pretty-hydra + (package + (name "emacs-pretty-hydra") + (version "0.2.2") + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/jerrypnz/major-mode-hydra.el") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 "08a15knkdq35pzjq82imff016fbfdib5q4glg2xmdy2b5fnk7jqa")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-dash" ,emacs-dash) + ("emacs-hydra" ,emacs-hydra) + ("emacs-s" ,emacs-s))) + (arguments + `(#:exclude (cons "^major-mode-hydra\\.el" %default-exclude))) + (home-page "https://github.com/jerrypnz/major-mode-hydra.el") + (synopsis "Create nice-looking hydras") + (description + "This package provides the macro @code{pretty-hydra-define} to define +hydras with one column per group of heads.") + (license license:gpl3+))) + (define-public emacs-minions (package (name "emacs-minions") -- 2.27.0