From patchwork Fri Jul 10 21:46:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ivan Kozlov X-Patchwork-Id: 23166 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D12CE27BBE1; Fri, 10 Jul 2020 22:47:10 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 0023227BBE3 for ; Fri, 10 Jul 2020 22:47:09 +0100 (BST) Received: from localhost ([::1]:43842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ju0rM-0005Pg-IW for patchwork@mira.cbaines.net; Fri, 10 Jul 2020 17:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ju0rG-0005PY-5d for guix-patches@gnu.org; Fri, 10 Jul 2020 17:47:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ju0rF-0005T3-SD for guix-patches@gnu.org; Fri, 10 Jul 2020 17:47:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ju0rF-0000CY-Qq for guix-patches@gnu.org; Fri, 10 Jul 2020 17:47:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#42302] [PATCH] gnu: Add xssproxy Resent-From: Ivan Kozlov Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 10 Jul 2020 21:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42302 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Cc: "42302@debbugs.gnu.org" <42302@debbugs.gnu.org> Received: via spool by 42302-submit@debbugs.gnu.org id=B42302.1594417615760 (code B ref 42302); Fri, 10 Jul 2020 21:47:01 +0000 Received: (at 42302) by debbugs.gnu.org; 10 Jul 2020 21:46:55 +0000 Received: from localhost ([127.0.0.1]:43595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ju0r5-0000C9-Ml for submit@debbugs.gnu.org; Fri, 10 Jul 2020 17:46:55 -0400 Received: from forward501p.mail.yandex.net ([77.88.28.111]:58105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ju0r2-0000Bu-7w for 42302@debbugs.gnu.org; Fri, 10 Jul 2020 17:46:50 -0400 Received: from mxback4q.mail.yandex.net (mxback4q.mail.yandex.net [IPv6:2a02:6b8:c0e:6d:0:640:ed15:d2bd]) by forward501p.mail.yandex.net (Yandex) with ESMTP id 7D5143500532; Sat, 11 Jul 2020 00:46:41 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback4q.mail.yandex.net (mxback/Yandex) with ESMTP id eJmpg9yhcf-keK8at5t; Sat, 11 Jul 2020 00:46:41 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1594417601; bh=V5+93kDPXx9mBNz0bnscCXGupJUbl0B5QyHSmJWC0X4=; h=Message-Id:Cc:Subject:In-Reply-To:Date:References:To:From; b=X2cNkrpZtsb14WUuNGE5TwDxKqKzbUGyH4RLlzW+LyLtQwGhGS2/elk9oPwin5BP+ g5KFEUaRwX8VHZw2iaEQWa6fV7uhp0QNu7Vtkv/R1F/Butd0yzZcfDqiHvs7y51Np6 RJeVRRs7DcFmOtJK4mKUhFb+KVsObLOc3LrTpbuk= Authentication-Results: mxback4q.mail.yandex.net; dkim=pass header.i=@yandex.ru Received: by vla3-6a5326aeb4ee.qloud-c.yandex.net with HTTP; Sat, 11 Jul 2020 00:46:40 +0300 From: Ivan Kozlov In-Reply-To: <87d053yu2e.fsf@gnu.org> References: <173331594355886@mail.yandex.ru> <87d053yu2e.fsf@gnu.org> MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Sat, 11 Jul 2020 00:46:40 +0300 Message-Id: <378541594414408@mail.yandex.ru> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello, Thanks for the corrections. >Note: you don’t need to provide a description of the package in >the commit log. It was a clarification for guix-patches readers. I hadn’t thought about ‘git am’ and the like and I’ll write such things as email replies in the future. 10.07.2020, 23:49, "Ludovic Courtès" : > Hi, > > Ivan Kozlov skribis: > >>  xssproxy is a tiny daemon that provides an Idle Inhibition Service specification conformant D-Bus interface to libXss. It allows programs that support only this interface (like older Firefox and IceCat) to inhibit screen locking or blanking on systems without a conformant screen locker program. >> >>  * gnu/packages/xdisorg.scm (xssproxy): New variable. > > Nice! Note: you don’t need to provide a description of the package in > the commit log. > > Overall the patch looks good to me, modulo minor issues reported by > ‘guix lint’ (see below for how to address them): > > --8<---------------cut here---------------start------------->8--- > gnu/packages/xdisorg.scm:1384:12: xssproxy@1.0.0: 'pkg-config' should probably be a native input > gnu/packages/xdisorg.scm:1368:12: xssproxy@1.0.0: the source file name should contain the package name > gnu/packages/xdisorg.scm:1368:12: xssproxy@1.0.0: the source URI should not be an autogenerated tarball > --8<---------------cut here---------------end--------------->8--- > >>  +(define xssproxy > > Use ‘define-public’ instead. > >>  + (source (origin >>  + (method url-fetch) >>  + (uri (string-append "https://github.com/timakro/xssproxy/archive/v" >>  + version >>  + ".tar.gz")) > > Use ’git-fetch’ instead of ‘url-fetch’ to fetch the source over Git > instead of an autogenerated tarball, and add a ‘file-name’ field. > >>  + (synopsis "Forward freedesktop.org Idle Inhibition Service calls to Xss") >>  + (description "xssproxy implements the org.freedesktop.ScreenSaver D-Bus interface >>  +described in the Idle Inhibition Service Draft by the freedesktop.org developers. >>  +The inhibition of the screensaver is then controlled using the XScreenSaverSuspend >>  +function from the Xss (X11 Screen Saver extension) library.") > > You can use markup for clarity, for instance > @code{org.freedesktop.ScreenSaver}. > > Could you send an updated patch? > > Thank you! > > Ludo’. diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm index cec9bf0799..f4d77a5338 100644 --- a/gnu/packages/xdisorg.scm +++ b/gnu/packages/xdisorg.scm @@ -37,6 +37,7 @@ ;;; Copyright © 2020 John Soo ;;; Copyright © 2020 Boris A. Dekshteyn ;;; Copyright © 2020 Alex McGrath +;;; Copyright © 2020 Ivan Kozlov ;;; ;;; This file is part of GNU Guix. ;;; @@ -1360,6 +1361,43 @@ demos. It also acts as a nice screen locker.") "http://metadata.ftp-master.debian.org/changelogs/" "/main/x/xscreensaver/xscreensaver_5.36-1_copyright"))))) +(define-public xssproxy + (package + (name "xssproxy") + (version "1.0.0") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/timakro/xssproxy.git") + (commit (string-append "v" version)))) + (file-name (string-append name "-" version "-checkout")) + (sha256 + (base32 + "0c83wmipnsdnbihc5niyczs7jrkss2s8n6iwwjdia7hkjzbd0hl7")))) + (build-system gnu-build-system) + (arguments `(#:make-flags `("bindir=/bin" + "man1dir=/share/man/man1" + ,(string-append "DESTDIR=" (assoc-ref %outputs "out")) + "CC=gcc") + #:phases (modify-phases %standard-phases + (delete 'configure) + (delete 'check)))) + (native-inputs + `(("pkg-config" ,pkg-config))) + (inputs + `(("glib" ,glib) + ("libx11" ,libx11) + ("libxext" ,libxext) + ("libxscrnsaver" ,libxscrnsaver) + ("dbus" ,dbus))) + (synopsis "Forward freedesktop.org Idle Inhibition Service calls to Xss") + (description "xssproxy implements the @code{org.freedesktop.ScreenSaver} D-Bus interface +described in the Idle Inhibition Service Draft by the freedesktop.org developers. +The inhibition of the screensaver is then controlled using the XScreenSaverSuspend +function from the Xss (X11 Screen Saver extension) library.") + (home-page "https://github.com/timakro/xssproxy") + (license license:gpl3+))) + (define-public xsel (package (name "xsel")