From patchwork Tue Jan 22 23:10:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Dr. Arne Babenhauserheide" X-Patchwork-Id: 791 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id D5EF616A87; Tue, 22 Jan 2019 23:23:26 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 61E6D16A85 for ; Tue, 22 Jan 2019 23:23:26 +0000 (GMT) Received: from localhost ([127.0.0.1]:52110 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm5O9-0003jG-Ay for patchwork@mira.cbaines.net; Tue, 22 Jan 2019 18:23:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gm5M1-00023x-B5 for guix-patches@gnu.org; Tue, 22 Jan 2019 18:21:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gm5CB-0007MG-CU for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42497) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gm5CA-0007Lt-FW for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gm5CA-0008G1-6R for guix-patches@gnu.org; Tue, 22 Jan 2019 18:11:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#34128] [PATCH] add emacs built with xwidgets-support Resent-From: Arne Babenhauserheide Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 22 Jan 2019 23:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34128 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?utf-8?q?Court=C3=A8s?= Received: via spool by 34128-submit@debbugs.gnu.org id=B34128.154819865831731 (code B ref 34128); Tue, 22 Jan 2019 23:11:02 +0000 Received: (at 34128) by debbugs.gnu.org; 22 Jan 2019 23:10:58 +0000 Received: from localhost ([127.0.0.1]:41778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm5C6-0008Fi-2p for submit@debbugs.gnu.org; Tue, 22 Jan 2019 18:10:58 -0500 Received: from mout.web.de ([217.72.192.78]:47409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gm5C3-0008FV-D5 for 34128@debbugs.gnu.org; Tue, 22 Jan 2019 18:10:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1548198645; bh=wEfPomL52BRchkQDYA5Gxq1KD8a+nTpY1P0Q5OlUIeQ=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=A5KyBhYIeaLOX8PZghZwrk0QW+x0170RlZOxX5a8Z9WiJAujBhQkJnMteapREqjLa B/N45IsKax7b7hKjAfm7l9ZBvwdH3KMYmA8UYI/2+Pno4/+6yJJiTV1tOU7JN+YvIj Y8lVOhay9xXORu1d7b0Smh03jKNO0Yqxnzz4lwtY= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from fluss ([80.136.18.3]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M09dQ-1h4j0L2GEu-00uLrc; Wed, 23 Jan 2019 00:10:45 +0100 References: <87zhrx4mlu.fsf@web.de> <87lg3cjrdh.fsf@gnu.org> User-agent: mu4e 1.0; emacs 26.1 From: Arne Babenhauserheide In-reply-to: <87lg3cjrdh.fsf@gnu.org> Date: Wed, 23 Jan 2019 00:10:41 +0100 Message-ID: <877eew70ge.fsf@web.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:UyeZ7ptm5GVHtdo5Mk/l7yAlJQM4psPocVuVKJSSx9r/IO+dHgY Qo3Z34I1P1OWS20fEXGdkiDoYwgPtT6AxzohHPDAMxEd6X3OynXK6fbTXshCEXY5V8wLhZA cYXlb9onBRkryiSP7uA3tXzaFE3g4TEuA49iPS1h5Z3CNkMqLN/ri0mTTmzzFKw6DutkoRk bx3Sl5yOHjkQ/RvlUZjsA== X-UI-Out-Filterresults: notjunk:1;V03:K0:G9EGj8z0g+I=:BeDN9zmdlbwz13nHm9pXXg tU0JHPm6RB2E+nGnXJxmfPFTzNk9ADgu6LbULKaj4hoNTdkU69nOcRCTnm0jmfy3uGzYiIwiy K+dPoyJYNDKPPf8XFD34ZlzUF+YXTHvq7lsXU2nK5bsPymHg/gtUvZS9HBpgjrDdD5VTmphb0 7cGTUFWKxgdwOm63xv9BHUPnNV2RFBnSRsjHGJPZMVYzey6rdxrc9KvHtSExGER52DDUabhxD NEkWuyy0N76SH9mtpockkeZXOY+tP+wzKKREekb0bJvT1ctKl23K1D1tE6Dcy3Hag1lSUlpSU f96/LhZq127gGT6xKh1pLm5f/CCVHQNa4H92ci45gLGsdJTB3MfGXiPqpL+j0UE1JlH2jA3YF fybFF3adgdb7GsUfdG+TO3HCubvJPyOWcBKW/QN9UC5UxcO3V7AW+4BNyIWV4zo7bqRN/mSp1 Fn9wEEtwBN3NZma68pYaZDIcChy3ryZUNdX0QWen1q2SPhxkh63p2tPxWnRfyDpKeHrlIsAfy jKNzNY18lav92HSz2Bidi5wv+x42QF9ecA6D2uZMqBxT6KsX5aB4JFQnvP+UWuO6K+VLBqy4G iKlbNkfQL4K3MonwzFgRwt1qqNH6Y2+cjzjbYU2uvtDURCUnxLnLOl55kF1zU7DQHcnn0RsDU 3idEKyzcfwWSG4BwV6reBdyjhDeMeLGxnI9QZP1S5Tmbyd6V9ShwK2p96BQG+X8t7+8snkDAx 9nxdQbjCGnNbyLj6Bb8cxYA55x5N/TOEeKWMUnC17lyB2Kr6BlxB3s/+4rt3SYBGGg7ZrEYC3 C/4pxUEXSemylMDE26FkZA9bND42bHuCqswcZI8kSaJ53u/kxTocuIdMAlYkf7EyXaeIELDoD unEMc5LOCp8Fut/U2mmdLZJREdhHkukGDiSN6/HUsDWK24rue7IhZ1RxbGxvT0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 34128@debbugs.gnu.org Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Ludovic, > Thanks for the patch! Thank you for your review! > I wonder why this hadn’t been done before; > Nicolas, Alex, Pierre, thoughts? There is an older bug with xwidgets support which had problems because it depended on an old version of webkitgtk (I only found it after I sent the patch). Maybe that stopped others from submitting. Ludovic Courtès writes: > The patch LGTM, minor stylistic issues: > … > Please indent rather along these lines (like in the rest of the file): > > (define-public emacs-xwidgets > (package > (inherit emacs) > (name …) …)) > > Likewise, for consistency, use unquote-splicing rather than ‘append’: > > (inputs `(("webkitgtk" ,webkitgtk) > ;; … > ,@(package-inputs emacs))) > > Could you send an updated patch? Is inline here OK? If yes: From ed2eca1ade73eb6b7c2e8b17541e3e182ade4608 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Fri, 18 Jan 2019 23:29:14 +0100 Subject: [PATCH] add emacs built with xwidgets-support * gnu/packages/emacs.scm (emacs-xwidgets): new variable --- gnu/packages/emacs.scm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm index a488289f1..7e8dcadf9 100644 --- a/gnu/packages/emacs.scm +++ b/gnu/packages/emacs.scm @@ -59,6 +59,7 @@ #:use-module (gnu packages pkg-config) #:use-module (gnu packages texinfo) #:use-module (gnu packages tls) + #:use-module (gnu packages webkit) #:use-module (gnu packages xml) #:use-module (gnu packages xorg) #:use-module (guix utils) @@ -210,6 +211,22 @@ languages.") (native-inputs `(("pkg-config" ,pkg-config))))) +(define-public emacs-xwidgets + (package + (inherit emacs) + (name "emacs-xwidgets") + (synopsis "The extensible, customizable, self-documenting text +editor (with xwidgets support)") + (build-system gnu-build-system) + (arguments + `(#:configure-flags + '("--with-xwidgets") + ,@(package-arguments emacs))) + (inputs + `(("webkitgtk" ,webkitgtk) + ("libxcomposite" ,libxcomposite) + ,@(package-inputs emacs))))) + (define-public emacs-no-x (package (inherit emacs) (name "emacs-no-x")