From patchwork Sun May 17 13:18:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "ashish.is--- via Guix-patches\" via" X-Patchwork-Id: 22126 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 77EB927BBE5; Sun, 17 May 2020 14:19:14 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 75FE327BBE3 for ; Sun, 17 May 2020 14:19:13 +0100 (BST) Received: from localhost ([::1]:41120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jaJCC-0006CZ-NI for patchwork@mira.cbaines.net; Sun, 17 May 2020 09:19:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jaJC2-0006CQ-M6 for guix-patches@gnu.org; Sun, 17 May 2020 09:19:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jaJC2-0000d7-DU for guix-patches@gnu.org; Sun, 17 May 2020 09:19:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jaJC2-0007RL-9n for guix-patches@gnu.org; Sun, 17 May 2020 09:19:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41181] adds emacs-interleave Resent-From: rdes Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 17 May 2020 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 41181@debbugs.gnu.org X-Debbugs-Original-Cc: "41181@debbugs.gnu.org" <41181@debbugs.gnu.org>, rdes via Guix-patches via Received: via spool by 41181-submit@debbugs.gnu.org id=B41181.158972154028583 (code B ref 41181); Sun, 17 May 2020 13:19:02 +0000 Received: (at 41181) by debbugs.gnu.org; 17 May 2020 13:19:00 +0000 Received: from localhost ([127.0.0.1]:42614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBu-0007Qn-BF for submit@debbugs.gnu.org; Sun, 17 May 2020 09:19:00 -0400 Received: from mail-40132.protonmail.ch ([185.70.40.132]:15390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jaJBe-0007Pr-Mj for 41181@debbugs.gnu.org; Sun, 17 May 2020 09:18:46 -0400 Date: Sun, 17 May 2020 13:18:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail; t=1589721512; bh=NMiamffFGWk62jFDyeMAkSlW424OjZWgxB5y71kYAz0=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=NXVZhO6beNiXlxLLJBpMvTCBnp4ooiKVn+JyhzIfU/8/n5d3q9m6H//ZcXHRZHq3L zFangAkKdppO7wxQopyrGJlnbK1XZsdEpTPoio24FQtAJw036arIi3f/jVSX+rNzIw Gr3dM8LaAbSdwel/JrSlvOvJ9ewc7+BEyyqxKHLI= Message-ID: <6rxX0vh7GxY4H7d6jXP10G8cqsh8_bs8V4e2JxatbfkiLwsC685g0wInwQSxzRpwsOfhm5aVovpD5lOd55GcNAXVlNGfXu1CYq4ym84-M5c=@protonmail.com> In-Reply-To: <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> References: <875zd3x7z2.fsf@nicolasgoaziou.fr> <-nBsa1KQJSwbENQmZILkCluHwqx_QyjF3PQxKtoNHoOeqeFc1FHy95KjjodciPwOSIH5XOxKIhoHv0Hzb87JVOVy3D1fEb1nD9fDidbeMiU=@protonmail.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" Reply-to: rdes , rdes via Guix-patches X-Patchwork-Original-From: rdes via Guix-patches via From: "ashish.is--- via Guix-patches\" via" X-getmail-retrieved-from-mailbox: Patches Hello, Attached is the copyright line that should have been in the previous patch. Ryan Sent with ProtonMail Secure Email. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ On Friday, May 15, 2020 4:56 PM, rdes wrote: > Hello Nicolas, > > Thanks for the pointers. Attached is an updated patch. > > Ryan > > Sent with ProtonMail Secure Email. > > ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐ > On Monday, May 11, 2020 3:10 AM, Nicolas Goaziou mail@nicolasgoaziou.fr wrote: > > > Hello, > > rdes via Guix-patches via guix-patches@gnu.org writes: > > > > > The attached patch adds the emacs-interleave package. > > > > Thank you! Some comments follow. > > > > > Subject: [PATCH] gnu: Add emacs-interleave > > > > Your commit message should conform to Guix rules. Here, you need to add > > > > - gnu/packages/emacs-xyz.scm (emacs-interleave): New variable. > > > > > +(define-public emacs-interleave > > > +(package > > > > Indentation seems wrong. > > > > > - (name "emacs-interleave") > > > > > > - (version "20191129.958") > > > > > > - (source > > > > > > - (origin > > > > > > - (method url-fetch) > > > > > > > > > - (uri (string-append > > > > > > > > > - "https://melpa.org/packages/interleave-" > > > > > > > > > - version > > > > > > > > > - ".el")) > > > > > > > > > > We do not use MELPA sources. Instead, you could use `git-fetch' and > > extract the latest stable release from here: > > https://github.com/rudolfochrist/interleave/releases > > > > > - (sha256 > > > > > > > > > - (base32 > > > > > > > > > - "0y183ggfmkjjywbcqgyinmr21hsg2vaw4d52bg1gsxbp673za2m8")))) > > > > > > > > > > Nitpick: could you move the string on the same line as `base32'? > > > > > - (build-system emacs-build-system) > > > - (home-page > > > - "https://github.com/rudolfochrist/interleave") > > > > Ditto. Could you move the string on the line above? > > > > > - (synopsis "Interleaving text books since 2015") > > > > I think this synopsis needs to be reworded. As it is, it may not be > > useful. > > > > > - (description > > > - "Interleave presents your PDF side by side to an [[http://orgmode.org][Org Mode]] > > > > Description uses Texinfo syntax, not Org syntax. In this case, however, > > I think "side by side to an Org buffer" is sufficient. > > > > > +buffer with your notes, narrowing down to just those passages that are relevant to > > > +the particular page in the document viewer. > > > +") > > > > You don't need to end the description with a final newline. It would be > > nice to expound it a bit. For example, it could be interesting to know > > this is a minor mode. > > Don't forget to add a copyright line with your name at the top of the file. > > Could you send an updated patch? > > Regards, > > > > Nicolas Goaziou From 7cc8535fb92e5d39276ec5cdd5bc078d3d8c55b6 Mon Sep 17 00:00:00 2001 From: Ryan Desfosses Date: Sun, 17 May 2020 09:15:46 -0400 Subject: [PATCH] * gnu/packages/emacs-xyz.scm: Add copyright. --- gnu/packages/emacs-xyz.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index b70b9fffb8..5d0beeb2d9 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -70,6 +70,7 @@ ;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero ;;; Copyright © 2020 Marius Bakke ;;; Copyright © 2020 pinoaffe +;;; Copyright © 2020 Ryan Desfosses ;;; ;;; This file is part of GNU Guix. ;;; -- 2.26.2