From patchwork Mon May 11 05:32:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghav Gururajan X-Patchwork-Id: 21989 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id F391C27BBE3; Mon, 11 May 2020 06:33:08 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 8646A27BBE1 for ; Mon, 11 May 2020 06:33:08 +0100 (BST) Received: from localhost ([::1]:44384 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jY13s-0006QN-2M for patchwork@mira.cbaines.net; Mon, 11 May 2020 01:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52942) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jY13m-0006QB-3b for guix-patches@gnu.org; Mon, 11 May 2020 01:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39439) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jY13l-0006X7-Qm for guix-patches@gnu.org; Mon, 11 May 2020 01:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jY13l-0001qa-M9 for guix-patches@gnu.org; Mon, 11 May 2020 01:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40708] gnu: font-gnu-unifont: Unify outputs for fonts. Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 May 2020 05:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40708 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Leo Famulari Cc: 40708@debbugs.gnu.org Received: via spool by 40708-submit@debbugs.gnu.org id=B40708.15891751727081 (code B ref 40708); Mon, 11 May 2020 05:33:01 +0000 Received: (at 40708) by debbugs.gnu.org; 11 May 2020 05:32:52 +0000 Received: from localhost ([127.0.0.1]:50985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY13c-0001q8-ER for submit@debbugs.gnu.org; Mon, 11 May 2020 01:32:52 -0400 Received: from knopi.disroot.org ([178.21.23.139]:60512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jY13a-0001py-7V for 40708@debbugs.gnu.org; Mon, 11 May 2020 01:32:51 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5997D21AD9; Mon, 11 May 2020 07:32:48 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oMMBxEtOb042; Mon, 11 May 2020 07:32:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1589175165; bh=8QycvjIAXo3cwiCol4GaazlrUizGWJeEPPhPdfEliRk=; h=Subject:From:To:Cc:References:Date:In-Reply-To; b=l232Pv33tcblda/SVm+hhNsy2LJpn149TFUCygOJ0vcZlCA/qtIZmLY0ztEAhv+T1 izqaLbANyEdGTeQ5xK/9FNTfG/iF9SthI5XyVyK28ha6iElZzoWSNpwyC+eoRO8XnO 57Yr1Hr0dZGtCEECCPE7b9rRRyayzSAsjqrtJ5KNousuNiPzRmjv4loRwQbApvCHpP OHgL4422NdWyiiRuRzcnuTj+ogWTtOjQeeZOI5pYHvxBmRHgdObWcWt/QAkV/oi2ws TuWbGXOjswqB+PRxNKxZL3/N7z7UXnPskaIjbZUlRjkPEx06nHgfpfsiL8FZpVN0n7 IAo3bQkCD6ouw== From: Raghav Gururajan References: <20200419012441.62891acb.raghavgururajan@disroot.org> <20200423023022.GA10882@jasmine.lan> <20200422224409.22805bb0.raghavgururajan@disroot.org> <20200423160538.GA29046@jasmine.lan> <4f1c21b4-b3f2-b8e0-a434-26a5c1b8d0de@disroot.org> Autocrypt: addr=raghavgururajan@disroot.org; keydata= mQENBF6yxWcBCAClEApjrOYs8fSzDl8GBwMFtUzF6VCOVrWaGun1vvPDvk4AFzbB3ZV6+Jn8 VfEuqh3OOvSJGHL2cJoR28Q5gVqeOwupyaMWVdEt6TmDrHISyxriF426KVaJnklfMjYwIi0l /7j8bs3pDRyyR6uFrY6sYL9t6HFvevtt7NwgWL1MAEVy6txKkriyrK1h+qc13wRRgVx3tzl7 dNwYEDWd3yUDn+LESoDOlawJ7TQbO8d1K4FFHaqwyQ/SyaIfLBnMAz9Qd18MUWpDkktLh/9u jRfctouFx5BUr+uGgCHAWcII5D60lt867y5m6vp3Ua75TkVQrYTt7KSF/wm7NZ7L02fTABEB AAG0M1JhZ2hhdiBHdXJ1cmFqYW4gKFJHKSA8cmFnaGF2Z3VydXJhamFuQGRpc3Jvb3Qub3Jn PokBTgQTAQgAOBYhBCdBLzSqkY3qQNKUKK5u8wRtb3tXBQJetePbAhsDBQsJCAcCBhUKCQgL AgQWAgMBAh4BAheAAAoJEK5u8wRtb3tXvWIH/3NiwaJfcrOoO/r4/reE0PmfgVWRpWP8uhdy ZiuBmcnyltxSmxZ1drlWpnbap5P7ssVyIlY6SrLTAeN7R0S70HAINkn7XvKpWajHShX0MR4b NeqjETNZg7gh2PTg6zfTnYD1UQqdNxnPMiJTSBZBLCAm/LhdEuigt559uoDA9ZEVLR5ycKh+ ny94NLUhmuRXpH/sb6Ey0FKmdMc47KNnkGQaySeGY88RwONgfv3/rriNbOJ1t12d2qsqkiOo znuxg5O3nT6obd7hCuq+EYwjzwSVrUZuMelO32UE4d2iePhiPBfiprVCNDGPFztJTe0Y+OQA ajj23CBgGIap/L1CpZ25AQ0EXrLFZwEIANGMTVaAiSGtpAbxRo9AHOc2kgatkAsH/ejtzNH0 mtGwtE0g5Gh0OKTI678KItanztmukKcZmBngPCwvUGGNQYzWWwsS+kBti5wJ3OForg+JtYuf /n9DjSAhnb7h1piL9Xi0drULl5ovVFRp/IPldkbT3R8pgc9VwAa0VVRP59dsgF6nPhoHjxfB p/XcA2QRnRfB2bN4BVCValJelPGYR0pSwkftFpmha4FRa0LrJtcMeh+PG20asPiKcE4sNGZT mH3keHkTfk5Tuds3ly5vlqmEKg7qY/zoS1yWQJj0j36JoX1/ravo+gUxszig80140a5bF2VU ERLcKO+Cp0lI4/8AEQEAAYkBNgQYAQgAIBYhBCdBLzSqkY3qQNKUKK5u8wRtb3tXBQJessVn AhsMAAoJEK5u8wRtb3tXqTIH/A9z70HLCZcAfnpluGj4APfi3haqdU7xvtrkN9eHJoPV7pwx y1luNRR8xg7YHkwcQ/9qEcvSicNIvhjRw5cSpyW9HGmOFyiZ7+KLf3XPUjC7pC5pIM+AAWyy D5GlyqakH1wBe8RC9/8vNyfZnmbV4PUvHoHvY/xZH+D/Afg1J2igdIebkQzzhFBC65TAKFeM NIWQkYIMKjq4u+nmv3sreqvRvlt8VYq0VSq24SFs0JJ+dEmuO3/s72122JIL0XEUS3ooGb/p 678RM2OpelLZcZSPG6vIIrQFKw6/NVjDtOY3DrNPtQ+h84UnFPUtaZyvQQwpGNjvtNzU/Ym+ NwsFm0Q= Message-ID: Date: Mon, 11 May 2020 01:32:21 -0400 Mime-Version: 1.0 In-Reply-To: <4f1c21b4-b3f2-b8e0-a434-26a5c1b8d0de@disroot.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Leo! > Sorry for the delayed response. > >> Unifont provides TrueType, PCF, and PSF. It does not have OTF fonts. > > That's correct. I was suggesting a scenario of using more than one type. :-) > >> Currently, if a user installs 'font-gnu-unifont' they get TrueType >> fonts. >> >> On the other hand, the PSF fonts can be used in the bootloader and the >> Linux console, and they are only 68 kilobytes, rather than ~22 megabytes >> if you combine all the font outputs. I don't see a compelling reason for >> that increase. > > OK. I think of two reasons: 1) If one installs this package with > suggested patch, the user can use unifont for any purpose as they wish. > It may be application (ttf), console/grub (psf) and/or display server > (pcf). 2) The setup will be consistent with other font packages, where > the package installs fonts with all the types it can provide. > >> If the problem is that packages with multiple outputs are confusing, we >> should try to improve the UI, and we shouldn't use multiple outputs if >> there isn't a good reason. But this is a case where I think it makes >> sense. > > Improving UI would be good too. Regarding multiple outputs, I think it > is good enough to separate libs, bins and docs. In this packages, we > already separated bin and fonts. I suggest that we shall not separate > fonts further into it's subtypes. That is all I ask. :-) I have attached revised patch with this email. :-) Regards, RG. From 70037b0f0f640c64aa2323a0bc8ba85a17c5559e Mon Sep 17 00:00:00 2001 From: Raghav Gururajan Date: Mon, 11 May 2020 01:26:43 -0400 Subject: [PATCH] gnu: font-gnu-unifont: Unify outputs for fonts. * gnu/package/fonts.scm (font-gnu-unifont): Combine font types. [arguments]<'install>: Change outputs for pcf and psf to "out". --- gnu/packages/fonts.scm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm index 6e9b080299..a79bdf72a6 100644 --- a/gnu/packages/fonts.scm +++ b/gnu/packages/fonts.scm @@ -689,9 +689,7 @@ for use at smaller text sizes"))) (sha256 (base32 "1svzm3xahb2m8r79ha9gb1z3zlckykx9d87cghswj7dxn9868j4b")))) (build-system gnu-build-system) - (outputs '("out" ; TrueType version - "pcf" ; PCF (bitmap) version - "psf" ; PSF (console) version + (outputs '("out" ; Fonts "bin")) ; Utilities to manipulate '.hex' format (arguments '(#:tests? #f ; no check target @@ -705,10 +703,10 @@ for use at smaller text sizes"))) (lambda* (#:key outputs #:allow-other-keys) (let* ((ttf (string-append (assoc-ref outputs "out") "/share/fonts/truetype")) - (pcf (string-append (assoc-ref outputs "pcf") - "/share/fonts/misc")) - (psf (string-append (assoc-ref outputs "psf") - "/share/consolefonts")) + (pcf (string-append (assoc-ref outputs "out") + "/share/fonts/portablecompiled")) + (psf (string-append (assoc-ref outputs "out") + "/share/fonts/pcscreen")) (bin (assoc-ref outputs "bin"))) (invoke "make" (string-append "PREFIX=" bin) -- 2.26.2