From patchwork Wed Apr 22 15:26:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: L p R n d n X-Patchwork-Id: 21419 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 4C29D27BBE4; Wed, 22 Apr 2020 16:31:03 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 9A88327BBE1 for ; Wed, 22 Apr 2020 16:30:58 +0100 (BST) Received: from localhost ([::1]:52814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRHKz-0006mv-6C for patchwork@mira.cbaines.net; Wed, 22 Apr 2020 11:30:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37728) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRHHG-0002Hx-K5 for guix-patches@gnu.org; Wed, 22 Apr 2020 11:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRHHC-0005IQ-Vp for guix-patches@gnu.org; Wed, 22 Apr 2020 11:27:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRHHC-0005I7-9I for guix-patches@gnu.org; Wed, 22 Apr 2020 11:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRHHC-0001Zy-62 for guix-patches@gnu.org; Wed, 22 Apr 2020 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#35305] LightDM service Resent-From: L p R n d n Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 Apr 2020 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35305 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 35305@debbugs.gnu.org Received: via spool by 35305-submit@debbugs.gnu.org id=B35305.15875691976007 (code B ref 35305); Wed, 22 Apr 2020 15:27:02 +0000 Received: (at 35305) by debbugs.gnu.org; 22 Apr 2020 15:26:37 +0000 Received: from localhost ([127.0.0.1]:52909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRHGc-0001Ya-V6 for submit@debbugs.gnu.org; Wed, 22 Apr 2020 11:26:36 -0400 Received: from mout02.posteo.de ([185.67.36.142]:54937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRHGU-0001YB-FD for 35305@debbugs.gnu.org; Wed, 22 Apr 2020 11:26:25 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id D9B00240104 for <35305@debbugs.gnu.org>; Wed, 22 Apr 2020 17:26:11 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 496kmG1Fk5z9rxD for <35305@debbugs.gnu.org>; Wed, 22 Apr 2020 17:26:05 +0200 (CEST) From: L p R n d n References: <87sghcir5k.fsf@lprndn.info> <2d2d720d1fd6a6357a171e13953a593b@waegenei.re> Date: Wed, 22 Apr 2020 17:26:04 +0200 In-Reply-To: <2d2d720d1fd6a6357a171e13953a593b@waegenei.re> (Brice Waegeneire's message of "Sun, 12 Apr 2020 09:53:41 +0000") Message-ID: <87tv1bmtir.fsf@lprndn.info> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hello, Here is the new set of patches with quite a few modifications for the service, everything rebased on 1.1.0. After a discussion with bricewge on irc, a new design has been adopted allowing use of multiple seats. To use the service, you can instantiate a lightdm-service-type, a lightdm-gtk-greeter-service-type or both. The service should always find a way to start a working instance of LightDM. :) A non exhaustive list of changes that might need further review: * lightdm-gtk-greeter has its own service extending lightdm-service and others. * Seats configuration use now the lightdm-seat-record-type and can be defined both in the lightdm-service and lightdm-gtk-greeter-service. The greeter now extends the LightDM's service by providing a list of seats. * The `compose` and `extend` field of the lightdm-service-type have seen work for this purpose while keeping compatibility with `set-xorg-configuration`. * extra-config fields are list of strings to avoid weird indentation in the user's config. * Fixed customization of lightdm-gtk-greeter's cursor. * Added some fields to deal with accessibility for lightdm-gtk-greeter-configuration. * Takes default background from guix-artwork. Also a review of PAM services might be nice as I'm not versed in security. However, I didn't get rid of etc-service-type's extension as LightDM's seems to ignore `sessions-directory` when configuration is passed through `--config`. Patches to fix that are welcome but can wait a future patch submission, I think. Otherwise, tested in a WM: default configurations, autologin, sway, changing greeter appearance and everything worked fine. For passwordless login, had to actually delete user's password manually to make it work. I don't know if it's expected. Have a nice day and good review :) L p R n d n From bbdb165bd0a0d91b0ef961fec81060a0f376c25f Mon Sep 17 00:00:00 2001 From: L p R n d n Date: Fri, 17 Apr 2020 11:53:51 +0200 Subject: [PATCH 10/10] gnu: lightdm-gtk-greeter: Set XCURSOR_PATH in wrapper. * gnu/packages/display-managers.scm (lightdm-gtk-greeter)[arguments]: Modify wrap-program phase to add XCURSOR_PATH. --- gnu/packages/display-managers.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gnu/packages/display-managers.scm b/gnu/packages/display-managers.scm index 0a9ae8ee61..43ca05bee4 100644 --- a/gnu/packages/display-managers.scm +++ b/gnu/packages/display-managers.scm @@ -232,11 +232,12 @@ display manager which supports different greeters.") "/sbin/lightdm-gtk-greeter") `("XDG_DATA_DIRS" ":" prefix ,(cons "/run/current-system/profile/share" - (map (lambda (pkg) - (string-append (assoc-ref inputs pkg) "/share")) - '("gtk+" "shared-mime-info" "glib")))) + (map (lambda (pkg) + (string-append (assoc-ref inputs pkg) "/share")) + '("gtk+" "shared-mime-info" "glib")))) `("GTK_PATH" ":" prefix (,(assoc-ref inputs "gtk+"))) - `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+")))) + `("GIO_EXTRA_MODULES" ":" prefix (,(assoc-ref inputs "gtk+"))) + `("XCURSOR_PATH" ":" prefix ("/run/current-system/profile/share/icons"))) #t))))) (synopsis "GTK+ greeter for LightDM") (home-page "https://launchpad.net/lightdm-gtk-greeter") -- 2.26.1