From patchwork Thu Apr 16 17:33:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mathieu Othacehe X-Patchwork-Id: 21302 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id AB6A227BBE4; Thu, 16 Apr 2020 18:35:09 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 83E6527BBE1 for ; Thu, 16 Apr 2020 18:35:09 +0100 (BST) Received: from localhost ([::1]:37504 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP8Pt-0006DZ-10 for patchwork@mira.cbaines.net; Thu, 16 Apr 2020 13:35:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38366) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP8Pm-0006C8-UC for guix-patches@gnu.org; Thu, 16 Apr 2020 13:35:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP8Pm-00034A-17 for guix-patches@gnu.org; Thu, 16 Apr 2020 13:35:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:56010) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jP8Pl-000345-UU for guix-patches@gnu.org; Thu, 16 Apr 2020 13:35:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jP8Pl-0008FR-QW for guix-patches@gnu.org; Thu, 16 Apr 2020 13:35:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40668] [PATCH] installer: Fix backtrace display. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 16 Apr 2020 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40668 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40668@debbugs.gnu.org Cc: Mathieu Othacehe X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158705844631612 (code B ref -1); Thu, 16 Apr 2020 17:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Apr 2020 17:34:06 +0000 Received: from localhost ([127.0.0.1]:39323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jP8Os-0008Do-4X for submit@debbugs.gnu.org; Thu, 16 Apr 2020 13:34:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:40632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jP8Op-0008Df-W4 for submit@debbugs.gnu.org; Thu, 16 Apr 2020 13:34:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38297) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP8Oo-0005iV-S1 for guix-patches@gnu.org; Thu, 16 Apr 2020 13:34:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP8On-0002dN-QS for guix-patches@gnu.org; Thu, 16 Apr 2020 13:34:02 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:55095) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jP8On-0002cg-Hm for guix-patches@gnu.org; Thu, 16 Apr 2020 13:34:01 -0400 Received: by mail-wm1-x341.google.com with SMTP id h2so5470761wmb.4 for ; Thu, 16 Apr 2020 10:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=T9M/eRZ6ON2b3gu8N79l7b7xTtbVuXylNxXQQaw6uQU=; b=Ee2m23CZ+wlkQDIf9WpomMMtGgiByiCGBzWbBxKoikVVICD1wfYqRgazSvlpApBrah 55tGIkbpOqRDO2oAfHmgwU7jVGIRr3L45dffkBVE5A7COODKuozbkeU3ambMN2b/Q7W6 Pg5LWuwvDDqgYaeKSjO3N0hi2il1qbbAzeWviySTG/9vV8v9gHsdX7VUdZFZBw7DV97q Vxf+63yaSaOuYTyySUE81ynDCFdOdeTHryOtFhzFQw3+IhONebnjDQmn7Yq4+ncLCt2s 2+6jtbJiz/S9k+IprRsptbpvQzlHzS4uF7alqJTIiZpvlf7ZdM1W72AfhgTasRlLX1Xb JHkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=T9M/eRZ6ON2b3gu8N79l7b7xTtbVuXylNxXQQaw6uQU=; b=qyVKRf/6We6plfZ51LAF2geS7WaKS5be18WLeUBisP2rs5TmCPD4bpe1F4+6s2Lyxu CXzoaX1MIy/e+zGhkf1cj19O/jmgeXWDjw7PYHEHkwtu713V9xpB8SnDW9SJPlbSn76l OcD3FsaRVkul6972r5ErYOwlygN94KZuBwj/yMOmcq63lF7Qifyw4etEVTLotFzDFE8q mXGvE4VnRXHWDQikb9BKkU6P09Ye2JGDdxEyg3XArpLWkvk0zocEUnK/U5NKfk1vNYpT K8tjWs/dvR18RImIHqkxQ7LSYxnwMwrzEfjtUUylT08TOa8lhnu5Qzig4HaqIeR9giJf FVvA== X-Gm-Message-State: AGi0PuYZfQVDzOOPS1KHSIBg3OxsMQXiM7WVrW5MZj0MoEmUJfTpDNaC tjX44g/rAgCkwcJYXuams4Egl5aB8cQ= X-Google-Smtp-Source: APiQypKir+qctv71qlgwEvHuhWlHzmdFy2D2+4YC2/8uw3gRHMXSF8deQTVKiEVqVk5TvPVT06Ln2g== X-Received: by 2002:a1c:4085:: with SMTP id n127mr6279676wma.163.1587058439777; Thu, 16 Apr 2020 10:33:59 -0700 (PDT) Received: from meru.fronius.com ([2a01:cb18:832e:5f00:25e7:da4f:b379:3b41]) by smtp.gmail.com with ESMTPSA id q17sm4276401wmj.45.2020.04.16.10.33.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2020 10:33:59 -0700 (PDT) From: Mathieu Othacehe Date: Thu, 16 Apr 2020 19:33:54 +0200 Message-Id: <20200416173354.11807-1-m.othacehe@gmail.com> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches The 'syslog' macro cannot be resolved in the pre-unwind-handler context. Failed to resolve 'syslog' in this context resulted in the swallowing of all installation errors. Fixes 5c04b00cf463a543b8ffc9eb55991f6b4cc145dd. * gnu/installer.scm (installer-program): Do not try to resolve 'syslog' macro in the pre-unwind-handler. --- Hello, Since the commit 5c04b00c, error reporting in the installer is broken. Sadly this means that every error happening in the 1.1.0 release will result in an installer restart, without any error information reporting. Thanks, Mathieu gnu/installer.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/installer.scm b/gnu/installer.scm index 1051ee1e5f..eba8a7d428 100644 --- a/gnu/installer.scm +++ b/gnu/installer.scm @@ -436,8 +436,9 @@ selected keymap." #f))) (const #f) (lambda (key . args) - (syslog "crashing due to uncaught exception: ~s ~s~%" - key args) + ((@@ (gnu installer utils) syslog) + "crashing due to uncaught exception: ~s ~s~%" + key args) (let ((error-file "/tmp/last-installer-error")) (call-with-output-file error-file (lambda (port)