From patchwork Sat Apr 11 16:53:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre Langlois X-Patchwork-Id: 21193 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6EC2527BBE4; Sat, 11 Apr 2020 17:54:56 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,T_DKIM_INVALID, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id DD00427BBE1 for ; Sat, 11 Apr 2020 17:54:55 +0100 (BST) Received: from localhost ([::1]:53672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNJPC-0006jR-5F for patchwork@mira.cbaines.net; Sat, 11 Apr 2020 12:54:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53628) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNJON-0006hb-It for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNJOM-0007zw-EM for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:45492) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNJOM-0007zh-5q for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNJOM-0008Dj-4M for guix-patches@gnu.org; Sat, 11 Apr 2020 12:54:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40556] [PATCH] gnu: dovecot: Add libunwind input. Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 11 Apr 2020 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40556 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: Pierre Langlois , 40556@debbugs.gnu.org Received: via spool by 40556-submit@debbugs.gnu.org id=B40556.158662403931590 (code B ref 40556); Sat, 11 Apr 2020 16:54:02 +0000 Received: (at 40556) by debbugs.gnu.org; 11 Apr 2020 16:53:59 +0000 Received: from localhost ([127.0.0.1]:57038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNJOG-0008DM-1t for submit@debbugs.gnu.org; Sat, 11 Apr 2020 12:53:59 -0400 Received: from mout.gmx.net ([212.227.15.18]:42937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNJOD-0008D8-CA for 40556@debbugs.gnu.org; Sat, 11 Apr 2020 12:53:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1586624013; bh=gvXdEe/MrfUGgZQIxd7U9Yx+17Ml4TQHEWFXrehxA68=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=h6cWmW/zb/0t6Q1MgmYrPteyAAJUQxx79UywIurahfBaoy5fGn2dChcpq7eXyqf/+ 7rfmXfL5Mk5Zd6CDrpkngBZr1ZVs/J7q/HrgbRrjKw4VAQOReuTpaHH4BFFICobdp4 B1ajDoOEuDiwATSp3sbLPsJrNurCPK2HxKNXGUO8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e119807-lin ([77.130.233.32]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1M1poA-1jPWJ23800-002JOs; Sat, 11 Apr 2020 18:53:32 +0200 References: <87ftdahvut.fsf@gmx.com> <875ze6ngmg.fsf@nckx> User-agent: mu4e 1.2.0; emacs 26.3 From: Pierre Langlois In-reply-to: <875ze6ngmg.fsf@nckx> Date: Sat, 11 Apr 2020 18:53:29 +0200 Message-ID: <87eesuhsl2.fsf@gmx.com> MIME-Version: 1.0 X-Provags-ID: V03:K1:Yglgail7+W/h7AhN2MgAEWs48csFRpQ/diTVd09bbISPWslJSXb UyFdQLql4wdcLEhRqpEWVZL5hdojZEldhP5PXFxu8LnNmpnY6kS+1YVV0VCFNzvGlMgOD0W H8HCmj/0m+lFaFg36TErtegE2KEyoAVVKe+FZe1v70ldbs/UHcsRxPRp666Nehsik0HpBdb 1hezj0UX/Q2soKnHzQfIA== X-UI-Out-Filterresults: notjunk:1;V03:K0:94pV5YXrkXk=:C0zR4mvX+Vv3FvVahWLhME Cow14rEIqSamhmfHWzRUWaDnTz0Lb3gfHrhoxShQwLo+KbY3habZ95onHW8kH9KDqf3YU29eV tvczqpOczMf+8Op4hGbNkopQB71kuH7nsFVfiasRF+vYR9Lsh7tlVFC3ygvtDQBZ3YTD7e9H/ CICM64VCnos+/kqkmtmXsyD1AsizzNFgMHlJ+cu7AJ3OyPiVD12Gzh+JSaE5kNwrwZW1Ncur/ H6TvAA0WtRDezH/SDw90t9G8sbXYSsTjn1vHmS2+EW2feqjWKLaqvh8mqfPH16g9EyrXF2W4r Li4rcDCQ+5DFGreH3aNH4MHsfXl1U3FnuTGJ6yvg0mt0Pyzg1vqare1JaQDTWEFNMS1qBFZmW 4PFv9+M5pFhLrXuJ0GMPt/AlRb2O7Z2kR7CP0tByYd+DoftlRaZfb2Ej7S1Hlf50+ZKm/s4em ldh4trAJOk0z2gvk9DOqrFpXD8aP7WZ+bq0ZdhNL+hD3MCGkNmV8asi0UlSZlxreqbSHmMden 7aS622HMa6Ef7xJ7vsJpknNlsgELhNhQkN0bN5MyIonREcLJEX40gjRfknlQpJnE8K3jT8Cwo 8bB+bRg/r4vKnFItnuueuYMG3xTLeKxgMSD8vfAFcHcn81WKUfzRQjd2w+WqDKjW0zuolRih2 iM4vz/4M+iSrwg6OJRQwtj/XkNo3oZe9UmZBG2GadAKragTUqoGP0lyuQh/7FFHiEjXJAMP2P q9eZPe4ECOlHeoiCZke9s5f08PLKoRwIKyYe4qZVzyuWASuEF3rInPr3r/m1/08+xbgEzrFUg AGR2TnPp2ZcUr3KdqJOgZIdnFx4XbhJ7JmtrL42kGsFsMO4oBJW8uOOYavmn+10LJexEOfciF ev5PhiMdREzRD+mJTdiQ3tTW4DcCvkoh2UboiZUUJtpXPtAIrGqxqE/eH0kzc61btMjAQrVGI G4E/vSLEpl9JN0EfKfDUGu+bUdYWLijEjfdzzDVwyQZrgbp5gJGgxFGrwdf93c7ReDDW/rlfv lFBa0XOqaNFgV9MBfN8kmauPXldD8+a0Q8qUfdx1Ey3l1/uR+jlociJ9NZnZUUoW0ZK2pQFRj EV/HAkcUOSuyLjWTI+lmHvnbssLVJocnxhkila7M7ijirGlE3Oew8y2HDHh/hfq9/EpK4Om34 4HNEEImeR0vqcv/F9vAZpQs94JvYVMpe7uxnWcN7Gi3/YwDPaKyaChnFiMRtntm7MwXOqMGm3 EXTjZ2m77r167EcCf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Tobias Geerinckx-Rice writes: > Pierre, > > Pierre Langlois 写道： >> I wonder what's wrong with backtrace_symbols() in guix, I'm not sure >> how >> to investigate that. For now though, what do you think of using >> libunwind? > > OK, but it should only be included on platforms that require it: Oh sure thing! > > ;; Untested… > (inputs > `(… > ,@(match (%current-system) > ((or "aarch64-linux" "armhf-linux" …) > `(("libunwind" ,libunwind))) > (_ `())) > …)) > > Could you test that? OK, the following patch works for me (tested building for armhf and aarch64 on a rockpro64). I've also added a "FIXME" comment to mention the issue so we can remove/keep it when we have a good understanding of what's going on. Thanks, Pierre From ea4c7a2dec7c81951cf0d27cbb669ef39b07de95 Mon Sep 17 00:00:00 2001 From: Pierre Langlois Date: Sat, 11 Apr 2020 16:34:01 +0100 Subject: [PATCH] gnu: dovecot: Add libunwind input for arm. * gnu/packages/mail.scm (dovecot)[inputs]: Add libunwind if the system is either aarch64-linux or armhf-linux. --- gnu/packages/mail.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm index a6ed776db1..91577f72b1 100644 --- a/gnu/packages/mail.scm +++ b/gnu/packages/mail.scm @@ -24,7 +24,7 @@ ;;; Copyright © 2017 Kyle Meyer ;;; Copyright © 2017, 2018, 2019, 2020 Tobias Geerinckx-Rice ;;; Copyright © 2017, 2018 Rene Saavedra -;;; Copyright © 2018, 2019 Pierre Langlois +;;; Copyright © 2018, 2019, 2020 Pierre Langlois ;;; Copyright © 2018 Alex Vong ;;; Copyright © 2018 Gábor Boskovits ;;; Copyright © 2018, 2019, 2020 Ricardo Wurmus @@ -89,6 +89,7 @@ #:use-module (gnu packages libevent) #:use-module (gnu packages libidn) #:use-module (gnu packages libunistring) + #:use-module (gnu packages libunwind) #:use-module (gnu packages linux) #:use-module (gnu packages lsof) #:use-module (gnu packages lua) @@ -1435,6 +1436,12 @@ facilities for checking incoming mail.") (inputs `(("bzip2" ,bzip2) ("libsodium" ,libsodium) ; extra password algorithms + ;; FIXME: The 'test-backtrace' tests fail on arm when using glibc's + ;; backtrace_symbol() function so fallback to using libunwind. + ,@(match (or (%current-target-system) (%current-system)) + ((or "aarch64-linux" "armhf-linux") + `(("libunwind" ,libunwind))) + (_ '())) ("linux-pam" ,linux-pam) ("lz4" ,lz4) ("openssl" ,openssl) -- 2.26.0