From patchwork Wed Jan 2 18:46:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 645 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2E282169F6; Wed, 2 Jan 2019 18:47:37 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id C9E35169F4 for ; Wed, 2 Jan 2019 18:47:36 +0000 (GMT) Received: from localhost ([127.0.0.1]:46764 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelYG-000633-F1 for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:47:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelXv-0005lt-Da for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelXn-0000FE-OL for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43504) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelXi-0000Be-55 for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelXi-00087T-2e for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 1/6] gnu: kcoreaddons: Enable test-suite. References: <20190102184521.8001-1-h.goebel@crazy-compilers.com> In-Reply-To: <20190102184521.8001-1-h.goebel@crazy-compilers.com> Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645481431147 (code B ref 33955); Wed, 02 Jan 2019 18:47:02 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:46:54 +0000 Received: from localhost ([127.0.0.1]:44983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXa-00086I-JW for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:54 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:56797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXY-000863-Uf for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:53 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKlc02xJz1rdP8 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:51 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKlb5qQZz1qqlC for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:51 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ZflUjOYwzaNT for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:51 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:51 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 360DE6018A for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:45 +0100 Message-Id: <20190102184650.8075-1-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Enable running the tests and blacklist the one failing test. * gnu/package/kde-frameworks.scm(kcoreaddons)[arguments] <#:tests?>: Remove. <#:phases>: Add phase 'blacklist-failing-test. --- gnu/packages/kde-frameworks.scm | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 5ab97c0b0..35e10015e 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -566,9 +566,16 @@ propagate their changes to their respective configuration files.") (inputs `(("qtbase" ,qtbase))) (arguments - `(#:tests? #f ; FIXME: Test failure caused by stout/stderr being interleaved. - #:phases + `(#:phases (modify-phases %standard-phases + (add-before 'check 'blacklist-failing-test + (lambda _ + ;; Blacklist a failing test-function. FIXME: Make it pass. + ;; Test failure caused by stout/stderr being interleaved. + (with-output-to-file "autotests/BLACKLIST" + (lambda _ + (display "[test_channels]\n*\n"))) + #t)) (add-before 'check 'check-setup (lambda _ (setenv "HOME" (getcwd)) From patchwork Wed Jan 2 18:46:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 642 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 5A9F7169F6; Wed, 2 Jan 2019 18:47:23 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id 10232169F4 for ; Wed, 2 Jan 2019 18:47:23 +0000 (GMT) Received: from localhost ([127.0.0.1]:46758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelY2-0005mb-KN for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:47:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelXv-0005lv-Dd for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelXn-0000F8-OD for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:54787) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelXi-0000C2-Lu for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelXi-00087b-Iu for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 2/6] gnu: kirigami: Enable test-suite. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645481631162 (code B ref 33955); Wed, 02 Jan 2019 18:47:02 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:46:56 +0000 Received: from localhost ([127.0.0.1]:44986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXb-00086W-RI for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:56 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:41100) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXZ-00086A-QH for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:54 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKld1xrWz1rK4P for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:53 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKld1rVsz1qqlC for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:53 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id bs1R65xhISkD for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:52 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:52 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 5576160227 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:46 +0100 Message-Id: <20190102184650.8075-2-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com> References: <20190102184650.8075-1-h.goebel@crazy-compilers.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches The error which inhibited running the tests no longer occurs in 5.49.0, although now no tests are found at all. Since no tests are found now, the phase 'check-setup can be removed, too, and thus the 'arguments' at all. * gnu/packages/kde-frameworks.scm(kirigami)[arguments]: Remove. --- gnu/packages/kde-frameworks.scm | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 35e10015e..62cf49c57 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -804,19 +804,6 @@ or user activity.") ("qtsvg" ,qtsvg) ;; Run-time dependency ("qtgraphicaleffects" ,qtgraphicaleffects))) - (arguments - `(#:tests? #f ;; FIXME: Test suite is broken, - ;; see https://bugs.kde.org/show_bug.cgi?id=386456 - ;; Note for when enabling the tests: The test-suite is meant to be run - ;; without prior installation, see - ;; https://cgit.kde.org/kirigami.git/commit/?id=24ad2c9 - #:phases - (modify-phases %standard-phases - (add-before 'check 'check-setup - (lambda* (#:key outputs #:allow-other-keys) - ;; make Qt render "offscreen", required for tests - (setenv "QT_QPA_PLATFORM" "offscreen") - #t))))) (home-page "https://community.kde.org/Frameworks") (synopsis "QtQuick components for mobile user interfaces") (description "Kirigami is a set of high level QtQuick components looking From patchwork Wed Jan 2 18:46:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 644 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 2091E169F6; Wed, 2 Jan 2019 18:47:35 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from listsout.gnu.org (listsout.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id D1CD4169F4 for ; Wed, 2 Jan 2019 18:47:34 +0000 (GMT) Received: from localhost ([127.0.0.1]:46762 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelYE-0005yw-GO for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:47:34 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelXv-0005lw-EL for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelXn-0000FS-OY for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33053) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelXj-0000CA-4r for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelXj-00087j-2J for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 3/6] gnu: kpackage: Enable test-suite. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645481631173 (code B ref 33955); Wed, 02 Jan 2019 18:47:03 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:46:56 +0000 Received: from localhost ([127.0.0.1]:44989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXc-00086Z-7R for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:56 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:46761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXa-00086H-SA for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:55 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKlf2GMfz1s31X for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:54 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKlf29QMz1qqlC for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:54 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id R3w0Ac0xwbUT for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:53 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:53 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 6A7986029B for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:47 +0100 Message-Id: <20190102184650.8075-3-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com> References: <20190102184650.8075-1-h.goebel@crazy-compilers.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/package/kde-frameworks.scm(kpackage)[arguments] <#:tests?>: Remove. <#:phases>: Add phase 'patch-tests. --- gnu/packages/kde-frameworks.scm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 62cf49c57..07e30d4cf 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -1834,8 +1834,7 @@ covers feedback and persistent events.") ("ki18n" ,ki18n) ("qtbase" ,qtbase))) (arguments - `(#:tests? #f ; FIXME: 3/9 tests fail. - #:phases + `(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch (lambda _ @@ -1847,6 +1846,17 @@ covers feedback and persistent events.") (("^\\s*(QDirIterator it\\(.*, QDirIterator::Subdirectories)(\\);)" _ a b) (string-append a " | QDirIterator::FollowSymlinks" b))) #t)) + (add-after 'unpack 'patch-tests + (lambda _ + ;; /bin/ls doesn't exist in the build-container use /etc/passwd + (substitute* "autotests/packagestructuretest.cpp" + (("(addDirectoryDefinition\\(\")bin(\".*\")bin(\".*\")bin\"" + _ a b c) + (string-append a "etc" b "etc" c "etc\"")) + (("filePath\\(\"bin\", QStringLiteral\\(\"ls\"))") + "filePath(\"etc\", QStringLiteral(\"passwd\"))") + (("\"/bin/ls\"") "\"/etc/passwd\"")) + #t)) (add-before 'check 'check-setup (lambda _ (setenv "HOME" (getcwd)) From patchwork Wed Jan 2 18:46:48 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 641 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id EE822169F6; Wed, 2 Jan 2019 18:47:22 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id AE9F0169F4 for ; Wed, 2 Jan 2019 18:47:22 +0000 (GMT) Received: from localhost ([127.0.0.1]:46756 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelY2-0005mL-Ag for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:47:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelXv-0005lu-Df for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelXn-0000FD-OP for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:49294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelXj-0000CS-Jp for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelXj-00087q-GS for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:03 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 4/6] gnu: kemoticons: Enable test-suite. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645481731182 (code B ref 33955); Wed, 02 Jan 2019 18:47:03 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:46:57 +0000 Received: from localhost ([127.0.0.1]:44991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXd-00086r-G9 for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:57 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:46415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXb-00086V-SE for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:56 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKlg2KV2z1s31X for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:55 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKlg2Dgkz1qqlC for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:55 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id slMPpTlyT97s for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:54 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:54 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 7F86F60350 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:48 +0100 Message-Id: <20190102184650.8075-4-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com> References: <20190102184650.8075-1-h.goebel@crazy-compilers.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Without anything changed the test-suite now passes, thus can be enabled. * gnu/package/kde-frameworks.scm(kemoticons)[arguments]<#:tests?>: Remove. --- gnu/packages/kde-frameworks.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 07e30d4cf..079a8a75e 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -2423,8 +2423,7 @@ engine WebKit via QtWebKit.") ("kcoreaddons" ,kcoreaddons) ("qtbase" ,qtbase))) (arguments - `(#:tests? #f ; FIXME: 2/2 tests fail. - #:phases + `(#:phases (modify-phases %standard-phases (add-before 'check 'check-setup (lambda _ From patchwork Wed Jan 2 18:46:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 643 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id B5282169F6; Wed, 2 Jan 2019 18:47:25 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id 77A88169F4 for ; Wed, 2 Jan 2019 18:47:25 +0000 (GMT) Received: from localhost ([127.0.0.1]:46760 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelY5-0005ul-3u for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:47:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelXv-0005lx-EV for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelXn-0000G4-TO for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:11 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:41632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelXk-0000Cl-3G for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelXk-000880-0k for guix-patches@gnu.org; Wed, 02 Jan 2019 13:47:04 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 5/6] gnu: knewstuff: Enable test-suite. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:47:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645482031198 (code B ref 33955); Wed, 02 Jan 2019 18:47:03 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:47:00 +0000 Received: from localhost ([127.0.0.1]:44994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXf-000878-Qf for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:47:00 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:36621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXd-00086s-Vk for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:46:58 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKlj38W5z1s31X for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:57 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKlj33tjz1qqlC for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:57 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id tFUMyN_JotAA for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:55 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:55 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id 920DC60352 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:49 +0100 Message-Id: <20190102184650.8075-5-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com> References: <20190102184650.8075-1-h.goebel@crazy-compilers.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Without anything changed the test-suite now passes, thus can be enabled. * gnu/package/kde-frameworks.scm(knewstuff)[arguments]<#:tests?>: Remove. --- gnu/packages/kde-frameworks.scm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 079a8a75e..45580cb5f 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -2727,8 +2727,7 @@ KIO enabled infrastructure.") ("solid" ,solid) ("sonnet" ,sonnet))) (arguments - `(#:tests? #f ; FIXME: 1/3 tests fail. - #:phases + `(#:phases (modify-phases %standard-phases (add-before 'check 'check-setup (lambda _ ; XDG_DATA_DIRS isn't set From patchwork Wed Jan 2 18:46:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Hartmut Goebel X-Patchwork-Id: 646 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 7BAF0169F6; Wed, 2 Jan 2019 18:48:18 +0000 (GMT) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) by mira.cbaines.net (Postfix) with ESMTP id 007BC169F4 for ; Wed, 2 Jan 2019 18:48:18 +0000 (GMT) Received: from localhost ([127.0.0.1]:46768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelYv-0006BO-JZ for patchwork@mira.cbaines.net; Wed, 02 Jan 2019 13:48:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:42891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gelYl-00069m-8n for guix-patches@gnu.org; Wed, 02 Jan 2019 13:48:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gelYh-0001Ot-5N for guix-patches@gnu.org; Wed, 02 Jan 2019 13:48:07 -0500 Received: from debbugsout.gnu.org ([209.51.188.43]:54452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gelYg-0001Oa-TB for guix-patches@gnu.org; Wed, 02 Jan 2019 13:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gelYg-00089V-Bl for guix-patches@gnu.org; Wed, 02 Jan 2019 13:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#33955] [PATCH 6/6] gnu: kwindowsystem: Enable test-suite. Resent-From: Hartmut Goebel Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jan 2019 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33955 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 33955@debbugs.gnu.org Received: via spool by 33955-submit@debbugs.gnu.org id=B33955.154645482831271 (code B ref 33955); Wed, 02 Jan 2019 18:48:02 +0000 Received: (at 33955) by debbugs.gnu.org; 2 Jan 2019 18:47:08 +0000 Received: from localhost ([127.0.0.1]:44997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXi-00087X-66 for submit@debbugs.gnu.org; Wed, 02 Jan 2019 13:47:07 -0500 Received: from mail-out.m-online.net ([212.18.0.9]:47572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gelXf-000877-SA for 33955@debbugs.gnu.org; Wed, 02 Jan 2019 13:47:00 -0500 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 43VKll15V0z1rMY8 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:59 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 43VKll06Hcz1qvWY for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:59 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id ZiJ4KSXSXLDx for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:57 +0100 (CET) Received: from hermia.goebel-consult.de (ppp-83-171-175-25.dynamic.mnet-online.de [83.171.175.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:46:57 +0100 (CET) Received: from lenashee.goebel-consult.de (lenashee.goebel-consult.de [192.168.110.2]) by hermia.goebel-consult.de (Postfix) with ESMTP id A43BF60374 for <33955@debbugs.gnu.org>; Wed, 2 Jan 2019 19:49:45 +0100 (CET) From: Hartmut Goebel Date: Wed, 2 Jan 2019 19:46:50 +0100 Message-Id: <20190102184650.8075-6-h.goebel@crazy-compilers.com> X-Mailer: git-send-email 2.13.7 In-Reply-To: <20190102184650.8075-1-h.goebel@crazy-compilers.com> References: <20190102184650.8075-1-h.goebel@crazy-compilers.com> MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/package/kde-frameworks.scm(kwindowsystem) [inputs]: Add openbox. [arguments] <#:tests?> Remove. <#:phases> 'blacklist-failing-tests: New phase. <#:phases> 'check: Start openbox, don't set QT_PLUGIN_PATH, use invkove, simplify and cleanup code. No longer move 'check behind install. --- gnu/packages/kde-frameworks.scm | 47 +++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 25 deletions(-) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 45580cb5f..72fd8f20f 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -1,7 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright © 2015 Andreas Enge ;;; Copyright © 2016 Efraim Flashner -;;; Copyright © 2016,2017,2018 Hartmut Goebel +;;; Copyright © 2016-2019 Hartmut Goebel ;;; Copyright © 2016 David Craven ;;; Copyright © 2017 Thomas Danckaert ;;; Copyright © 2018 Tobias Geerinckx-Rice @@ -56,6 +56,7 @@ #:use-module (gnu packages libreoffice) #:use-module (gnu packages linux) #:use-module (gnu packages mp3) + #:use-module (gnu packages openbox) #:use-module (gnu packages pdf) #:use-module (gnu packages pcre) #:use-module (gnu packages perl) @@ -1093,6 +1094,7 @@ configuration pages, message boxes, and password requests.") `(("extra-cmake-modules" ,extra-cmake-modules) ("pkg-config" ,pkg-config) ("dbus" ,dbus) ; for the tests + ("openbox" ,openbox) ; for the tests ("qttools" ,qttools) ("xorg-server" ,xorg-server))) ; for the tests (inputs @@ -1101,31 +1103,26 @@ configuration pages, message boxes, and password requests.") ("qtx11extras" ,qtx11extras) ("xcb-utils-keysyms" ,xcb-util-keysyms))) (arguments - `(#:tests? #f ; FIXME: 3/12 tests fail. - #:phases + `(#:phases (modify-phases %standard-phases - (delete 'check) - (add-after 'install 'check - (lambda* (#:key inputs outputs tests? #:allow-other-keys) - ;; TODO: Simplify and use "common" phases when test-suite passes - (if tests? - (begin - (let ((out (assoc-ref outputs "out"))) - (setenv "QT_PLUGIN_PATH" - (string-append out "/lib/qt5/plugins:" - (getenv "QT_PLUGIN_PATH")))) - ;; The test suite requires a running X server, setting - ;; QT_QPA_PLATFORM=offscreen does not suffice and even make - ;; some tests fail. - (system (string-append (assoc-ref inputs "xorg-server") - "/bin/Xvfb :1 -screen 0 640x480x24 &")) - (setenv "DISPLAY" ":1") - (setenv "CTEST_OUTPUT_ON_FAILURE" "1") - (setenv "DBUS_FATAL_WARNINGS" "0") - (zero? (system* "dbus-launch" "ctest" "."))) - (begin - (format #t "test suite not run~%") - #t))))))) + (add-before 'check 'blacklist-failing-tests + (lambda _ + ;; Blacklist a failing test-functions. FIXME: Make it pass. + (with-output-to-file "autotests/BLACKLIST" + (lambda _ + (display "[testState]\n*\n") + (display "[testSupported]\n*\n"))) + #t)) + (replace 'check + (lambda _ + ;; The test suite requires a running window anager + (system "Xvfb :1 -ac -screen 0 640x480x24 &") + (setenv "DISPLAY" ":1") + (sleep 5) ;; Give Xvfb a few moments to get on it's feet + (system "openbox &") + (setenv "CTEST_OUTPUT_ON_FAILURE" "1") + (setenv "DBUS_FATAL_WARNINGS" "0") + (invoke "dbus-launch" "ctest" ".")))))) (home-page "https://community.kde.org/Frameworks") (synopsis "KDE access to the windowing system") (description "KWindowSystem provides information about and allows