From patchwork Mon Mar 30 18:39:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Soo X-Patchwork-Id: 21001 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 120C827BBE1; Mon, 30 Mar 2020 19:40:12 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 4055327BBE4 for ; Mon, 30 Mar 2020 19:40:11 +0100 (BST) Received: from localhost ([::1]:54890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzKU-0002z0-Oj for patchwork@mira.cbaines.net; Mon, 30 Mar 2020 14:40:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47045) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIzKO-0002yt-1B for guix-patches@gnu.org; Mon, 30 Mar 2020 14:40:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIzKM-0007Jw-Oc for guix-patches@gnu.org; Mon, 30 Mar 2020 14:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51749) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIzKM-0007Jf-Eq for guix-patches@gnu.org; Mon, 30 Mar 2020 14:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIzKM-0008WO-Bt for guix-patches@gnu.org; Mon, 30 Mar 2020 14:40:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40304] [PATCH] gnu: Add emacs-dhall-mode. Resent-From: John Soo Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 30 Mar 2020 18:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40304 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Goaziou Cc: 40304@debbugs.gnu.org Received: via spool by 40304-submit@debbugs.gnu.org id=B40304.158559360032740 (code B ref 40304); Mon, 30 Mar 2020 18:40:02 +0000 Received: (at 40304) by debbugs.gnu.org; 30 Mar 2020 18:40:00 +0000 Received: from localhost ([127.0.0.1]:35062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzKJ-0008Vz-Lm for submit@debbugs.gnu.org; Mon, 30 Mar 2020 14:39:59 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:41005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIzKH-0008Vk-W9 for 40304@debbugs.gnu.org; Mon, 30 Mar 2020 14:39:58 -0400 Received: by mail-pg1-f194.google.com with SMTP id b1so9072969pgm.8 for <40304@debbugs.gnu.org>; Mon, 30 Mar 2020 11:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=asu-edu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lUKz4sGtW6doBDnhFJgKGWAngGZBYV94JsGWiVkGeX4=; b=j5ftF5ia3Zm8TQjCymGf0AM9ZYLPvmpK4NW3/BkQl3GOvfU1zHq9ZhmbkQW9Z9a3NY sf3Rh1/pVe9EoGAgAZqwi8HbCf4BJ4Zt+1LbvfMfPi2PnWqzGjayqMs/zElCUe0x0MX9 PQUOF0imZ8uDaNFSfiDQzKMZRGRVBOgZG+bQfasVgu/t6bz4wzWialNe/LHCklnpgQTg n3NGhdCwxv0wZppmXMzAohKeXd+B0uPoeUXXCRe+/rm04ELnba8ifKwPCUH1QSQzVfw9 qJXXPIPPTvUZcRgkX7yAWyUUXHx9AOum4icXbEgi6piYEUH8XhJSdk3FnZIpNk/koD8L ckjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lUKz4sGtW6doBDnhFJgKGWAngGZBYV94JsGWiVkGeX4=; b=WQEf23iiWbB8mdIncXpQqAowo/U2L4J6/oXzvHDq3oNcuWOMrKa6fS9cFLLFMcYZ2X +pHv2JpMQOHQShZzrSxPUXoRlk+I6GPoMNXyEoPGEx9HJeTPqs/1+e42WZieDOI4Hy9L VIQ8QNn+zPfkDbAPCT5hsbUirxx5QBtSPHaJ7fBmzvzt2Q0LfhWsNgp49dAMb3YmjfVG ZcEI3GSvkSeRcoAYhAQGjCYewCdyvTgxeaGNmTyoO7xFTt8iFZ/1yePDBSrAWUCZcE/M K0toqiWQFkbAZE1yg38moxcWpR57SLIjk0nM/r8NakOVy68O5rreCIP4yc4H6n9VuVBC UG2Q== X-Gm-Message-State: AGi0PuYvGMJibW7HxmJMmfz5hDtQ+E2Cm9W6IuI3s4VUpr0H+VHmQayr 1tAHVynB8sf7piWbKA8a51+y6L3ANtqdYQ== X-Google-Smtp-Source: APiQypLQ/wsAC6bKa3dsyw0xDUKpAcws1ilnQmYNMRByts42KCgx3huG6KZ9i/OVQ3daJiLZOP2fgQ== X-Received: by 2002:a63:553:: with SMTP id 80mr9180243pgf.147.1585593591743; Mon, 30 Mar 2020 11:39:51 -0700 (PDT) Received: from ecenter ([2600:1700:83b0:8bd0::6c3]) by smtp.gmail.com with ESMTPSA id m9sm10098097pga.92.2020.03.30.11.39.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Mar 2020 11:39:51 -0700 (PDT) From: John Soo References: <878sjk2byr.fsf@asu.edu> <87wo7169il.fsf@nicolasgoaziou.fr> Date: Mon, 30 Mar 2020 11:39:49 -0700 In-Reply-To: <87wo7169il.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Mon, 30 Mar 2020 19:24:34 +0200") Message-ID: <87y2rhvg96.fsf@asu.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches Hi Nicolas, Thanks again! Nicolas Goaziou writes: > Hello, > > John Soo writes: > >> dhall-mode provides language support for the dhall configuration >> language. > > Thank you. > >> +(define-public emacs-dhall-mode >> + (package >> + (name "emacs-dhall-mode") >> + (version "0.1.0") > > This version is not accurate. The ".el" file mentions 0.1.3, but I think > we should use Github versioning, i.e., there is no versioning at all, so > we should do the commit + revision dance again, and use "0.1.3" as the > base of the version string. Done. >> + (source >> + (origin >> + (method git-fetch) >> + (uri >> + (git-reference >> + (url "https://github.com/psibi/dhall-mode") >> + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2"))) > > This should go in a dedicated variable. Did you mean the commit? If so that is also done. >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384")))) > > Nitpick: I usually put `base32' on the same line as the string. Ok, I like that better. Done. >> + (inputs > > Nitpick: Emacs build system uses `propagated-inputs', although this is > the same. Oh! I think that's a bug, then. If the input is not propagated, there will be an error when the user uses the package, right? Fixed. >> + `(("emacs-reformatter" ,emacs-reformatter))) >> + (build-system emacs-build-system) > > Nitpick: `build-system' is usually above No problem. Done. >> + (home-page "https://github.com/psibi/dhall-mode") >> + (synopsis "Major mode for working with Dhall configuration language") >> + (description >> + "Emacs Major mode for working with Dhall configuration >> language.") > > The description must be a full sentence. Fixed and added some more detail. >> + (license license:gpl2+))) > > The license looks wrong. I see GPL3+ in this package. Ah, fixed, sorry. > Could you send an updated patch? Sure. Attached. Thanks again, John From f964bffab06a381e6476410e5dd409ac5b690fd3 Mon Sep 17 00:00:00 2001 From: John Soo Date: Tue, 24 Mar 2020 08:38:05 -0700 Subject: [PATCH] gnu: Add emacs-dhall-mode. * gnu/packages/emacs-xyz.scm (emacs-dhall-mode): New variable. --- gnu/packages/emacs-xyz.scm | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index c029d1ed3d..fa64ef16bc 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21965,3 +21965,37 @@ enables modal editing and composition of commands, too. It combines ideas of other Editors like Vim or Kakoune and tries to align them with regular Emacs conventions.") (license license:gpl3+))) + +(define-public emacs-dhall-mode + (let ((revision "0") + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")) + (package + (name "emacs-dhall-mode") + (version (git-version "0.1.3" revision commit)) + (source + (origin + (method git-fetch) + (uri + (git-reference + (url "https://github.com/psibi/dhall-mode") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384")))) + (build-system emacs-build-system) + (propagated-inputs + `(("emacs-reformatter" ,emacs-reformatter))) + (home-page "https://github.com/psibi/dhall-mode") + (synopsis "Major mode for working with Dhall configuration language") + (description + "Dhall-mode provides an Emacs Major mode for working with the Dhall +configuration language. It features: + +@itemize +@item Syntax highlighting +@item Multiline support for String +@item Basic indendation, commenting +@item Automatic formatting on save using dhall-format. +@item Error highlighting. +@end itemize") + (license license:gpl3+)))) -- 2.26.0