From patchwork Sun Mar 29 20:32:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Maja_K=C4=85dzio=C5=82ka?= X-Patchwork-Id: 20926 Return-Path: X-Original-To: patchwork@mira.cbaines.net Delivered-To: patchwork@mira.cbaines.net Received: by mira.cbaines.net (Postfix, from userid 113) id 6717827BBE4; Sun, 29 Mar 2020 21:33:12 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.2 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mira.cbaines.net (Postfix) with ESMTP id 3937727BBE1 for ; Sun, 29 Mar 2020 21:33:12 +0100 (BST) Received: from localhost ([::1]:41436 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIecJ-0004MO-QQ for patchwork@mira.cbaines.net; Sun, 29 Mar 2020 16:33:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46336) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIecB-0004M3-Jb for guix-patches@gnu.org; Sun, 29 Mar 2020 16:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIecA-0003JN-Kh for guix-patches@gnu.org; Sun, 29 Mar 2020 16:33:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48444) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jIecA-0003Is-HK for guix-patches@gnu.org; Sun, 29 Mar 2020 16:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jIecA-0003Fm-FD for guix-patches@gnu.org; Sun, 29 Mar 2020 16:33:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#40283] [WIP PATCH] gnu: flint: Build with ntl. Resent-From: Jakub =?utf-8?b?S8SFZHppb8WCa2E=?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Mar 2020 20:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 40283 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 40283@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.158551396112476 (code B ref -1); Sun, 29 Mar 2020 20:33:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Mar 2020 20:32:41 +0000 Received: from localhost ([127.0.0.1]:59990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIebo-0003F8-Hm for submit@debbugs.gnu.org; Sun, 29 Mar 2020 16:32:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:50701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jIebm-0003F0-Qj for submit@debbugs.gnu.org; Sun, 29 Mar 2020 16:32:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46313) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jIebl-0004LX-Nf for guix-patches@gnu.org; Sun, 29 Mar 2020 16:32:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jIebk-0002v5-Ja for guix-patches@gnu.org; Sun, 29 Mar 2020 16:32:37 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:39766) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jIebk-0002l8-Ac for guix-patches@gnu.org; Sun, 29 Mar 2020 16:32:36 -0400 Received: (qmail 28324 invoked by uid 1009); 29 Mar 2020 22:32:28 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25765. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.020428 secs); 29 Mar 2020 20:32:28 -0000 Received: from unknown (HELO localhost.localdomain) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with AES256-SHA encrypted SMTP; 29 Mar 2020 22:32:28 +0200 From: Jakub =?utf-8?b?S8SFZHppb8WCa2E=?= Date: Sun, 29 Mar 2020 22:32:24 +0200 Message-Id: <20200329203224.27052-1-kuba@kadziolka.net> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+patchwork=mira.cbaines.net@gnu.org Sender: "Guix-patches" X-getmail-retrieved-from-mailbox: Patches * gnu/packages/algebra.scm (flint)[inputs]: Add ntl. [arguments]: Pass --with-ntl to configure. --- This is required by sagemath, but the patch as written makes the build error: /gnu/store/9yzqiiyfhxi4yhndp46nndi77ica9g4i-ntl-11.4.3/include/NTL/vector.h:201:31: error: invalid conversion from ‘const NTL::Vec*’ to ‘int’ [-fpermissive] 201 | { VecStrategy::do_BlockConstructFromVec(p, n, q); } | ^~~~~~~~~~~~~~~~~~~~~~~~ | | | const NTL::Vec* Arch Linux seems to be using the same version of ntl and flint, and I don't see any special workarounds in their PKGBUILDs. I guessed that the gcc version might be influencing things, but adding gcc-9 to native-inputs didn't help. Does Guix set up GCC with some non-standard default flags, maybe? gnu/packages/algebra.scm | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gnu/packages/algebra.scm b/gnu/packages/algebra.scm index af50c2d775..99b69eba96 100644 --- a/gnu/packages/algebra.scm +++ b/gnu/packages/algebra.scm @@ -445,6 +445,8 @@ or text interfaces) or as a C++ library.") "11syazv1a8rrnac3wj3hnyhhflpqcmq02q8pqk2m6g2k6h0gxwfb")) (patches (search-patches "flint-ldconfig.patch")))) (build-system gnu-build-system) + (inputs + `(("ntl" ,ntl))) (propagated-inputs `(("gmp" ,gmp) ("mpfr" ,mpfr))) ; header files from both are included by flint/arith.h @@ -456,13 +458,15 @@ or text interfaces) or as a C++ library.") (lambda* (#:key inputs outputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) (gmp (assoc-ref inputs "gmp")) - (mpfr (assoc-ref inputs "mpfr"))) + (mpfr (assoc-ref inputs "mpfr")) + (ntl (assoc-ref inputs "ntl"))) ;; do not pass "--enable-fast-install", which makes the ;; homebrew configure process fail (invoke "./configure" (string-append "--prefix=" out) (string-append "--with-gmp=" gmp) - (string-append "--with-mpfr=" mpfr)) + (string-append "--with-mpfr=" mpfr) + (string-append "--with-ntl=" ntl)) #t)))))) (synopsis "Fast library for number theory") (description